You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/09/30 14:45:18 UTC
[GitHub] [flink] tillrohrmann commented on a change in pull request #9808:
[FLINK-14281] Add DispatcherRunner#getShutDownFuture
tillrohrmann commented on a change in pull request #9808: [FLINK-14281] Add DispatcherRunner#getShutDownFuture
URL: https://github.com/apache/flink/pull/9808#discussion_r329617878
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/entrypoint/component/DispatcherResourceManagerComponent.java
##########
@@ -88,25 +88,7 @@
}
private void registerShutDownFuture() {
- terminationFuture.whenComplete(
- (aVoid, throwable) -> {
- if (throwable != null) {
- shutDownFuture.completeExceptionally(throwable);
- } else {
- shutDownFuture.complete(ApplicationStatus.SUCCEEDED);
- }
- });
-
- dispatcherRunner
- .getTerminationFuture()
- .whenComplete(
- (aVoid, throwable) -> {
- if (throwable != null) {
- shutDownFuture.completeExceptionally(throwable);
- } else {
- shutDownFuture.complete(ApplicationStatus.SUCCEEDED);
- }
- });
+ FutureUtils.forward(dispatcherRunner.getShutDownFuture(), shutDownFuture);
Review comment:
No, the termination of the `JobManagerRunner` should not trigger the shut down logic handling.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services