You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Sanjay Tripathi <sa...@citrix.com> on 2013/07/03 13:43:53 UTC

Review Request 12245: CLOUDSTACK-1960: Fix for UK Keyboard Bar symbol.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12245/
-----------------------------------------------------------

Review request for cloudstack, Animesh Chaturvedi, Fang Wang, and Ram Ganesh.


Bugs: CLOUDSTACK-1960


Repository: cloudstack-git


Description
-------

CLOUDSTACK-1960: Fix for Bar symbol in UK keyboard.

With this fix, cloudStack will support bar symbol i.e. "|" for UK keyboard.


Diffs
-----

  services/console-proxy/server/js/ajaxkeys.js 677962b 

Diff: https://reviews.apache.org/r/12245/diff/


Testing
-------


Thanks,

Sanjay Tripathi


Re: Review Request 12245: CLOUDSTACK-1960: Fix for UK Keyboard Bar symbol.

Posted by Chip Childers <ch...@apache.org>.

> On July 9, 2013, 5:37 p.m., Fang Wang wrote:
> > looks good, ship it.

Did you commit this Fang?


- Chip


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12245/#review22921
-----------------------------------------------------------


On July 3, 2013, 11:43 a.m., Sanjay Tripathi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12245/
> -----------------------------------------------------------
> 
> (Updated July 3, 2013, 11:43 a.m.)
> 
> 
> Review request for cloudstack, Animesh Chaturvedi, Fang Wang, and Ram Ganesh.
> 
> 
> Bugs: CLOUDSTACK-1960
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> CLOUDSTACK-1960: Fix for Bar symbol in UK keyboard.
> 
> With this fix, cloudStack will support bar symbol i.e. "|" for UK keyboard.
> 
> 
> Diffs
> -----
> 
>   services/console-proxy/server/js/ajaxkeys.js 677962b 
> 
> Diff: https://reviews.apache.org/r/12245/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sanjay Tripathi
> 
>


Re: Review Request 12245: CLOUDSTACK-1960: Fix for UK Keyboard Bar symbol.

Posted by Fang Wang <fa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12245/#review22921
-----------------------------------------------------------

Ship it!


looks good, ship it. 

- Fang Wang


On July 3, 2013, 11:43 a.m., Sanjay Tripathi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12245/
> -----------------------------------------------------------
> 
> (Updated July 3, 2013, 11:43 a.m.)
> 
> 
> Review request for cloudstack, Animesh Chaturvedi, Fang Wang, and Ram Ganesh.
> 
> 
> Bugs: CLOUDSTACK-1960
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> CLOUDSTACK-1960: Fix for Bar symbol in UK keyboard.
> 
> With this fix, cloudStack will support bar symbol i.e. "|" for UK keyboard.
> 
> 
> Diffs
> -----
> 
>   services/console-proxy/server/js/ajaxkeys.js 677962b 
> 
> Diff: https://reviews.apache.org/r/12245/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sanjay Tripathi
> 
>


Re: Review Request 12245: CLOUDSTACK-1960: Fix for UK Keyboard Bar symbol.

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12245/#review22994
-----------------------------------------------------------


Commit 8bd1d27315cf1dbac29e2328bbf50c4aff784555 in branch refs/heads/master from Sanjay Tripathi
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=8bd1d27 ]

CLOUDSTACK-1960: Fix for UK Keyboard - Bar symbol i.e. "|".


- ASF Subversion and Git Services


On July 3, 2013, 11:43 a.m., Sanjay Tripathi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12245/
> -----------------------------------------------------------
> 
> (Updated July 3, 2013, 11:43 a.m.)
> 
> 
> Review request for cloudstack, Animesh Chaturvedi, Fang Wang, and Ram Ganesh.
> 
> 
> Bugs: CLOUDSTACK-1960
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> CLOUDSTACK-1960: Fix for Bar symbol in UK keyboard.
> 
> With this fix, cloudStack will support bar symbol i.e. "|" for UK keyboard.
> 
> 
> Diffs
> -----
> 
>   services/console-proxy/server/js/ajaxkeys.js 677962b 
> 
> Diff: https://reviews.apache.org/r/12245/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sanjay Tripathi
> 
>


Re: Review Request 12245: CLOUDSTACK-1960: Fix for UK Keyboard Bar symbol.

Posted by Devdeep Singh <de...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12245/#review22999
-----------------------------------------------------------


Review request already got a ship it. Committed the changes to master and 4.2 branch. Kindly close the request.

- Devdeep Singh


On July 3, 2013, 11:43 a.m., Sanjay Tripathi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12245/
> -----------------------------------------------------------
> 
> (Updated July 3, 2013, 11:43 a.m.)
> 
> 
> Review request for cloudstack, Animesh Chaturvedi, Fang Wang, and Ram Ganesh.
> 
> 
> Bugs: CLOUDSTACK-1960
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> CLOUDSTACK-1960: Fix for Bar symbol in UK keyboard.
> 
> With this fix, cloudStack will support bar symbol i.e. "|" for UK keyboard.
> 
> 
> Diffs
> -----
> 
>   services/console-proxy/server/js/ajaxkeys.js 677962b 
> 
> Diff: https://reviews.apache.org/r/12245/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sanjay Tripathi
> 
>


Re: Review Request 12245: CLOUDSTACK-1960: Fix for UK Keyboard Bar symbol.

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12245/#review22996
-----------------------------------------------------------


Commit b5cf3510eb01b8b81f3437eaebbb4a6ede0f55bc in branch refs/heads/4.2 from Sanjay Tripathi
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=b5cf351 ]

CLOUDSTACK-1960: Fix for UK Keyboard - Bar symbol i.e. "|".


- ASF Subversion and Git Services


On July 3, 2013, 11:43 a.m., Sanjay Tripathi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12245/
> -----------------------------------------------------------
> 
> (Updated July 3, 2013, 11:43 a.m.)
> 
> 
> Review request for cloudstack, Animesh Chaturvedi, Fang Wang, and Ram Ganesh.
> 
> 
> Bugs: CLOUDSTACK-1960
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> CLOUDSTACK-1960: Fix for Bar symbol in UK keyboard.
> 
> With this fix, cloudStack will support bar symbol i.e. "|" for UK keyboard.
> 
> 
> Diffs
> -----
> 
>   services/console-proxy/server/js/ajaxkeys.js 677962b 
> 
> Diff: https://reviews.apache.org/r/12245/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sanjay Tripathi
> 
>