You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/02/09 10:00:42 UTC

[GitHub] [cloudstack] shwstppr opened a new pull request #4670: ui: fix update vm details wrt backend changes

shwstppr opened a new pull request #4670:
URL: https://github.com/apache/cloudstack/pull/4670


   ### Description
   
   PR #4629 made changes in updateVirtualMachine behaviour wrt readonly details.
   This change updates UI wrt new behaviour.
   
   <!--- ********************************************************************************* -->
   <!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
   <!--- PLEASE PUT AN 'X' in only **ONE** box -->
   <!--- ********************************************************************************* -->
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [x] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ### Feature/Enhancement Scale or Bug Severity
   
   #### Feature/Enhancement Scale
   
   - [ ] Major
   - [ ] Minor
   
   #### Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [ ] Major
   - [x] Minor
   - [ ] Trivial
   
   
   ### Screenshots (if appropriate):
   
   
   ### How Has This Been Tested?
   <!-- Please describe in detail how you tested your changes. -->
   <!-- Include details of your testing environment, and the tests you ran to -->
   <!-- see how your change affects other areas of the code, etc. -->
   
   
   <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] davidjumani commented on pull request #4670: ui: fix update vm details wrt backend changes

Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #4670:
URL: https://github.com/apache/cloudstack/pull/4670#issuecomment-791882524


   @blueorangutan ui


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4670: ui: fix update vm details wrt backend changes

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4670:
URL: https://github.com/apache/cloudstack/pull/4670#issuecomment-777342123


   @Pearl1594 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4670: ui: fix update vm details wrt backend changes

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4670:
URL: https://github.com/apache/cloudstack/pull/4670#issuecomment-796538127


   Tests LGTM - from gif. Fixes existing UI minor feature from legacy UI.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd merged pull request #4670: ui: fix update vm details wrt backend changes

Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #4670:
URL: https://github.com/apache/cloudstack/pull/4670


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4670: ui: fix update vm details wrt backend changes

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4670:
URL: https://github.com/apache/cloudstack/pull/4670#issuecomment-791882572


   @davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4670: ui: fix update vm details wrt backend changes

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4670:
URL: https://github.com/apache/cloudstack/pull/4670#issuecomment-777380775


   UI build: :heavy_check_mark:
   Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4670 (JID-12)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] Pearl1594 commented on pull request #4670: ui: fix update vm details wrt backend changes

Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #4670:
URL: https://github.com/apache/cloudstack/pull/4670#issuecomment-777356957


   @blueorangutan ui


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] Pearl1594 commented on pull request #4670: ui: fix update vm details wrt backend changes

Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #4670:
URL: https://github.com/apache/cloudstack/pull/4670#issuecomment-777378226


   @blueorangutan ui


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4670: ui: fix update vm details wrt backend changes

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4670:
URL: https://github.com/apache/cloudstack/pull/4670#issuecomment-777346229


   UI build: :heavy_check_mark:
   Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4670 (JID-3835)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] shwstppr commented on pull request #4670: ui: fix update vm details wrt backend changes

Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4670:
URL: https://github.com/apache/cloudstack/pull/4670#issuecomment-787867393


   @weizhouapache added screenshot


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] Pearl1594 removed a comment on pull request #4670: ui: fix update vm details wrt backend changes

Posted by GitBox <gi...@apache.org>.
Pearl1594 removed a comment on pull request #4670:
URL: https://github.com/apache/cloudstack/pull/4670#issuecomment-777354142


   @blueorangutan ui


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4670: ui: fix update vm details wrt backend changes

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4670:
URL: https://github.com/apache/cloudstack/pull/4670#issuecomment-777357157


   @Pearl1594 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4670: ui: fix update vm details wrt backend changes

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4670:
URL: https://github.com/apache/cloudstack/pull/4670#issuecomment-775816470


   @shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4670: ui: fix update vm details wrt backend changes

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4670:
URL: https://github.com/apache/cloudstack/pull/4670#issuecomment-791883320


   UI build: :heavy_check_mark:
   Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4670 (JID-3850)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4670: ui: fix update vm details wrt backend changes

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4670:
URL: https://github.com/apache/cloudstack/pull/4670#issuecomment-777378401


   @Pearl1594 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] Pearl1594 commented on pull request #4670: ui: fix update vm details wrt backend changes

Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #4670:
URL: https://github.com/apache/cloudstack/pull/4670#issuecomment-777341315


   @blueorangutan ui


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4670: ui: fix update vm details wrt backend changes

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4670:
URL: https://github.com/apache/cloudstack/pull/4670#issuecomment-777354842


   @Pearl1594 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] Pearl1594 commented on pull request #4670: ui: fix update vm details wrt backend changes

Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #4670:
URL: https://github.com/apache/cloudstack/pull/4670#issuecomment-777354142


   @blueorangutan ui


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] weizhouapache commented on pull request #4670: ui: fix update vm details wrt backend changes

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #4670:
URL: https://github.com/apache/cloudstack/pull/4670#issuecomment-787762865


   @shwstppr can you upload some screenshots for this ui change ?
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] shwstppr commented on pull request #4670: ui: fix update vm details wrt backend changes

Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4670:
URL: https://github.com/apache/cloudstack/pull/4670#issuecomment-775815768


   @blueorangutan ui


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4670: ui: fix update vm details wrt backend changes

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4670:
URL: https://github.com/apache/cloudstack/pull/4670#issuecomment-775825096


   UI build: :heavy_check_mark:
   Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4670 (JID-3834)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org