You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "tanvipenumudy (via GitHub)" <gi...@apache.org> on 2024/03/01 08:28:58 UTC
[PR] HDDS-10445. OM admin CLI to enable force fetching network topology tree from SCM [ozone]
tanvipenumudy opened a new pull request, #6304:
URL: https://github.com/apache/ozone/pull/6304
## What changes were proposed in this pull request?
[To be merged once https://github.com/apache/ozone/pull/5391 is in]
OM has a background thread running that periodically refetches the updated network topology layout information from SCM for the refresh duration frequency of every one hour (default).
This change introduces an OM admin CLI for force fetching the network topology tree information from SCM on demand.
Format:
```
ozone admin om fetch-topology-tree -id=omServiceId
```
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-10445
## How was this patch tested?
- The patch has been tested manually.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-10445. OM admin CLI to enable force fetching network topology tree from SCM [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on code in PR #6304:
URL: https://github.com/apache/ozone/pull/6304#discussion_r1555690295
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/TestGetClusterTreeInformation.java:
##########
@@ -62,6 +87,11 @@ public static void init() throws IOException, TimeoutException,
.build();
cluster.waitForClusterToBeReady();
scm = cluster.getStorageContainerManager();
+ om = cluster.getOzoneManager();
+ nodeManager = (SCMNodeManager) scm.getScmNodeManager();
+ client = cluster.newClient();
Review Comment:
`client` needs to be closed in `shutdown()`.
##########
hadoop-ozone/interface-client/src/main/proto/OmClientProtocol.proto:
##########
@@ -147,6 +147,7 @@ enum Type {
ListStatusLight = 129;
GetSnapshotInfo = 130;
RenameSnapshot = 131;
+ RefetchNetworkTopologyTree = 132;
Review Comment:
Let's omit `Tree` to make it a bit shorter. (Also in request/response, method and command names.)
##########
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/admin/om/FetchNetworkTopologyTreeSubCommand.java:
##########
@@ -0,0 +1,65 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with this
+ * work for additional information regarding copyright ownership. The ASF
+ * licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ * <p>
+ * http://www.apache.org/licenses/LICENSE-2.0
+ * <p>
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations under
+ * the License.
+ */
+
+package org.apache.hadoop.ozone.admin.om;
+
+import java.io.IOException;
+import java.util.concurrent.Callable;
+import org.apache.hadoop.hdds.cli.HddsVersionProvider;
+import org.apache.hadoop.ozone.om.protocol.OzoneManagerProtocol;
+import picocli.CommandLine;
+
+/**
+ * Handler of ozone admin om fetch-topology-tree command.
+ */
+@CommandLine.Command(
+ name = "fetch-topology-tree",
+ description = "CLI command for OM to force fetch the latest network " +
+ "topology tree information from SCM.",
+ mixinStandardHelpOptions = true,
+ versionProvider = HddsVersionProvider.class
+)
+public class FetchNetworkTopologyTreeSubCommand implements Callable<Void> {
+ @CommandLine.ParentCommand
+ private OMAdmin parent;
+
+ @CommandLine.Option(
+ names = {"-id", "--service-id"},
Review Comment:
Please avoid adding `-id` as an option for new commands (see HDDS-6736).
```suggestion
names = {"--service-id"},
```
##########
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/admin/om/FetchNetworkTopologyTreeSubCommand.java:
##########
@@ -0,0 +1,65 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with this
+ * work for additional information regarding copyright ownership. The ASF
+ * licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ * <p>
+ * http://www.apache.org/licenses/LICENSE-2.0
+ * <p>
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations under
+ * the License.
+ */
+
+package org.apache.hadoop.ozone.admin.om;
+
+import java.io.IOException;
+import java.util.concurrent.Callable;
+import org.apache.hadoop.hdds.cli.HddsVersionProvider;
+import org.apache.hadoop.ozone.om.protocol.OzoneManagerProtocol;
+import picocli.CommandLine;
+
+/**
+ * Handler of ozone admin om fetch-topology-tree command.
+ */
+@CommandLine.Command(
+ name = "fetch-topology-tree",
+ description = "CLI command for OM to force fetch the latest network " +
+ "topology tree information from SCM.",
+ mixinStandardHelpOptions = true,
+ versionProvider = HddsVersionProvider.class
+)
+public class FetchNetworkTopologyTreeSubCommand implements Callable<Void> {
+ @CommandLine.ParentCommand
+ private OMAdmin parent;
+
+ @CommandLine.Option(
+ names = {"-id", "--service-id"},
+ description = "Ozone Manager Service ID",
+ required = false
+ )
+ private String omServiceId;
+
+ @Override
+ public Void call() throws Exception {
+ try (OzoneManagerProtocol client = parent.createOmClient(omServiceId)) {
+ boolean status = false;
+ try {
+ status = client.refetchNetworkTopologyTree();
+ } catch (IOException e) {
+ System.err.println("Force fetching network topology tree information " +
+ "has failed: " + e.getMessage());
+ }
+ if (status) {
+ System.out.println(
+ "Force fetching network topology tree information " +
+ "is complete.");
+ }
Review Comment:
I find this output a bit too verbose.
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java:
##########
@@ -1094,11 +1094,17 @@ private void stopSecretManager() {
}
}
+ @Override
public UUID refetchSecretKey() {
secretKeyClient.refetchSecretKey();
return secretKeyClient.getCurrentSecretKey().getId();
}
+ @Override
+ public boolean refetchNetworkTopologyTree() {
+ return scmTopologyClient.refetchClusterTree(configuration);
Review Comment:
I think admin privilege should be required to make the request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-10445. OM admin CLI to enable force fetching network topology tree from SCM [ozone]
Posted by "tanvipenumudy (via GitHub)" <gi...@apache.org>.
tanvipenumudy commented on PR #6304:
URL: https://github.com/apache/ozone/pull/6304#issuecomment-2037653378
@adoroszlai could you please review the changes as well? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-10445. OM admin CLI to enable force fetching network topology tree from SCM [ozone]
Posted by "tanvipenumudy (via GitHub)" <gi...@apache.org>.
tanvipenumudy commented on PR #6304:
URL: https://github.com/apache/ozone/pull/6304#issuecomment-2519592318
Sure, marking the PR as closed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-10445. OM admin CLI to enable force fetching network topology tree from SCM [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #6304:
URL: https://github.com/apache/ozone/pull/6304#issuecomment-2518174112
@tanvipenumudy can we close this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-10445. OM admin CLI to enable force fetching network topology tree from SCM [ozone]
Posted by "tanvipenumudy (via GitHub)" <gi...@apache.org>.
tanvipenumudy commented on PR #6304:
URL: https://github.com/apache/ozone/pull/6304#issuecomment-1976951635
@kerneltime, @duongkame could you please take a look? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-10445. OM admin CLI to enable force fetching network topology tree from SCM [ozone]
Posted by "ArafatKhan2198 (via GitHub)" <gi...@apache.org>.
ArafatKhan2198 commented on PR #6304:
URL: https://github.com/apache/ozone/pull/6304#issuecomment-1978665768
Thanks for working on this, @tanvipenumudy. I don't see any tests written for it yet. Would you mind adding an integration test to verify your results, please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-10445. OM admin CLI to enable force fetching network topology tree from SCM [ozone]
Posted by "tanvipenumudy (via GitHub)" <gi...@apache.org>.
tanvipenumudy closed pull request #6304: HDDS-10445. OM admin CLI to enable force fetching network topology tree from SCM
URL: https://github.com/apache/ozone/pull/6304
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org