You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@mesosphere.io> on 2018/03/02 05:39:49 UTC
Review Request 65875: Improved logging for offers and inverse offers.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65875/
-----------------------------------------------------------
Review request for mesos and Greg Mann.
Repository: mesos
Description
-------
Printed offer IDs and inverse offer IDs when sending out offers and
inverse offers so it is easier to match them to their ACCEPT or DECLINE
calls and removals.
Diffs
-----
src/master/master.cpp f2c2dbe6a4568027f11ad14121c2f9a1d1a43f80
Diff: https://reviews.apache.org/r/65875/diff/1/
Testing
-------
sudo make check
Thanks,
Chun-Hung Hsiao
Re: Review Request 65875: Improved logging for offers and inverse
offers.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65875/#review198512
-----------------------------------------------------------
Patch looks great!
Reviews applied: [65875]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On March 1, 2018, 9:39 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65875/
> -----------------------------------------------------------
>
> (Updated March 1, 2018, 9:39 p.m.)
>
>
> Review request for mesos and Greg Mann.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Printed offer IDs and inverse offer IDs when sending out offers and
> inverse offers so it is easier to match them to their ACCEPT or DECLINE
> calls and removals.
>
>
> Diffs
> -----
>
> src/master/master.cpp f2c2dbe6a4568027f11ad14121c2f9a1d1a43f80
>
>
> Diff: https://reviews.apache.org/r/65875/diff/1/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 65875: Improved logging for offers and inverse
offers.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65875/#review198509
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['65875']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65875
Relevant logs:
- [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65875/logs/mesos-tests-stdout.log):
```
[ OK ] Endpoint/SlaveEndpointTest.NoAuthorizer/2 (128 ms)
[----------] 9 tests from Endpoint/SlaveEndpointTest (1202 ms total)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (40 ms)
[ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (45 ms)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (87 ms total)
[----------] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[ OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (2526 ms)
[----------] 1 test from IsolationFlag/CpuIsolatorTest (2552 ms total)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[ OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (2476 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (2500 ms total)
[----------] Global test environment tear-down
[==========] 915 tests from 90 test cases ran. (478865 ms total)
[ PASSED ] 914 tests.
[ FAILED ] 1 test, listed below:
[ FAILED ] CommandExecutorCheckTest.CommandCheckTimeout
1 FAILED TEST
YOU HAVE 211 DISABLED TESTS
```
- [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65875/logs/mesos-tests-stderr.log):
```
I0302 06:41:13.108888 876 master.cpp:10267] Updating the state of task 54924781-ce1a-4905-bfcf-d16dbb73e9b9 of framework fa008a6a-5d12-42e4-8909-167ec4823ffd-0000 (latest state: TASK_KILLED, status update state: TASK_KILLED)
I0302 06:41:13.108888 9388 slave.cpp:3879] Shutting down framework fa008a6a-5d12-42e4-8909-167ec4823ffd-0000
I0302 06:41:13.108888 9388 slave.cpp:6586] Shutting down executor '54924781-ce1a-4905-bfcf-d16dbb73e9b9' of framework fa008a6a-5d12-42e4-8909-167ec4823ffd-000I0302 06:41:12.380908 3844 exec.cpp:162] Version: 1.6.0
I0302 06:41:12.408885 10992 exec.cpp:236] Executor registered on agent fa008a6a-5d12-42e4-8909-167ec4823ffd-S0
I0302 06:41:12.412886 6928 executor.cpp:176] Received SUBSCRIBED event
I0302 06:41:12.418277 6928 executor.cpp:180] Subscribed executor on build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net
I0302 06:41:12.418884 6928 executor.cpp:176] Received LAUNCH event
I0302 06:41:12.422883 6928 executor.cpp:648] Starting task 54924781-ce1a-4905-bfcf-d16dbb73e9b9
I0302 06:41:12.520910 6928 executor.cpp:483] Running 'D:\DCOS\mesos\src\mesos-containerizer.exe launch <POSSIBLY-SENSITIVE-DATA>'
I0302 06:41:13.073887 6928 executor.cpp:661] Forked command at 11132
I0302 06:41:13.111887 6120 exec.cpp:445] Executor asked to shutdown
I0302 06:41:13.112887 6928 executor.cpp:176] Received SHUTDOWN event
I0302 06:41:13.113890 6928 executor.cpp:758] Shutting down
I0302 06:41:13.113890 6928 executor.cpp:868] Sending SIGTERM to process tree at pid 0 at executor(1)@10.3.1.5:59118
I0302 06:41:13.110888 9388 slave.cpp:922] Agent terminating
W0302 06:41:13.111887 9388 slave.cpp:3875] Ignoring shutdown framework fa008a6a-5d12-42e4-8909-167ec4823ffd-0000 because it is terminating
I0302 06:41:13.111887 876 master.cpp:10366] Removing task 54924781-ce1a-4905-bfcf-d16dbb73e9b9 with resources cpus(allocated: *):4; mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: *):[31000-32000] of framework fa008a6a-5d12-42e4-8909-167ec4823ffd-0000 on agent fa008a6a-5d12-42e4-8909-167ec4823ffd-S0 at slave(398)@10.3.1.5:59096 (build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0302 06:41:13.113890 876 master.cpp:1306] Agent fa008a6a-5d12-42e4-8909-167ec4823ffd-S0 at slave(398)@10.3.1.5:59096 (build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) disconnected
I0302 06:41:13.113890 876 master.cpp:3276] Disconnecting agent fa008a6a-5d12-42e4-8909-167ec4823ffd-S0 at slave(398)@10.3.1.5:59096 (build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0302 06:41:13.114889 1604 containerizer.cpp:2338] Destroying container a397f167-76f1-494f-942b-c9646b7fc3b1 in RUNNING state
I0302 06:41:13.114889 1604 containerizer.cpp:2952] Transitioning the state of container a397f167-76f1-494f-942b-c9646b7fc3b1 from RUNNING to DESTROYING
I0302 06:41:13.114889 876 master.cpp:3295] Deactivating agent fa008a6a-5d12-42e4-8909-167ec4823ffd-S0 at slave(398)@10.3.1.5:59096 (build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0302 06:41:13.115891 148 hierarchical.cpp:344] Removed framework fa008a6a-5d12-42e4-8909-167ec4823ffd-0000
I0302 06:41:13.115891 1604 launcher.cpp:156] Asked to destroy container a397f167-76f1-494f-942b-c9646b7fc3b1
I0302 06:41:13.115891 148 hierarchical.cpp:766] Agent fa008a6a-5d12-42e4-8909-167ec4823ffd-S0 deactivated
I0302 06:41:13.142894 9388 containerizer.cpp:2791] Container a397f167-76f1-494f-942b-c9646b7fc3b1 has exited
I0302 06:41:13.174888 7956 master.cpp:1149] Master terminating
I0302 06:41:13.177914 1604 hierarchical.cpp:609] Removed agent fa008a6a-5d12-42e4-8909-167ec4823ffd-S0
I0302 06:41:13.722916 5484 process.cpp:929] Stopped the socket accept loop
```
- Mesos Reviewbot Windows
On March 2, 2018, 5:39 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65875/
> -----------------------------------------------------------
>
> (Updated March 2, 2018, 5:39 a.m.)
>
>
> Review request for mesos and Greg Mann.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Printed offer IDs and inverse offer IDs when sending out offers and
> inverse offers so it is easier to match them to their ACCEPT or DECLINE
> calls and removals.
>
>
> Diffs
> -----
>
> src/master/master.cpp f2c2dbe6a4568027f11ad14121c2f9a1d1a43f80
>
>
> Diff: https://reviews.apache.org/r/65875/diff/1/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 65875: Improved logging for offers and inverse
offers.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65875/#review200176
-----------------------------------------------------------
Patch looks great!
Reviews applied: [65875]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On March 20, 2018, 3:27 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65875/
> -----------------------------------------------------------
>
> (Updated March 20, 2018, 3:27 a.m.)
>
>
> Review request for mesos, Gaston Kleiman and Greg Mann.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Printed offer IDs and inverse offer IDs when sending out offers and
> inverse offers so it is easier to match them to their ACCEPT or DECLINE
> calls and removals.
>
>
> Diffs
> -----
>
> src/master/master.cpp aa35abc53bfc34e19d19a93328fb6552b64c05d7
>
>
> Diff: https://reviews.apache.org/r/65875/diff/2/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 65875: Improved logging for offers and inverse
offers.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65875/#review204750
-----------------------------------------------------------
PASS: Mesos patch 65875 was successfully built and tested.
Reviews applied: `['65995', '65975', '65976', '65640', '65875']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65875
- Mesos Reviewbot Windows
On June 14, 2018, 12:22 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65875/
> -----------------------------------------------------------
>
> (Updated June 14, 2018, 12:22 a.m.)
>
>
> Review request for mesos, Gastón Kleiman and Greg Mann.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Printed offer IDs and inverse offer IDs when sending out offers and
> inverse offers so it is easier to match them to their ACCEPT or DECLINE
> calls and removals.
>
>
> Diffs
> -----
>
> src/master/master.cpp 5db5a8da85f02323a5654c93ac47ec4aa7e711d2
>
>
> Diff: https://reviews.apache.org/r/65875/diff/3/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 65875: Improved logging for offers and inverse
offers.
Posted by Chun-Hung Hsiao <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65875/
-----------------------------------------------------------
(Updated June 20, 2018, 5:32 a.m.)
Review request for mesos, Benjamin Bannier, Gastón Kleiman, and Greg Mann.
Repository: mesos
Description
-------
Printed offer IDs and inverse offer IDs when sending out offers and
inverse offers so it is easier to match them to their ACCEPT or DECLINE
calls and removals.
Diffs
-----
src/master/master.cpp 5db5a8da85f02323a5654c93ac47ec4aa7e711d2
Diff: https://reviews.apache.org/r/65875/diff/3/
Testing
-------
sudo make check
Thanks,
Chun-Hung Hsiao
Re: Review Request 65875: Improved logging for offers and inverse
offers.
Posted by Chun-Hung Hsiao <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65875/
-----------------------------------------------------------
(Updated June 14, 2018, 12:22 a.m.)
Review request for mesos, Gastón Kleiman and Greg Mann.
Changes
-------
Rebased.
Repository: mesos
Description
-------
Printed offer IDs and inverse offer IDs when sending out offers and
inverse offers so it is easier to match them to their ACCEPT or DECLINE
calls and removals.
Diffs (updated)
-----
src/master/master.cpp 5db5a8da85f02323a5654c93ac47ec4aa7e711d2
Diff: https://reviews.apache.org/r/65875/diff/3/
Changes: https://reviews.apache.org/r/65875/diff/2-3/
Testing
-------
sudo make check
Thanks,
Chun-Hung Hsiao
Re: Review Request 65875: Improved logging for offers and inverse
offers.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65875/#review199513
-----------------------------------------------------------
FAIL: Failed to apply the dependent review: 66094.
Failed command: `python.exe .\support\apply-reviews.py -n -r 66094`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65875
Relevant logs:
- [apply-review-66094-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65875/logs/apply-review-66094-stdout.log):
```
error: missing binary patch data for '3rdparty/grpc-1.10.0.tar.gz'
error: binary patch does not apply to '3rdparty/grpc-1.10.0.tar.gz'
error: 3rdparty/grpc-1.10.0.tar.gz: patch does not apply
```
- Mesos Reviewbot Windows
On March 20, 2018, 3:27 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65875/
> -----------------------------------------------------------
>
> (Updated March 20, 2018, 3:27 a.m.)
>
>
> Review request for mesos, Gaston Kleiman and Greg Mann.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Printed offer IDs and inverse offer IDs when sending out offers and
> inverse offers so it is easier to match them to their ACCEPT or DECLINE
> calls and removals.
>
>
> Diffs
> -----
>
> src/master/master.cpp aa35abc53bfc34e19d19a93328fb6552b64c05d7
>
>
> Diff: https://reviews.apache.org/r/65875/diff/2/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 65875: Improved logging for offers and inverse
offers.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65875/#review199532
-----------------------------------------------------------
Bad patch!
Reviews applied: [65875, 65666, 65665, 65640, 65976, 65975, 65594, 65974, 65995, 66162, 66161, 66160, 66159, 66158, 66157, 66156, 66097, 66096, 66095, 66094]
Failed command: python support/apply-reviews.py -n -r 66094
Error:
2018-03-20 09:53:42 URL:https://reviews.apache.org/r/66094/diff/raw/ [9043/9043] -> "66094.patch" [1]
error: missing binary patch data for '3rdparty/grpc-1.10.0.tar.gz'
error: binary patch does not apply to '3rdparty/grpc-1.10.0.tar.gz'
error: 3rdparty/grpc-1.10.0.tar.gz: patch does not apply
Full log: https://builds.apache.org/job/Mesos-Reviewbot/21951/console
- Mesos Reviewbot
On March 20, 2018, 3:27 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65875/
> -----------------------------------------------------------
>
> (Updated March 20, 2018, 3:27 a.m.)
>
>
> Review request for mesos, Gaston Kleiman and Greg Mann.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Printed offer IDs and inverse offer IDs when sending out offers and
> inverse offers so it is easier to match them to their ACCEPT or DECLINE
> calls and removals.
>
>
> Diffs
> -----
>
> src/master/master.cpp aa35abc53bfc34e19d19a93328fb6552b64c05d7
>
>
> Diff: https://reviews.apache.org/r/65875/diff/2/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 65875: Improved logging for offers and inverse
offers.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65875/#review200186
-----------------------------------------------------------
PASS: Mesos patch 65875 was successfully built and tested.
Reviews applied: `['65875']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65875
- Mesos Reviewbot Windows
On March 20, 2018, 4:27 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65875/
> -----------------------------------------------------------
>
> (Updated March 20, 2018, 4:27 a.m.)
>
>
> Review request for mesos, Gaston Kleiman and Greg Mann.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Printed offer IDs and inverse offer IDs when sending out offers and
> inverse offers so it is easier to match them to their ACCEPT or DECLINE
> calls and removals.
>
>
> Diffs
> -----
>
> src/master/master.cpp aa35abc53bfc34e19d19a93328fb6552b64c05d7
>
>
> Diff: https://reviews.apache.org/r/65875/diff/2/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 65875: Improved logging for offers and inverse
offers.
Posted by Chun-Hung Hsiao <ch...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65875/
-----------------------------------------------------------
(Updated March 20, 2018, 3:27 a.m.)
Review request for mesos, Gaston Kleiman and Greg Mann.
Changes
-------
Rebased.
Repository: mesos
Description
-------
Printed offer IDs and inverse offer IDs when sending out offers and
inverse offers so it is easier to match them to their ACCEPT or DECLINE
calls and removals.
Diffs (updated)
-----
src/master/master.cpp aa35abc53bfc34e19d19a93328fb6552b64c05d7
Diff: https://reviews.apache.org/r/65875/diff/2/
Changes: https://reviews.apache.org/r/65875/diff/1-2/
Testing
-------
sudo make check
Thanks,
Chun-Hung Hsiao