You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@activemq.apache.org by cburlinchon <gi...@git.apache.org> on 2017/10/24 16:18:35 UTC

[GitHub] activemq-artemis pull request #1608: Set validated user in all messages

GitHub user cburlinchon opened a pull request:

    https://github.com/apache/activemq-artemis/pull/1608

    Set validated user in all messages

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cburlinchon/activemq-artemis master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/1608.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1608
    
----
commit 0679ac83cbe38513cc4615d948ba2c97fab85589
Author: Chris Burlinchon <ch...@r3.com>
Date:   2017-10-24T16:11:19Z

    artemis-server: Move setValidatedUserID to a common codepath

----


---

[GitHub] activemq-artemis issue #1608: ARTEMIS-1479 Set validated user in all message...

Posted by jbertram <gi...@git.apache.org>.

Github user jbertram commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1608
  
    @cburlinchon, per my email to the dev list earlier this week, I plan on doing a release soon so if you want this in there please update the PR ASAP.


---

[GitHub] activemq-artemis pull request #1608: ARTEMIS-1479 Set validated user in all ...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/1608


---

[GitHub] activemq-artemis issue #1608: ARTEMIS-1479 Set validated user in all message...

Posted by cburlinchon <gi...@git.apache.org>.

Github user cburlinchon commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1608
  
    To reproduce: run LargeMessageExample.java with populate-validated-user set to true(I've toggled this in artemis-configuration.xsd). It hangs on Receiving message for me


---

[GitHub] activemq-artemis issue #1608: ARTEMIS-1479 Set validated user in all message...

Posted by clebertsuconic <gi...@git.apache.org>.

Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1608
  
    there is an issue on checkstyle.. also you are using a static block on the test...
    
    I have fixed this with checking out a branch.. amending, and I'm merging the fixes as yours just for the sake of being easier than going back and forth comments... take a look though after I merged it.. thanks


---

[GitHub] activemq-artemis issue #1608: ARTEMIS-1479 Set validated user in all message...

Posted by clebertsuconic <gi...@git.apache.org>.

Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1608
  
    @cburlinchon nice one.. thanks a lot.. merging it


---

[GitHub] activemq-artemis issue #1608: ARTEMIS-1479 Set validated user in all message...

Posted by cburlinchon <gi...@git.apache.org>.

Github user cburlinchon commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1608
  
    Hi,
    When sending large message I've hit this:
    java.lang.IllegalArgumentException: Missing validated user from the Artemis message
    
    Seems we don't setValidatedUserID when going through the slowPacketHandler in ServerSessionPacketHandler. I've raised a jira, let me know if you think it is a bug. I'll create some tests in meantime


---

[GitHub] activemq-artemis issue #1608: Set validated user in all messages

Posted by tabish121 <gi...@git.apache.org>.

Github user tabish121 commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1608
  
    There doesn't seem to be a JIRA issue associated with this, nor are there tests, or even text explaining why the change is needed.  Would be good to add those.


---

[GitHub] activemq-artemis issue #1608: ARTEMIS-1479 Set validated user in all message...

Posted by clebertsuconic <gi...@git.apache.org>.

Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1608
  
    /me testing.. leave it with me


---