[GitHub] [spark] cloud-fan commented on a change in pull request #34403: [SPARK-37133][SQL] Add a config to optionally enforce ANSI reserved keywords

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #34403:
URL: https://github.com/apache/spark/pull/34403#discussion_r737654288



##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/ExpressionParserSuite.scala
##########
@@ -933,10 +933,18 @@ class ExpressionParserSuite extends AnalysisTest {
       assertEqual("current_timestamp", CurrentTimestamp())
     }
 
-    withSQLConf(SQLConf.ANSI_ENABLED.key -> "false") {
+    def testNonAnsiBehavior(): Unit = {
       assertEqual("current_date", UnresolvedAttribute.quoted("current_date"))
       assertEqual("current_timestamp", UnresolvedAttribute.quoted("current_timestamp"))
     }
+    withSQLConf(SQLConf.ANSI_ENABLED.key -> "false") {

Review comment:
       As documented, `ENFORCE_RESERVED_KEYWORDS` is only effective when ansi mode is on.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org