You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by StefanRRichter <gi...@git.apache.org> on 2018/05/23 08:48:49 UTC

[GitHub] flink issue #5959: [FLINK-9258][metrics] Thread-safe initialization of varia...

Github user StefanRRichter commented on the issue:

    https://github.com/apache/flink/pull/5959
  
    I have two quick questions:
    - Why does `ComponentMetricGroup` even override the method `getAllVariables` from `AbstractMetricGroup` with essentially the exact same code?
    -Why is it only fixed in `ComponentMetricGroup`? Could it make sense to fix it in `AbstractMetricGroup` and remove the overriding method in the subclass?


---