[GitHub] kgyrtkirk commented on a change in pull request #812: [CALCITE-2507] Aliasing a star in select list should throw a parsing e…

[GitBox <gi...@apache.org>]

kgyrtkirk commented on a change in pull request #812: [CALCITE-2507] Aliasing a star in select list should throw a parsing e…
URL: https://github.com/apache/calcite/pull/812#discussion_r261569740
 
 

 ##########
 File path: core/src/main/codegen/templates/Parser.jj
 ##########
 @@ -1559,6 +1559,11 @@ SqlNode SelectItem() :
     SqlIdentifier id;
 }
 {
+    LOOKAHEAD(7)
+    e = StarIdentifier() {
+        return e;
+    }
+    |
     e = SelectExpression()
     [
         [ <AS> ]
 
 Review comment:
   instead of introducing a new identifier/etc you should be able to make the check here - and raise an exception if whether `e` is a star identifier

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services