[GitHub] [arrow-datafusion] jackwener commented on a diff in pull request #4276: Reimplement `limit_push_down`

[GitBox <gi...@apache.org>]

jackwener commented on code in PR #4276:
URL: https://github.com/apache/arrow-datafusion/pull/4276#discussion_r1026214050


##########
datafusion/optimizer/src/limit_push_down.rs:
##########
@@ -576,8 +424,8 @@ mod test {
 
         // Should push the limit down to table provider
         // When it has a select
-        let expected = "Limit: skip=10, fetch=1000\
-        \n  Projection: test.a\
+        let expected = "Projection: test.a\
+        \n  Limit: skip=10, fetch=1000\
         \n    TableScan: test, fetch=1010";

Review Comment:
   As for `limit-tablescan`.
   I'm not sure whether `tablescan` can precise `limit`, so I keep the `limit`.
   
   If `tablescan` limit is completely accurate, we can remove this limit for `limit-tablescan`
   
    



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org