[GitHub] [spark] sandeep-katta commented on a change in pull request #25427: [SPARK-28705][Test]drop table after being used

[GitBox <gi...@apache.org>]

sandeep-katta commented on a change in pull request #25427: [SPARK-28705][Test]drop table after being used
URL: https://github.com/apache/spark/pull/25427#discussion_r313691983
 
 

 ##########
 File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisExternalCatalogSuite.scala
 ##########
 @@ -57,6 +57,7 @@ class AnalysisExternalCatalogSuite extends AnalysisTest with Matchers {
     val plan = Project(Seq(func), testRelation)
     analyzer.execute(plan)
     verifyZeroInteractions(catalog)
+    catalog.dropTable("default", "t1", true, false)
 
 Review comment:
   I will add in afterEach, table created in "query builtin functions don't call the external catalog" is affecting the testcase "check the existence of builtin functions don't call the external catalog".  As per SPARK-25464, database can only be created to empty location. So it is requried to delete the table created in every testcase

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org