You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oodt.apache.org by Chris Mattmann <ma...@apache.org> on 2011/11/19 21:49:52 UTC
Re: Review Request: getXmlRpcProduct and getProductFromXmlRpc should allow
null values for product member variables since Product is just a carrier
object
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2884/#review3373
-----------------------------------------------------------
Ship it!
Yes, dude, yes. This is perfect. Basically you are making the SerDe more resilient, no? +1 from me. Ship it. Unit tests too? WOW!
- Chris
On 2011-11-19 20:43:45, brian Foster wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2884/
> -----------------------------------------------------------
>
> (Updated 2011-11-19 20:43:45)
>
>
> Review request for oodt, Chris Mattmann and Paul Ramirez.
>
>
> Summary
> -------
>
> issue is tracked here: https://issues.apache.org/jira/browse/OODT-353
>
>
> Diffs
> -----
>
> trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/util/XmlRpcStructFactory.java 1203939
>
> Diff: https://reviews.apache.org/r/2884/diff
>
>
> Testing
> -------
>
> testing to come...
>
>
> Thanks,
>
> brian
>
>