You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shenyu.apache.org by "li-keguo (via GitHub)" <gi...@apache.org> on 2023/07/03 15:36:02 UTC
[GitHub] [shenyu] li-keguo opened a new pull request, #4790: [type Refactor]extractor Multi-client registration is supported
li-keguo opened a new pull request, #4790:
URL: https://github.com/apache/shenyu/pull/4790
about issue #4560
Make sure that:
- [ ] add MultiClientApiBeansExtractorImpl
- [ ] abstract RpcApiBeansExtractor
- [ ] refactor ClientApiRefreshedEventListener
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shenyu] codecov-commenter commented on pull request #4790: [type Refactor]extractor Multi-client registration is supported
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #4790:
URL: https://github.com/apache/shenyu/pull/4790#issuecomment-1618867292
## [Codecov](https://app.codecov.io/gh/apache/shenyu/pull/4790?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#4790](https://app.codecov.io/gh/apache/shenyu/pull/4790?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (9994c26) into [master](https://app.codecov.io/gh/apache/shenyu/commit/2464ab138cfeb989dec55316035204adf7b8728c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (2464ab1) will **decrease** coverage by `0.06%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## master #4790 +/- ##
============================================
- Coverage 65.50% 65.44% -0.06%
- Complexity 8145 8150 +5
============================================
Files 1135 1137 +2
Lines 33236 33257 +21
Branches 2967 2965 -2
============================================
- Hits 21770 21764 -6
- Misses 9735 9760 +25
- Partials 1731 1733 +2
```
| [Impacted Files](https://app.codecov.io/gh/apache/shenyu/pull/4790?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...rg/apache/shenyu/client/core/register/ApiBean.java](https://app.codecov.io/gh/apache/shenyu/pull/4790?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2hlbnl1LWNsaWVudC9zaGVueXUtY2xpZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9jbGllbnQvY29yZS9yZWdpc3Rlci9BcGlCZWFuLmphdmE=) | `48.83% <0.00%> (-5.01%)` | :arrow_down: |
| [...core/register/ClientApiRefreshedEventListener.java](https://app.codecov.io/gh/apache/shenyu/pull/4790?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2hlbnl1LWNsaWVudC9zaGVueXUtY2xpZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9jbGllbnQvY29yZS9yZWdpc3Rlci9DbGllbnRBcGlSZWZyZXNoZWRFdmVudExpc3RlbmVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...ter/extractor/BaseAnnotationApiBeansExtractor.java](https://app.codecov.io/gh/apache/shenyu/pull/4790?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2hlbnl1LWNsaWVudC9zaGVueXUtY2xpZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9jbGllbnQvY29yZS9yZWdpc3Rlci9leHRyYWN0b3IvQmFzZUFubm90YXRpb25BcGlCZWFuc0V4dHJhY3Rvci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...core/register/extractor/BaseApiBeansExtractor.java](https://app.codecov.io/gh/apache/shenyu/pull/4790?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2hlbnl1LWNsaWVudC9zaGVueXUtY2xpZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9jbGllbnQvY29yZS9yZWdpc3Rlci9leHRyYWN0b3IvQmFzZUFwaUJlYW5zRXh0cmFjdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...er/extractor/MultiClientApiBeansExtractorImpl.java](https://app.codecov.io/gh/apache/shenyu/pull/4790?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2hlbnl1LWNsaWVudC9zaGVueXUtY2xpZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9jbGllbnQvY29yZS9yZWdpc3Rlci9leHRyYWN0b3IvTXVsdGlDbGllbnRBcGlCZWFuc0V4dHJhY3RvckltcGwuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...u/client/core/register/registrar/ApiRegistrar.java](https://app.codecov.io/gh/apache/shenyu/pull/4790?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2hlbnl1LWNsaWVudC9zaGVueXUtY2xpZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9jbGllbnQvY29yZS9yZWdpc3Rlci9yZWdpc3RyYXIvQXBpUmVnaXN0cmFyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...ngcloud/register/SpringCloudApiBeansExtractor.java](https://app.codecov.io/gh/apache/shenyu/pull/4790?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2hlbnl1LWNsaWVudC9zaGVueXUtY2xpZW50LWh0dHAvc2hlbnl1LWNsaWVudC1zcHJpbmdjbG91ZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L2NsaWVudC9zcHJpbmdjbG91ZC9yZWdpc3Rlci9TcHJpbmdDbG91ZEFwaUJlYW5zRXh0cmFjdG9yLmphdmE=) | `73.07% <ø> (ø)` | |
| [...springmvc/register/SpringMvcApiBeansExtractor.java](https://app.codecov.io/gh/apache/shenyu/pull/4790?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2hlbnl1LWNsaWVudC9zaGVueXUtY2xpZW50LWh0dHAvc2hlbnl1LWNsaWVudC1zcHJpbmdtdmMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9jbGllbnQvc3ByaW5nbXZjL3JlZ2lzdGVyL1NwcmluZ012Y0FwaUJlYW5zRXh0cmFjdG9yLmphdmE=) | `87.50% <ø> (ø)` | |
... and [8 files with indirect coverage changes](https://app.codecov.io/gh/apache/shenyu/pull/4790/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shenyu] tian-pengfei merged pull request #4790: [type Refactor]extractor Multi-client registration is supported
Posted by "tian-pengfei (via GitHub)" <gi...@apache.org>.
tian-pengfei merged PR #4790:
URL: https://github.com/apache/shenyu/pull/4790
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org