You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/03/19 10:36:44 UTC

[GitHub] [camel-quarkus] jamesnetherton opened a new pull request #919: Add Google Sheets extension

jamesnetherton opened a new pull request #919: Add Google Sheets extension
URL: https://github.com/apache/camel-quarkus/pull/919
 
 
   Fixes #809

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-quarkus] jamesnetherton commented on a change in pull request #919: Add Google Sheets extension

Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on a change in pull request #919: Add Google Sheets extension
URL: https://github.com/apache/camel-quarkus/pull/919#discussion_r394940442
 
 

 ##########
 File path: integration-tests/google/src/test/java/org/apache/camel/quarkus/component/google/it/GoogleComponentsTest.java
 ##########
 @@ -103,7 +103,7 @@ public void testGoogleCalendarComponent() throws InterruptedException {
                 .statusCode(204);
 
         // Wait for calendar deletion to occur
-        Thread.sleep(500);
+        Thread.sleep(1000);
 
 
 Review comment:
   Yes, I can do a follow up fix for that.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #919: Add Google Sheets extension

Posted by GitBox <gi...@apache.org>.
ppalaga commented on a change in pull request #919: Add Google Sheets extension
URL: https://github.com/apache/camel-quarkus/pull/919#discussion_r394936711
 
 

 ##########
 File path: integration-tests/google/src/test/java/org/apache/camel/quarkus/component/google/it/GoogleComponentsTest.java
 ##########
 @@ -103,7 +103,7 @@ public void testGoogleCalendarComponent() throws InterruptedException {
                 .statusCode(204);
 
         // Wait for calendar deletion to occur
-        Thread.sleep(500);
+        Thread.sleep(1000);
 
 
 Review comment:
   Wouldn't some sort of await be better? Something like we do in telegram? https://github.com/apache/camel-quarkus/blob/master/integration-tests/telegram/src/test/java/org/apache/camel/quarkus/component/telegram/it/TelegramTest.java#L150-L161

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-quarkus] jamesnetherton merged pull request #919: Add Google Sheets extension

Posted by GitBox <gi...@apache.org>.
jamesnetherton merged pull request #919: Add Google Sheets extension
URL: https://github.com/apache/camel-quarkus/pull/919
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services