RE: svn commit: r1717218 - in /serf/trunk: buckets/response_buckets.cincoming.c serf_bucket_types.h test/test_server.c

[Bert Huijben <be...@qqmail.nl>]

They currently don’t share code (except for what us already in the headers bucket). If it would share code in the future it would be most likely with the request class. (Both produce ‘a line’+headers+some potentially chunked body)

Bert
Sent from Outlook Mail for Windows 10 phone



From: Greg Stein
Sent: maandag 30 november 2015 10:59
To: Bert Huijben
Cc: dev@serf.apache.org
Subject: Re: svn commit: r1717218 - in /serf/trunk: buckets/response_buckets.cincoming.c serf_bucket_types.h test/test_server.c


On Mon, Nov 30, 2015 at 3:38 AM, <rh...@apache.org> wrote:
>...

> * buckets/response_buckets.c
>   (outgoing_response_t): New define.
>   (serf_bucket_outgoing_response_create,
>    serf_bucket_outgoing_response_get_headers,
>    serf_bucket_outgoing_response_prepare): New public functions.
>   (serialize_outgoing_response,
>    serf_outgoing_resp_read,
>    serf_outgoing_resp_read_iovec,
>    serf_outgoing_resp_readline,
>    serf_outgoing_resp_peek,
>    serf_outgoing_resp_set_config,
>    serf_outgoing_resp_destroy): New function.
>   (serf_bucket_type_outgoing_response): New bucket type.
>

Do the two bucket types share *any* code? It is hard to tell ... if not,
then two files is preferable.

>...

Cheers,
-g