You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "kentkwu (via GitHub)" <gi...@apache.org> on 2026/09/10 17:42:27 UTC
[PR] chore: remove @openpgp/web-stream-tools dependency [arrow-js]
kentkwu opened a new pull request, #476:
URL: https://github.com/apache/arrow-js/pull/476
## Summary
Removes `@openpgp/web-stream-tools` dependency and replaces it with a local `concatStream()` implementation.
- The package changed from CommonJS-compatible (v0.0.13) to pure ESM-only (v0.3.1), breaking Jest's module resolution
- Even with Jest 30, dynamic imports of pure ESM packages fail with "Cannot find module"
- Only 3 tests use this package for concatenating ReadableStreams, a simple ~15-line function
- Local implementation eliminates the external dependency and ESM compatibility issues
Verified all 696 tests in `test/unit/ipc/reader/streams-dom-tests.ts` pass with the local implementation.
## Test Plan
- [x] `npm run build`
- [x] `TEST_DOM_STREAMS=true npx jest test/unit/ipc/reader/streams-dom-tests.ts` (all 696 tests pass)
## Related
Closes dependabot PR #434 which attempted to upgrade this package but failed CI due to the ESM incompatibility.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore: remove @openpgp/web-stream-tools dependency [arrow-js]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #476:
URL: https://github.com/apache/arrow-js/pull/476
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org