You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/02/25 06:06:44 UTC
[GitHub] [arrow] rok opened a new pull request #12515: ARROW-15680: [C++] Temporal floor/ceil/round should accept week_start when rounding to multiple of week
rok opened a new pull request #12515:
URL: https://github.com/apache/arrow/pull/12515
This is to resolve [ARROW-15680](https://issues.apache.org/jira/browse/ARROW-15680).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12515: ARROW-15680: [C++] Temporal floor/ceil/round should accept week_starts_monday when rounding to multiple of week
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12515:
URL: https://github.com/apache/arrow/pull/12515#issuecomment-1054849094
Benchmark runs are scheduled for baseline = b16329e3d5941277019b59c26ac441b9bf58ff93 and contender = 69073982bd44c79648405c70d0245d2a30e29bc2. 69073982bd44c79648405c70d0245d2a30e29bc2 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/16b3d2d65eea4b40a89c75154c60643e...48c5565f515d48a594d8edd5e8f0d484/)
[Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/2a900aaa6d7048ebbc07f68aa3c7f396...4af33d99a78440138e8bcad8b39bd864/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/b7c6f7bba03845db8430bcd9832dbfe5...5442f9ee44044028811fd758ecc8c1a9/)
[Finished :arrow_down:0.13% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/58f889d15fba4aedbd9f04fafa478e96...1b0dd1adcac1423da77fe69e74ad3801/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rok commented on a change in pull request #12515: ARROW-15680: [C++] Temporal floor/ceil/round should accept week_starts_monday when rounding to multiple of week
Posted by GitBox <gi...@apache.org>.
rok commented on a change in pull request #12515:
URL: https://github.com/apache/arrow/pull/12515#discussion_r815948073
##########
File path: cpp/src/arrow/compute/kernels/scalar_temporal_unary.cc
##########
@@ -725,6 +725,27 @@ const Duration FloorTimePoint(const int64_t arg, const int64_t multiple,
}
}
+template <typename Duration, typename Unit, typename Localizer>
Review comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm closed pull request #12515: ARROW-15680: [C++] Temporal floor/ceil/round should accept week_starts_monday when rounding to multiple of week
Posted by GitBox <gi...@apache.org>.
lidavidm closed pull request #12515:
URL: https://github.com/apache/arrow/pull/12515
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12515: ARROW-15680: [C++] Temporal floor/ceil/round should accept week_starts_monday when rounding to multiple of week
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12515:
URL: https://github.com/apache/arrow/pull/12515#issuecomment-1054519281
Benchmark runs are scheduled for baseline = b16329e3d5941277019b59c26ac441b9bf58ff93 and contender = 69073982bd44c79648405c70d0245d2a30e29bc2. 69073982bd44c79648405c70d0245d2a30e29bc2 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/16b3d2d65eea4b40a89c75154c60643e...c968734e82904fcead8d103a884cfe1a/)
[Finished :arrow_down:0.92% :arrow_up:0.17%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/2a900aaa6d7048ebbc07f68aa3c7f396...3b2af2beb04340c987a1d6d300ab7929/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/b7c6f7bba03845db8430bcd9832dbfe5...945a06fa69f1496cb0b854081d6295e1/)
[Finished :arrow_down:0.13% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/58f889d15fba4aedbd9f04fafa478e96...c9bdb4aedd7c4f2e94b0189eb275fdc5/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12515: ARROW-15680: [C++] Temporal floor/ceil/round should accept week_start when rounding to multiple of week
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12515:
URL: https://github.com/apache/arrow/pull/12515#issuecomment-1050554952
https://issues.apache.org/jira/browse/ARROW-15680
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12515: ARROW-15680: [C++] Temporal floor/ceil/round should accept week_starts_monday when rounding to multiple of week
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12515:
URL: https://github.com/apache/arrow/pull/12515#issuecomment-1054519281
Benchmark runs are scheduled for baseline = b16329e3d5941277019b59c26ac441b9bf58ff93 and contender = 69073982bd44c79648405c70d0245d2a30e29bc2. 69073982bd44c79648405c70d0245d2a30e29bc2 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/16b3d2d65eea4b40a89c75154c60643e...c968734e82904fcead8d103a884cfe1a/)
[Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/2a900aaa6d7048ebbc07f68aa3c7f396...3b2af2beb04340c987a1d6d300ab7929/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/b7c6f7bba03845db8430bcd9832dbfe5...945a06fa69f1496cb0b854081d6295e1/)
[Finished :arrow_down:0.13% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/58f889d15fba4aedbd9f04fafa478e96...c9bdb4aedd7c4f2e94b0189eb275fdc5/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on pull request #12515: ARROW-15680: [C++] Temporal floor/ceil/round should accept week_starts_monday when rounding to multiple of week
Posted by GitBox <gi...@apache.org>.
lidavidm commented on pull request #12515:
URL: https://github.com/apache/arrow/pull/12515#issuecomment-1054512637
I think we can ignore these CI failures for now, merging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12515: ARROW-15680: [C++] Temporal floor/ceil/round should accept week_starts_monday when rounding to multiple of week
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12515:
URL: https://github.com/apache/arrow/pull/12515#issuecomment-1054849094
Benchmark runs are scheduled for baseline = b16329e3d5941277019b59c26ac441b9bf58ff93 and contender = 69073982bd44c79648405c70d0245d2a30e29bc2. 69073982bd44c79648405c70d0245d2a30e29bc2 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/16b3d2d65eea4b40a89c75154c60643e...48c5565f515d48a594d8edd5e8f0d484/)
[Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/2a900aaa6d7048ebbc07f68aa3c7f396...4af33d99a78440138e8bcad8b39bd864/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/b7c6f7bba03845db8430bcd9832dbfe5...5442f9ee44044028811fd758ecc8c1a9/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/58f889d15fba4aedbd9f04fafa478e96...1b0dd1adcac1423da77fe69e74ad3801/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #12515: ARROW-15680: [C++] Temporal floor/ceil/round should accept week_starts_monday when rounding to multiple of week
Posted by GitBox <gi...@apache.org>.
ursabot commented on pull request #12515:
URL: https://github.com/apache/arrow/pull/12515#issuecomment-1054849094
Benchmark runs are scheduled for baseline = b16329e3d5941277019b59c26ac441b9bf58ff93 and contender = 69073982bd44c79648405c70d0245d2a30e29bc2. 69073982bd44c79648405c70d0245d2a30e29bc2 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Scheduled] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/16b3d2d65eea4b40a89c75154c60643e...48c5565f515d48a594d8edd5e8f0d484/)
[Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/2a900aaa6d7048ebbc07f68aa3c7f396...4af33d99a78440138e8bcad8b39bd864/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/b7c6f7bba03845db8430bcd9832dbfe5...5442f9ee44044028811fd758ecc8c1a9/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/58f889d15fba4aedbd9f04fafa478e96...1b0dd1adcac1423da77fe69e74ad3801/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12515: ARROW-15680: [C++] Temporal floor/ceil/round should accept week_starts_monday when rounding to multiple of week
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12515:
URL: https://github.com/apache/arrow/pull/12515#issuecomment-1054519281
Benchmark runs are scheduled for baseline = b16329e3d5941277019b59c26ac441b9bf58ff93 and contender = 69073982bd44c79648405c70d0245d2a30e29bc2. 69073982bd44c79648405c70d0245d2a30e29bc2 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/16b3d2d65eea4b40a89c75154c60643e...c968734e82904fcead8d103a884cfe1a/)
[Finished :arrow_down:0.92% :arrow_up:0.17%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/2a900aaa6d7048ebbc07f68aa3c7f396...3b2af2beb04340c987a1d6d300ab7929/)
[Finished :arrow_down:1.07% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/b7c6f7bba03845db8430bcd9832dbfe5...945a06fa69f1496cb0b854081d6295e1/)
[Finished :arrow_down:0.13% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/58f889d15fba4aedbd9f04fafa478e96...c9bdb4aedd7c4f2e94b0189eb275fdc5/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12515: ARROW-15680: [C++] Temporal floor/ceil/round should accept week_starts_monday when rounding to multiple of week
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12515:
URL: https://github.com/apache/arrow/pull/12515#issuecomment-1054849094
Benchmark runs are scheduled for baseline = b16329e3d5941277019b59c26ac441b9bf58ff93 and contender = 69073982bd44c79648405c70d0245d2a30e29bc2. 69073982bd44c79648405c70d0245d2a30e29bc2 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/16b3d2d65eea4b40a89c75154c60643e...48c5565f515d48a594d8edd5e8f0d484/)
[Finished :arrow_down:1.72% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/2a900aaa6d7048ebbc07f68aa3c7f396...4af33d99a78440138e8bcad8b39bd864/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/b7c6f7bba03845db8430bcd9832dbfe5...5442f9ee44044028811fd758ecc8c1a9/)
[Finished :arrow_down:0.13% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/58f889d15fba4aedbd9f04fafa478e96...1b0dd1adcac1423da77fe69e74ad3801/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rok commented on pull request #12515: ARROW-15680: [C++] Temporal floor/ceil/round should accept week_starts_monday when rounding to multiple of week
Posted by GitBox <gi...@apache.org>.
rok commented on pull request #12515:
URL: https://github.com/apache/arrow/pull/12515#issuecomment-1054414019
> @rok I think it's [conda-forge/abseil-cpp-feedstock#25 (comment)](https://github.com/conda-forge/abseil-cpp-feedstock/pull/25#issuecomment-1054403044)
Yeah I think it was that indeed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on a change in pull request #12515: ARROW-15680: [C++] Temporal floor/ceil/round should accept week_starts_monday when rounding to multiple of week
Posted by GitBox <gi...@apache.org>.
lidavidm commented on a change in pull request #12515:
URL: https://github.com/apache/arrow/pull/12515#discussion_r815890993
##########
File path: cpp/src/arrow/compute/kernels/scalar_temporal_unary.cc
##########
@@ -725,6 +725,27 @@ const Duration FloorTimePoint(const int64_t arg, const int64_t multiple,
}
}
+template <typename Duration, typename Unit, typename Localizer>
Review comment:
nit: is there any point templating on Unit when it's apparently always `weeks` (and doesn't seem to make sense for any other unit)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12515: ARROW-15680: [C++] Temporal floor/ceil/round should accept week_starts_monday when rounding to multiple of week
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12515:
URL: https://github.com/apache/arrow/pull/12515#issuecomment-1054519281
Benchmark runs are scheduled for baseline = b16329e3d5941277019b59c26ac441b9bf58ff93 and contender = 69073982bd44c79648405c70d0245d2a30e29bc2. 69073982bd44c79648405c70d0245d2a30e29bc2 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/16b3d2d65eea4b40a89c75154c60643e...c968734e82904fcead8d103a884cfe1a/)
[Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/2a900aaa6d7048ebbc07f68aa3c7f396...3b2af2beb04340c987a1d6d300ab7929/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/b7c6f7bba03845db8430bcd9832dbfe5...945a06fa69f1496cb0b854081d6295e1/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/58f889d15fba4aedbd9f04fafa478e96...c9bdb4aedd7c4f2e94b0189eb275fdc5/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12515: ARROW-15680: [C++] Temporal floor/ceil/round should accept week_starts_monday when rounding to multiple of week
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12515:
URL: https://github.com/apache/arrow/pull/12515#issuecomment-1054849094
Benchmark runs are scheduled for baseline = b16329e3d5941277019b59c26ac441b9bf58ff93 and contender = 69073982bd44c79648405c70d0245d2a30e29bc2. 69073982bd44c79648405c70d0245d2a30e29bc2 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/16b3d2d65eea4b40a89c75154c60643e...48c5565f515d48a594d8edd5e8f0d484/)
[Finished :arrow_down:1.72% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/2a900aaa6d7048ebbc07f68aa3c7f396...4af33d99a78440138e8bcad8b39bd864/)
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/b7c6f7bba03845db8430bcd9832dbfe5...5442f9ee44044028811fd758ecc8c1a9/)
[Finished :arrow_down:0.13% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/58f889d15fba4aedbd9f04fafa478e96...1b0dd1adcac1423da77fe69e74ad3801/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #12515: ARROW-15680: [C++] Temporal floor/ceil/round should accept week_starts_monday when rounding to multiple of week
Posted by GitBox <gi...@apache.org>.
ursabot commented on pull request #12515:
URL: https://github.com/apache/arrow/pull/12515#issuecomment-1054519281
Benchmark runs are scheduled for baseline = b16329e3d5941277019b59c26ac441b9bf58ff93 and contender = 69073982bd44c79648405c70d0245d2a30e29bc2. 69073982bd44c79648405c70d0245d2a30e29bc2 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Scheduled] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/16b3d2d65eea4b40a89c75154c60643e...c968734e82904fcead8d103a884cfe1a/)
[Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/2a900aaa6d7048ebbc07f68aa3c7f396...3b2af2beb04340c987a1d6d300ab7929/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/b7c6f7bba03845db8430bcd9832dbfe5...945a06fa69f1496cb0b854081d6295e1/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/58f889d15fba4aedbd9f04fafa478e96...c9bdb4aedd7c4f2e94b0189eb275fdc5/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rok commented on a change in pull request #12515: ARROW-15680: [C++] Temporal floor/ceil/round should accept week_starts_monday when rounding to multiple of week
Posted by GitBox <gi...@apache.org>.
rok commented on a change in pull request #12515:
URL: https://github.com/apache/arrow/pull/12515#discussion_r815939936
##########
File path: cpp/src/arrow/compute/kernels/scalar_temporal_unary.cc
##########
@@ -725,6 +725,27 @@ const Duration FloorTimePoint(const int64_t arg, const int64_t multiple,
}
}
+template <typename Duration, typename Unit, typename Localizer>
Review comment:
Good point! I originally wanted to use `Ceil/Floor/RoundTimePoint` but then changed the design and forgot this there. Will fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on pull request #12515: ARROW-15680: [C++] Temporal floor/ceil/round should accept week_starts_monday when rounding to multiple of week
Posted by GitBox <gi...@apache.org>.
lidavidm commented on pull request #12515:
URL: https://github.com/apache/arrow/pull/12515#issuecomment-1054412701
@rok I think it's https://github.com/conda-forge/abseil-cpp-feedstock/pull/25#issuecomment-1054403044
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rok commented on pull request #12515: ARROW-15680: [C++] Temporal floor/ceil/round should accept week_starts_monday when rounding to multiple of week
Posted by GitBox <gi...@apache.org>.
rok commented on pull request #12515:
URL: https://github.com/apache/arrow/pull/12515#issuecomment-1054411253
@lidavidm I rebased to see if appveyor issue goes away.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org