[jira] Commented: (OFBIZ-2740) Payment capture is only triggered when Invoice is in Ready status

["Jacopo Cappellato (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-2740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12733171#action_12733171 ] 

Jacopo Cappellato commented on OFBIZ-2740:
------------------------------------------

Vikas,

thanks for implementing this.
The patch looks really good but here are some suggestions:

* instead of creating invoices (if missing) inside of updateInvoicesFromShipment, what if we call createInvoicesFromShipment before running it? This should greatly simplify the code. The service call could be placed in the same eca or at the beginning of the updateInvoicesFromShipment service
* I'd suggest a better name for the updateInvoicesFromShipment service (especially if you'll do the change I have proposed above): setInvoicesToReadyFromShipment (or createSetInvoicesToReadyFromShipment)

Jacopo


> Payment capture is only triggered when Invoice is in Ready status
> -----------------------------------------------------------------
>
>                 Key: OFBIZ-2740
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2740
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting, order, product
>    Affects Versions: SVN trunk
>            Reporter: Vikas Mayur
>             Fix For: SVN trunk
>
>         Attachments: invoices.patch
>
>
> Description can be read from link - http://www.nabble.com/Verify-Pick-Process-td24495382.html#a24509962

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.