You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@impala.apache.org by ph...@apache.org on 2018/02/02 18:51:27 UTC
[03/19] impala git commit: IMPALA-6356: Reduce amount of logging from
RpczStore::LogTrace()
IMPALA-6356: Reduce amount of logging from RpczStore::LogTrace()
This change bumps the threshold of RPC duration above which a RPC
is logged. It's increased from 1 second to 2 minutes which is
a conservative value in order to reduce the amount of logging from
RpczStore::LogTrace() when an Impala demon is busy.
Change-Id: I347b0dea641368e10ba84bc40ec250c26a4f43b2
Reviewed-on: http://gerrit.cloudera.org:8080/9125
Reviewed-by: Michael Ho <kw...@cloudera.com>
Reviewed-by: Mostafa Mokhtar <mm...@cloudera.com>
Tested-by: Impala Public Jenkins
Project: http://git-wip-us.apache.org/repos/asf/impala/repo
Commit: http://git-wip-us.apache.org/repos/asf/impala/commit/eec5b489
Tree: http://git-wip-us.apache.org/repos/asf/impala/tree/eec5b489
Diff: http://git-wip-us.apache.org/repos/asf/impala/diff/eec5b489
Branch: refs/heads/2.x
Commit: eec5b4896172cebe0e2a943364cd32082c80c9d1
Parents: cefc212
Author: Michael Ho <kw...@cloudera.com>
Authored: Wed Jan 24 13:58:02 2018 -0800
Committer: Impala Public Jenkins <im...@gerrit.cloudera.org>
Committed: Fri Feb 2 01:10:14 2018 +0000
----------------------------------------------------------------------
be/src/rpc/rpc-mgr.cc | 6 ++++++
1 file changed, 6 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/impala/blob/eec5b489/be/src/rpc/rpc-mgr.cc
----------------------------------------------------------------------
diff --git a/be/src/rpc/rpc-mgr.cc b/be/src/rpc/rpc-mgr.cc
index 91978bb..d4e8fe1 100644
--- a/be/src/rpc/rpc-mgr.cc
+++ b/be/src/rpc/rpc-mgr.cc
@@ -44,6 +44,9 @@ DECLARE_string(hostname);
DECLARE_string(principal);
DECLARE_string(be_principal);
+// Defined in kudu/rpc/rpcz_store.cc
+DECLARE_int32(rpc_duration_too_long_ms);
+
DEFINE_int32(num_acceptor_threads, 2,
"Number of threads dedicated to accepting connection requests for RPC services");
DEFINE_int32(num_reactor_threads, 0,
@@ -55,6 +58,9 @@ DEFINE_int32(rpc_retry_interval_ms, 5,
namespace impala {
Status RpcMgr::Init() {
+ // Log any RPCs which take longer than 2 minutes.
+ FLAGS_rpc_duration_too_long_ms = 2 * 60 * 1000;
+
MessengerBuilder bld("impala-server");
const scoped_refptr<MetricEntity> entity(
METRIC_ENTITY_server.Instantiate(®istry_, "krpc-metrics"));