You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mapreduce-issues@hadoop.apache.org by "Thomas Graves (JIRA)" <ji...@apache.org> on 2011/08/23 22:48:28 UTC

[jira] [Created] (MAPREDUCE-2874) ApplicationId printed in 2 different formats and has 2 different toString routines that are used

ApplicationId printed in 2 different formats and has 2 different toString routines that are used
------------------------------------------------------------------------------------------------

                 Key: MAPREDUCE-2874
                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2874
             Project: Hadoop Map/Reduce
          Issue Type: Bug
          Components: mrv2
    Affects Versions: 0.23.0
            Reporter: Thomas Graves
             Fix For: 0.23.0


Looks like the ApplicationId is now printed in 2 different formats.  ApplicationIdPBImpl.java has a toString routine that prints it in the format: return "application_" + this.getClusterTimestamp() + "_" + this.getId();

While the webapps use ./hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/Apps.java toString that prints it like:     
return _join("app", id.getClusterTimestamp(), id.getId());  

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MAPREDUCE-2874) ApplicationId printed in 2 different formats and has 2 different toString routines that are used

Posted by "Eric Payne (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-2874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13102969#comment-13102969 ] 

Eric Payne commented on MAPREDUCE-2874:
---------------------------------------

The findbugs warning was for the ResourceLocalizationService class. This warning exists on trunk with no modifications and is unrelated to this patch.


> ApplicationId printed in 2 different formats and has 2 different toString routines that are used
> ------------------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-2874
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2874
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2
>    Affects Versions: 0.23.0
>            Reporter: Thomas Graves
>            Assignee: Eric Payne
>             Fix For: 0.23.0
>
>         Attachments: AppStringNowApplicationString.2011-09-09.PNG.jpg, MAPREDUCE-2874.2011-09-09.patch
>
>
> Looks like the ApplicationId is now printed in 2 different formats.  ApplicationIdPBImpl.java has a toString routine that prints it in the format: return "application_" + this.getClusterTimestamp() + "_" + this.getId();
> While the webapps use ./hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/Apps.java toString that prints it like:     
> return _join("app", id.getClusterTimestamp(), id.getId());  

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MAPREDUCE-2874) ApplicationId printed in 2 different formats and has 2 different toString routines that are used

Posted by "Eric Payne (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-2874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13102672#comment-13102672 ] 

Eric Payne commented on MAPREDUCE-2874:
---------------------------------------

* I removed the {{Apps.toString(ApplicationId id)}} method from o.a.h.yarn.util.Apps.java
* The {{Apps.toString(ApplicationId id)}} method was used by {{webapp}} APIs.
* Since this {{toString}} method has an {{ApplicationId}} as it's parameter, I replaced every call to {{Apps.tostring(ApplicationId id)}} with a call to {{ApplicationId.toString()}}.
* The result is that in the yarn UI pages, job names now have the form application&#95;<epoch>&#95;<job num> rather than app&#95;<epoch>&#95;<job num> (See Screenshot AppStringNowApplicationString.2011-09-09.PNG)

> ApplicationId printed in 2 different formats and has 2 different toString routines that are used
> ------------------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-2874
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2874
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2
>    Affects Versions: 0.23.0
>            Reporter: Thomas Graves
>            Assignee: Eric Payne
>             Fix For: 0.23.0
>
>
> Looks like the ApplicationId is now printed in 2 different formats.  ApplicationIdPBImpl.java has a toString routine that prints it in the format: return "application_" + this.getClusterTimestamp() + "_" + this.getId();
> While the webapps use ./hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/Apps.java toString that prints it like:     
> return _join("app", id.getClusterTimestamp(), id.getId());  

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (MAPREDUCE-2874) ApplicationId printed in 2 different formats and has 2 different toString routines that are used

Posted by "Eric Payne (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-2874?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eric Payne updated MAPREDUCE-2874:
----------------------------------

    Attachment: AppStringNowApplicationString.2011-09-09.PNG.jpg

> ApplicationId printed in 2 different formats and has 2 different toString routines that are used
> ------------------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-2874
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2874
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2
>    Affects Versions: 0.23.0
>            Reporter: Thomas Graves
>            Assignee: Eric Payne
>             Fix For: 0.23.0
>
>         Attachments: AppStringNowApplicationString.2011-09-09.PNG.jpg
>
>
> Looks like the ApplicationId is now printed in 2 different formats.  ApplicationIdPBImpl.java has a toString routine that prints it in the format: return "application_" + this.getClusterTimestamp() + "_" + this.getId();
> While the webapps use ./hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/Apps.java toString that prints it like:     
> return _join("app", id.getClusterTimestamp(), id.getId());  

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (MAPREDUCE-2874) ApplicationId printed in 2 different formats and has 2 different toString routines that are used

Posted by "Eric Payne (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-2874?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eric Payne updated MAPREDUCE-2874:
----------------------------------

    Attachment:     (was: screenshot-1.jpg)

> ApplicationId printed in 2 different formats and has 2 different toString routines that are used
> ------------------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-2874
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2874
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2
>    Affects Versions: 0.23.0
>            Reporter: Thomas Graves
>            Assignee: Eric Payne
>             Fix For: 0.23.0
>
>         Attachments: AppStringNowApplicationString.2011-09-09.PNG.jpg
>
>
> Looks like the ApplicationId is now printed in 2 different formats.  ApplicationIdPBImpl.java has a toString routine that prints it in the format: return "application_" + this.getClusterTimestamp() + "_" + this.getId();
> While the webapps use ./hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/Apps.java toString that prints it like:     
> return _join("app", id.getClusterTimestamp(), id.getId());  

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MAPREDUCE-2874) ApplicationId printed in 2 different formats and has 2 different toString routines that are used

Posted by "Eric Payne (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-2874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13103636#comment-13103636 ] 

Eric Payne commented on MAPREDUCE-2874:
---------------------------------------

Thanks Arun!


From: Arun C Murthy (JIRA) <ji...@apache.org>


> ApplicationId printed in 2 different formats and has 2 different toString routines that are used
> ------------------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-2874
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2874
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2
>    Affects Versions: 0.23.0
>            Reporter: Thomas Graves
>            Assignee: Eric Payne
>             Fix For: 0.23.0
>
>         Attachments: AppStringNowApplicationString.2011-09-09.PNG.jpg, MAPREDUCE-2874.2011-09-09.patch
>
>
> Looks like the ApplicationId is now printed in 2 different formats.  ApplicationIdPBImpl.java has a toString routine that prints it in the format: return "application_" + this.getClusterTimestamp() + "_" + this.getId();
> While the webapps use ./hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/Apps.java toString that prints it like:     
> return _join("app", id.getClusterTimestamp(), id.getId());  

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Assigned] (MAPREDUCE-2874) ApplicationId printed in 2 different formats and has 2 different toString routines that are used

Posted by "Eric Payne (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-2874?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eric Payne reassigned MAPREDUCE-2874:
-------------------------------------

    Assignee: Eric Payne

> ApplicationId printed in 2 different formats and has 2 different toString routines that are used
> ------------------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-2874
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2874
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2
>    Affects Versions: 0.23.0
>            Reporter: Thomas Graves
>            Assignee: Eric Payne
>             Fix For: 0.23.0
>
>
> Looks like the ApplicationId is now printed in 2 different formats.  ApplicationIdPBImpl.java has a toString routine that prints it in the format: return "application_" + this.getClusterTimestamp() + "_" + this.getId();
> While the webapps use ./hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/Apps.java toString that prints it like:     
> return _join("app", id.getClusterTimestamp(), id.getId());  

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (MAPREDUCE-2874) ApplicationId printed in 2 different formats and has 2 different toString routines that are used

Posted by "Eric Payne (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-2874?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eric Payne updated MAPREDUCE-2874:
----------------------------------

    Status: Patch Available  (was: Open)

> ApplicationId printed in 2 different formats and has 2 different toString routines that are used
> ------------------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-2874
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2874
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2
>    Affects Versions: 0.23.0
>            Reporter: Thomas Graves
>            Assignee: Eric Payne
>             Fix For: 0.23.0
>
>         Attachments: AppStringNowApplicationString.2011-09-09.PNG.jpg, MAPREDUCE-2874.2011-09-09.patch
>
>
> Looks like the ApplicationId is now printed in 2 different formats.  ApplicationIdPBImpl.java has a toString routine that prints it in the format: return "application_" + this.getClusterTimestamp() + "_" + this.getId();
> While the webapps use ./hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/Apps.java toString that prints it like:     
> return _join("app", id.getClusterTimestamp(), id.getId());  

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (MAPREDUCE-2874) ApplicationId printed in 2 different formats and has 2 different toString routines that are used

Posted by "Arun C Murthy (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-2874?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Arun C Murthy updated MAPREDUCE-2874:
-------------------------------------

    Resolution: Fixed
        Status: Resolved  (was: Patch Available)

I just committed this. Thanks Eric!

> ApplicationId printed in 2 different formats and has 2 different toString routines that are used
> ------------------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-2874
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2874
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2
>    Affects Versions: 0.23.0
>            Reporter: Thomas Graves
>            Assignee: Eric Payne
>             Fix For: 0.23.0
>
>         Attachments: AppStringNowApplicationString.2011-09-09.PNG.jpg, MAPREDUCE-2874.2011-09-09.patch
>
>
> Looks like the ApplicationId is now printed in 2 different formats.  ApplicationIdPBImpl.java has a toString routine that prints it in the format: return "application_" + this.getClusterTimestamp() + "_" + this.getId();
> While the webapps use ./hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/Apps.java toString that prints it like:     
> return _join("app", id.getClusterTimestamp(), id.getId());  

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (MAPREDUCE-2874) ApplicationId printed in 2 different formats and has 2 different toString routines that are used

Posted by "Eric Payne (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-2874?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eric Payne updated MAPREDUCE-2874:
----------------------------------

    Attachment: MAPREDUCE-2874.2011-09-09.patch

> ApplicationId printed in 2 different formats and has 2 different toString routines that are used
> ------------------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-2874
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2874
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2
>    Affects Versions: 0.23.0
>            Reporter: Thomas Graves
>            Assignee: Eric Payne
>             Fix For: 0.23.0
>
>         Attachments: AppStringNowApplicationString.2011-09-09.PNG.jpg, MAPREDUCE-2874.2011-09-09.patch
>
>
> Looks like the ApplicationId is now printed in 2 different formats.  ApplicationIdPBImpl.java has a toString routine that prints it in the format: return "application_" + this.getClusterTimestamp() + "_" + this.getId();
> While the webapps use ./hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/Apps.java toString that prints it like:     
> return _join("app", id.getClusterTimestamp(), id.getId());  

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MAPREDUCE-2874) ApplicationId printed in 2 different formats and has 2 different toString routines that are used

Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-2874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13102807#comment-13102807 ] 

jiraposter@reviews.apache.org commented on MAPREDUCE-2874:
----------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1800/
-----------------------------------------------------------

Review request for Tom Graves.


Summary
-------

•I removed the Apps.toString(ApplicationId id) method from o.a.h.yarn.util.Apps.java
•The Apps.toString(ApplicationId id) method was used by webapp APIs.
•Since this toString method has an ApplicationId as it's parameter, I replaced every call to Apps.tostring(ApplicationId id) with a call to ApplicationId.toString().
•The result is that in the yarn UI pages, job names now have the form application_<epoch>_<job num> rather than app_<epoch>_<job num> (See Screenshot AppStringNowApplicationString.2011-09-09.PNG)


This addresses bug MAPREDUCE-2874.
    https://issues.apache.org/jira/browse/MAPREDUCE-2874


Diffs
-----

  branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/webapp/AppController.java 1167373 
  branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/webapp/TestAMWebApp.java 1167373 
  branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/test/java/org/apache/hadoop/mapreduce/v2/hs/webapp/TestHSWebApp.java 1167373 
  branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/Apps.java 1167373 
  branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/AppsBlock.java 1167373 
  branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/AppsList.java 1167373 

Diff: https://reviews.apache.org/r/1800/diff


Testing
-------


Thanks,

Eric



> ApplicationId printed in 2 different formats and has 2 different toString routines that are used
> ------------------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-2874
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2874
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2
>    Affects Versions: 0.23.0
>            Reporter: Thomas Graves
>            Assignee: Eric Payne
>             Fix For: 0.23.0
>
>         Attachments: AppStringNowApplicationString.2011-09-09.PNG.jpg, MAPREDUCE-2874.2011-09-09.patch
>
>
> Looks like the ApplicationId is now printed in 2 different formats.  ApplicationIdPBImpl.java has a toString routine that prints it in the format: return "application_" + this.getClusterTimestamp() + "_" + this.getId();
> While the webapps use ./hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/Apps.java toString that prints it like:     
> return _join("app", id.getClusterTimestamp(), id.getId());  

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] [Commented] (MAPREDUCE-2874) ApplicationId printed in 2 different formats and has 2 different toString routines that are used

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-2874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13103173#comment-13103173 ] 

Hudson commented on MAPREDUCE-2874:
-----------------------------------

Integrated in Hadoop-Common-trunk-Commit #876 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/876/])
    MAPREDUCE-2874. Fix formatting of ApplicationId in web-ui. Contributed by Eric Payne.

acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1169973
Files : 
* /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/webapp/AppController.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/webapp/TestAMWebApp.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/test/java/org/apache/hadoop/mapreduce/v2/hs/webapp/TestHSWebApp.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/Apps.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/AppsBlock.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/AppsList.java


> ApplicationId printed in 2 different formats and has 2 different toString routines that are used
> ------------------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-2874
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2874
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2
>    Affects Versions: 0.23.0
>            Reporter: Thomas Graves
>            Assignee: Eric Payne
>             Fix For: 0.23.0
>
>         Attachments: AppStringNowApplicationString.2011-09-09.PNG.jpg, MAPREDUCE-2874.2011-09-09.patch
>
>
> Looks like the ApplicationId is now printed in 2 different formats.  ApplicationIdPBImpl.java has a toString routine that prints it in the format: return "application_" + this.getClusterTimestamp() + "_" + this.getId();
> While the webapps use ./hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/Apps.java toString that prints it like:     
> return _join("app", id.getClusterTimestamp(), id.getId());  

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MAPREDUCE-2874) ApplicationId printed in 2 different formats and has 2 different toString routines that are used

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-2874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13103560#comment-13103560 ] 

Hudson commented on MAPREDUCE-2874:
-----------------------------------

Integrated in Hadoop-Hdfs-trunk #792 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/792/])
    MAPREDUCE-2874. Fix formatting of ApplicationId in web-ui. Contributed by Eric Payne.

acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1169973
Files : 
* /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/webapp/AppController.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/webapp/TestAMWebApp.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/test/java/org/apache/hadoop/mapreduce/v2/hs/webapp/TestHSWebApp.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/Apps.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/AppsBlock.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/AppsList.java


> ApplicationId printed in 2 different formats and has 2 different toString routines that are used
> ------------------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-2874
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2874
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2
>    Affects Versions: 0.23.0
>            Reporter: Thomas Graves
>            Assignee: Eric Payne
>             Fix For: 0.23.0
>
>         Attachments: AppStringNowApplicationString.2011-09-09.PNG.jpg, MAPREDUCE-2874.2011-09-09.patch
>
>
> Looks like the ApplicationId is now printed in 2 different formats.  ApplicationIdPBImpl.java has a toString routine that prints it in the format: return "application_" + this.getClusterTimestamp() + "_" + this.getId();
> While the webapps use ./hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/Apps.java toString that prints it like:     
> return _join("app", id.getClusterTimestamp(), id.getId());  

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MAPREDUCE-2874) ApplicationId printed in 2 different formats and has 2 different toString routines that are used

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-2874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13103176#comment-13103176 ] 

Hudson commented on MAPREDUCE-2874:
-----------------------------------

Integrated in Hadoop-Mapreduce-trunk-Commit #888 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/888/])
    MAPREDUCE-2874. Fix formatting of ApplicationId in web-ui. Contributed by Eric Payne.

acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1169973
Files : 
* /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/webapp/AppController.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/webapp/TestAMWebApp.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/test/java/org/apache/hadoop/mapreduce/v2/hs/webapp/TestHSWebApp.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/Apps.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/AppsBlock.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/AppsList.java


> ApplicationId printed in 2 different formats and has 2 different toString routines that are used
> ------------------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-2874
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2874
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2
>    Affects Versions: 0.23.0
>            Reporter: Thomas Graves
>            Assignee: Eric Payne
>             Fix For: 0.23.0
>
>         Attachments: AppStringNowApplicationString.2011-09-09.PNG.jpg, MAPREDUCE-2874.2011-09-09.patch
>
>
> Looks like the ApplicationId is now printed in 2 different formats.  ApplicationIdPBImpl.java has a toString routine that prints it in the format: return "application_" + this.getClusterTimestamp() + "_" + this.getId();
> While the webapps use ./hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/Apps.java toString that prints it like:     
> return _join("app", id.getClusterTimestamp(), id.getId());  

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MAPREDUCE-2874) ApplicationId printed in 2 different formats and has 2 different toString routines that are used

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-2874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13102694#comment-13102694 ] 

Hadoop QA commented on MAPREDUCE-2874:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12494035/MAPREDUCE-2874.2011-09-09.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 6 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    -1 findbugs.  The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed unit tests in .

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/704//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/704//artifact/trunk/hadoop-mapreduce-project/patchprocess/newPatchFindbugsWarningshadoop-yarn-server-nodemanager.html
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/704//console

This message is automatically generated.

> ApplicationId printed in 2 different formats and has 2 different toString routines that are used
> ------------------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-2874
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2874
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2
>    Affects Versions: 0.23.0
>            Reporter: Thomas Graves
>            Assignee: Eric Payne
>             Fix For: 0.23.0
>
>         Attachments: AppStringNowApplicationString.2011-09-09.PNG.jpg, MAPREDUCE-2874.2011-09-09.patch
>
>
> Looks like the ApplicationId is now printed in 2 different formats.  ApplicationIdPBImpl.java has a toString routine that prints it in the format: return "application_" + this.getClusterTimestamp() + "_" + this.getId();
> While the webapps use ./hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/Apps.java toString that prints it like:     
> return _join("app", id.getClusterTimestamp(), id.getId());  

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MAPREDUCE-2874) ApplicationId printed in 2 different formats and has 2 different toString routines that are used

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-2874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13103175#comment-13103175 ] 

Hudson commented on MAPREDUCE-2874:
-----------------------------------

Integrated in Hadoop-Hdfs-trunk-Commit #953 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/953/])
    MAPREDUCE-2874. Fix formatting of ApplicationId in web-ui. Contributed by Eric Payne.

acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1169973
Files : 
* /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/webapp/AppController.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/webapp/TestAMWebApp.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/test/java/org/apache/hadoop/mapreduce/v2/hs/webapp/TestHSWebApp.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/Apps.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/AppsBlock.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/AppsList.java


> ApplicationId printed in 2 different formats and has 2 different toString routines that are used
> ------------------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-2874
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2874
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2
>    Affects Versions: 0.23.0
>            Reporter: Thomas Graves
>            Assignee: Eric Payne
>             Fix For: 0.23.0
>
>         Attachments: AppStringNowApplicationString.2011-09-09.PNG.jpg, MAPREDUCE-2874.2011-09-09.patch
>
>
> Looks like the ApplicationId is now printed in 2 different formats.  ApplicationIdPBImpl.java has a toString routine that prints it in the format: return "application_" + this.getClusterTimestamp() + "_" + this.getId();
> While the webapps use ./hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/Apps.java toString that prints it like:     
> return _join("app", id.getClusterTimestamp(), id.getId());  

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MAPREDUCE-2874) ApplicationId printed in 2 different formats and has 2 different toString routines that are used

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-2874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13103237#comment-13103237 ] 

Hudson commented on MAPREDUCE-2874:
-----------------------------------

Integrated in Hadoop-Mapreduce-trunk #816 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/816/])
    MAPREDUCE-2874. Fix formatting of ApplicationId in web-ui. Contributed by Eric Payne.

acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1169973
Files : 
* /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/webapp/AppController.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/webapp/TestAMWebApp.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/test/java/org/apache/hadoop/mapreduce/v2/hs/webapp/TestHSWebApp.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/Apps.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/AppsBlock.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/AppsList.java


> ApplicationId printed in 2 different formats and has 2 different toString routines that are used
> ------------------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-2874
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2874
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2
>    Affects Versions: 0.23.0
>            Reporter: Thomas Graves
>            Assignee: Eric Payne
>             Fix For: 0.23.0
>
>         Attachments: AppStringNowApplicationString.2011-09-09.PNG.jpg, MAPREDUCE-2874.2011-09-09.patch
>
>
> Looks like the ApplicationId is now printed in 2 different formats.  ApplicationIdPBImpl.java has a toString routine that prints it in the format: return "application_" + this.getClusterTimestamp() + "_" + this.getId();
> While the webapps use ./hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/Apps.java toString that prints it like:     
> return _join("app", id.getClusterTimestamp(), id.getId());  

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (MAPREDUCE-2874) ApplicationId printed in 2 different formats and has 2 different toString routines that are used

Posted by "Eric Payne (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-2874?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eric Payne updated MAPREDUCE-2874:
----------------------------------

    Attachment: screenshot-1.jpg

> ApplicationId printed in 2 different formats and has 2 different toString routines that are used
> ------------------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-2874
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2874
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2
>    Affects Versions: 0.23.0
>            Reporter: Thomas Graves
>            Assignee: Eric Payne
>             Fix For: 0.23.0
>
>         Attachments: screenshot-1.jpg
>
>
> Looks like the ApplicationId is now printed in 2 different formats.  ApplicationIdPBImpl.java has a toString routine that prints it in the format: return "application_" + this.getClusterTimestamp() + "_" + this.getId();
> While the webapps use ./hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/Apps.java toString that prints it like:     
> return _join("app", id.getClusterTimestamp(), id.getId());  

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira