You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2021/08/03 14:35:30 UTC

[GitHub] [rocketmq-externals] StyleTang opened a new pull request #771: [Issue #770] [RocketMQ Console] Send message with message trace

StyleTang opened a new pull request #771:
URL: https://github.com/apache/rocketmq-externals/pull/771


   ## What is the purpose of the change
   
   Send test message with message trace
   
   ## Brief changelog
   
   User can choose send test message with message trace or not.
   
   ## Verifying this change
   
   ### Send test message with trace on.
   ![image](https://user-images.githubusercontent.com/5286751/128034024-8ab5de2f-ed9d-4313-aa88-f31565467670.png)
   
   ### Message Trace
   ![image](https://user-images.githubusercontent.com/5286751/128033847-6444fbc7-8c3f-4dea-9dd0-abc6a6ff12c2.png)
   
   
   Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
   
   - [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. 
   - [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
   - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
   - [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
   - [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test`  to make sure integration-test pass.
   - [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq-externals] vongosling commented on pull request #771: [Issue #770] [RocketMQ Console] Send message with message trace

Posted by GitBox <gi...@apache.org>.
vongosling commented on pull request #771:
URL: https://github.com/apache/rocketmq-externals/pull/771#issuecomment-893076790


   @StyleTang Could you help to check again, the code has a conflict with the latest update for SSL:-)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq-externals] vongosling commented on pull request #771: [Issue #770] [RocketMQ Console] Send message with message trace

Posted by GitBox <gi...@apache.org>.
vongosling commented on pull request #771:
URL: https://github.com/apache/rocketmq-externals/pull/771#issuecomment-893076790


   @StyleTang Could you help to check again, the code has a conflict with the latest update for SSL:-)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq-externals] StyleTang commented on pull request #771: [Issue #770] [RocketMQ Console] Send message with message trace

Posted by GitBox <gi...@apache.org>.
StyleTang commented on pull request #771:
URL: https://github.com/apache/rocketmq-externals/pull/771#issuecomment-893479772


   Conflict resolved.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq-externals] zhangjidi2016 commented on pull request #771: [Issue #770] [RocketMQ Console] Send message with message trace

Posted by GitBox <gi...@apache.org>.
zhangjidi2016 commented on pull request #771:
URL: https://github.com/apache/rocketmq-externals/pull/771#issuecomment-893556051


   LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq-externals] zhangjidi2016 edited a comment on pull request #771: [Issue #770] [RocketMQ Console] Send message with message trace

Posted by GitBox <gi...@apache.org>.
zhangjidi2016 edited a comment on pull request #771:
URL: https://github.com/apache/rocketmq-externals/pull/771#issuecomment-894244488


   > @zhangjidi2016 cool, I like what you said. could you pr it and I'd like to help to check it again?
   
   [https://github.com/apache/rocketmq-externals/pull/663](url) @vongosling 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq-externals] zhangjidi2016 commented on pull request #771: [Issue #770] [RocketMQ Console] Send message with message trace

Posted by GitBox <gi...@apache.org>.
zhangjidi2016 commented on pull request #771:
URL: https://github.com/apache/rocketmq-externals/pull/771#issuecomment-894244488


   > @zhangjidi2016 cool, I like what you said. could you pr it and I'd like to help to check it again?
   
   [https://github.com/apache/rocketmq-externals/pull/774](url) @vongosling 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq-externals] weibubli commented on pull request #771: [Issue #770] [RocketMQ Console] Send message with message trace

Posted by GitBox <gi...@apache.org>.
weibubli commented on pull request #771:
URL: https://github.com/apache/rocketmq-externals/pull/771#issuecomment-892547077


   LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq-externals] weibubli commented on pull request #771: [Issue #770] [RocketMQ Console] Send message with message trace

Posted by GitBox <gi...@apache.org>.
weibubli commented on pull request #771:
URL: https://github.com/apache/rocketmq-externals/pull/771#issuecomment-892547077


   LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq-externals] zhangjidi2016 commented on pull request #771: [Issue #770] [RocketMQ Console] Send message with message trace

Posted by GitBox <gi...@apache.org>.
zhangjidi2016 commented on pull request #771:
URL: https://github.com/apache/rocketmq-externals/pull/771#issuecomment-893964294


   Most of the errors were thrown by the previous XxxServiceImpl unit test, and the execution time was very long, I think we can delete this section, the submitted controller unit test has basically covered XxxServiceImpl in the execution.
   This is the unit test time I executed after I removed xxxServiceImplTest and the overall project code coverage.
   
   ![image](https://user-images.githubusercontent.com/18254437/128449159-ffe8dba2-2ff9-49e6-ba9c-cc7414d51aed.png)
   ![image](https://user-images.githubusercontent.com/18254437/128449073-513060f3-b3be-4e85-a20a-20ee1b608ea2.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq-externals] vongosling commented on pull request #771: [Issue #770] [RocketMQ Console] Send message with message trace

Posted by GitBox <gi...@apache.org>.
vongosling commented on pull request #771:
URL: https://github.com/apache/rocketmq-externals/pull/771#issuecomment-894057167


   @zhangjidi2016 cool, I like what you said. could you pr it and I'd like to help to check it again?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq-externals] vongosling commented on pull request #771: [Issue #770] [RocketMQ Console] Send message with message trace

Posted by GitBox <gi...@apache.org>.
vongosling commented on pull request #771:
URL: https://github.com/apache/rocketmq-externals/pull/771#issuecomment-893923190


   There are too many errors in our unit test, I think this is a very good contribution spot, looking forward to your attention here :-) @weibubli @zhangjidi2016 @StyleTang 
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq-externals] vongosling merged pull request #771: [Issue #770] [RocketMQ Console] Send message with message trace

Posted by GitBox <gi...@apache.org>.
vongosling merged pull request #771:
URL: https://github.com/apache/rocketmq-externals/pull/771


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org