You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Marvin Froeder (JIRA)" <ji...@codehaus.org> on 2008/10/28 18:16:51 UTC

[jira] Created: (MRESOURCES-75) Problems on resource filtering interpolation

Problems on resource filtering interpolation
--------------------------------------------

                 Key: MRESOURCES-75
                 URL: http://jira.codehaus.org/browse/MRESOURCES-75
             Project: Maven 2.x Resources Plugin
          Issue Type: Bug
            Reporter: Marvin Froeder
         Attachments: patch.zip

Hi,

I created a maven plugin, and this plugin add so properties to the project at validate phase.

Then, when resources-plugin copy resources to outputDirectory it is not interpolating the variables add by my plugin.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MRESOURCES-75) Problems on resource filtering interpolation

Posted by "Olivier Lamy (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MRESOURCES-75?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=152178#action_152178 ] 

Olivier Lamy commented on MRESOURCES-75:
----------------------------------------

Thanks for the patch.
Perso, I'd prefer something like :
{code:java}
mavenResourcesExecution.setExpressionEvaluator(ExpressionEvaluator  expressionEvaluator);
{code}
To not break the current interface.

> Problems on resource filtering interpolation
> --------------------------------------------
>
>                 Key: MRESOURCES-75
>                 URL: http://jira.codehaus.org/browse/MRESOURCES-75
>             Project: Maven 2.x Resources Plugin
>          Issue Type: Bug
>    Affects Versions: 2.3
>            Reporter: Marvin Froeder
>         Attachments: patch.zip
>
>
> Hi,
> I created a maven plugin, and this plugin add so properties to the project at validate phase.
> Then, when resources-plugin copy resources to outputDirectory it is not interpolating the variables add by my plugin.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Closed: (MRESOURCES-75) Problems on resource filtering interpolation

Posted by "John Casey (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MRESOURCES-75?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

John Casey closed MRESOURCES-75.
--------------------------------

      Assignee: John Casey
    Resolution: Cannot Reproduce

I've been through this patch, along with the pre-existing code, and even created a test project to try expressing the issue myself, using the buildnumber plugin from mojo.codehaus.org. I cannot reproduce using the 2.3 resources plugin, and the patch duplicates the interpolation logic already present in the filtering component, only using the PluginParameterExpressionEvaluator.

I've also talked with Marvin, and verified that he had accidentally specified version 2.2 of the resources plugin in the pluginManagement of a parent POM. By adjusting the version in my test project to 2.2, I've duplicated the problem. This means the problem was solved in the 2.3 release, so I'm closing this now as no further work needs to be done.

> Problems on resource filtering interpolation
> --------------------------------------------
>
>                 Key: MRESOURCES-75
>                 URL: http://jira.codehaus.org/browse/MRESOURCES-75
>             Project: Maven 2.x Resources Plugin
>          Issue Type: New Feature
>    Affects Versions: 2.3
>            Reporter: Marvin Froeder
>            Assignee: John Casey
>             Fix For: 2.4
>
>         Attachments: patch.zip
>
>
> Hi,
> I created a maven plugin, and this plugin add so properties to the project at validate phase.
> Then, when resources-plugin copy resources to outputDirectory it is not interpolating the variables add by my plugin.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (MRESOURCES-75) Problems on resource filtering interpolation

Posted by "Olivier Lamy (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MRESOURCES-75?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Olivier Lamy updated MRESOURCES-75:
-----------------------------------

    Fix Version/s:     (was: 2.4)

> Problems on resource filtering interpolation
> --------------------------------------------
>
>                 Key: MRESOURCES-75
>                 URL: http://jira.codehaus.org/browse/MRESOURCES-75
>             Project: Maven 2.x Resources Plugin
>          Issue Type: New Feature
>    Affects Versions: 2.3
>            Reporter: Marvin Froeder
>            Assignee: John Casey
>         Attachments: patch.zip
>
>
> Hi,
> I created a maven plugin, and this plugin add so properties to the project at validate phase.
> Then, when resources-plugin copy resources to outputDirectory it is not interpolating the variables add by my plugin.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (MRESOURCES-75) Problems on resource filtering interpolation

Posted by "Benjamin Bentmann (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MRESOURCES-75?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Benjamin Bentmann updated MRESOURCES-75:
----------------------------------------

    Affects Version/s: 2.3

> Problems on resource filtering interpolation
> --------------------------------------------
>
>                 Key: MRESOURCES-75
>                 URL: http://jira.codehaus.org/browse/MRESOURCES-75
>             Project: Maven 2.x Resources Plugin
>          Issue Type: Bug
>    Affects Versions: 2.3
>            Reporter: Marvin Froeder
>         Attachments: patch.zip
>
>
> Hi,
> I created a maven plugin, and this plugin add so properties to the project at validate phase.
> Then, when resources-plugin copy resources to outputDirectory it is not interpolating the variables add by my plugin.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (MRESOURCES-75) Problems on resource filtering interpolation

Posted by "Olivier Lamy (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MRESOURCES-75?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Olivier Lamy updated MRESOURCES-75:
-----------------------------------

    Fix Version/s: 2.4
       Issue Type: New Feature  (was: Bug)

> Problems on resource filtering interpolation
> --------------------------------------------
>
>                 Key: MRESOURCES-75
>                 URL: http://jira.codehaus.org/browse/MRESOURCES-75
>             Project: Maven 2.x Resources Plugin
>          Issue Type: New Feature
>    Affects Versions: 2.3
>            Reporter: Marvin Froeder
>             Fix For: 2.4
>
>         Attachments: patch.zip
>
>
> Hi,
> I created a maven plugin, and this plugin add so properties to the project at validate phase.
> Then, when resources-plugin copy resources to outputDirectory it is not interpolating the variables add by my plugin.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira