You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hc.apache.org by ol...@apache.org on 2020/06/30 10:20:48 UTC

[httpcomponents-core] branch master updated (22ebdd6 -> fd7c0cd)

This is an automated email from the ASF dual-hosted git repository.

olegk pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/httpcomponents-core.git.


    from 22ebdd6  Upgraded HttpCore version to 5.0.2-SNAPSHOT
     new b66b1a5  Corrected 5.0.1 release notes
     new fd7c0cd  HTTPCLIENT-2091: use finite (3 minutes) socket timeout by default

The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 RELEASE_NOTES.txt                                                   | 4 ++--
 .../src/main/java/org/apache/hc/core5/http/io/SocketConfig.java     | 6 ++++--
 2 files changed, 6 insertions(+), 4 deletions(-)


[httpcomponents-core] 02/02: HTTPCLIENT-2091: use finite (3 minutes) socket timeout by default

Posted by ol...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

olegk pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/httpcomponents-core.git

commit fd7c0cde7603b5a20f618a3e50a5f16eb2e38fe0
Author: Oleg Kalnichevski <ol...@apache.org>
AuthorDate: Tue Jun 30 12:15:00 2020 +0200

    HTTPCLIENT-2091: use finite (3 minutes) socket timeout by default
---
 .../src/main/java/org/apache/hc/core5/http/io/SocketConfig.java     | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/httpcore5/src/main/java/org/apache/hc/core5/http/io/SocketConfig.java b/httpcore5/src/main/java/org/apache/hc/core5/http/io/SocketConfig.java
index 20f23ee..78fbb13 100644
--- a/httpcore5/src/main/java/org/apache/hc/core5/http/io/SocketConfig.java
+++ b/httpcore5/src/main/java/org/apache/hc/core5/http/io/SocketConfig.java
@@ -44,6 +44,8 @@ import org.apache.hc.core5.util.Timeout;
 @Contract(threading = ThreadingBehavior.IMMUTABLE)
 public class SocketConfig {
 
+    private static final Timeout DEFAULT_SOCKET_TIMEOUT = Timeout.ofMinutes(3);
+
     public static final SocketConfig DEFAULT = new Builder().build();
 
     private final Timeout soTimeout;
@@ -191,7 +193,7 @@ public class SocketConfig {
         private SocketAddress socksProxyAddress;
 
         Builder() {
-            this.soTimeout = Timeout.ZERO_MILLISECONDS;
+            this.soTimeout = DEFAULT_SOCKET_TIMEOUT;
             this.soReuseAddress = false;
             this.soLinger = TimeValue.NEG_ONE_SECOND;
             this.soKeepAlive = false;
@@ -213,7 +215,7 @@ public class SocketConfig {
         /**
          * Determines the default socket timeout value for blocking I/O operations.
          * <p>
-         * Default: {@code 0} (no timeout)
+         * Default: 3 minutes
          * </p>
          *
          * @return the default socket timeout value for blocking I/O operations.


[httpcomponents-core] 01/02: Corrected 5.0.1 release notes

Posted by ol...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

olegk pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/httpcomponents-core.git

commit b66b1a5dfb58e46e8632438fca5c72d93178313f
Author: Oleg Kalnichevski <ol...@apache.org>
AuthorDate: Tue Jun 30 12:06:57 2020 +0200

    Corrected 5.0.1 release notes
---
 RELEASE_NOTES.txt | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/RELEASE_NOTES.txt b/RELEASE_NOTES.txt
index 619f490..58dc3d1 100644
--- a/RELEASE_NOTES.txt
+++ b/RELEASE_NOTES.txt
@@ -1,8 +1,8 @@
 Release 5.0.1
 ------------------
 
-This BETA improves handling of early response messages by the classic client protocol handler and
-fixes a number of minor defects.
+This release improves handling of early response messages by the classic client protocol handler
+and fixes a number of minor defects.
 
 Change Log
 -------------------