You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by pengcheng xiong <px...@hortonworks.com> on 2017/03/02 06:26:41 UTC

Re: Review Request 56810: Compute table stats when user computes column stats

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56810/
-----------------------------------------------------------

(Updated March 2, 2017, 6:26 a.m.)


Review request for hive and Ashutosh Chauhan.


Repository: hive-git


Description
-------

HIVE-15903


Diffs (updated)
-----

  itests/src/test/resources/testconfiguration.properties b01ebd8 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMapRedUtils.java 0e67ea6 
  ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java 3e749eb 
  ql/src/java/org/apache/hadoop/hive/ql/parse/ColumnStatsSemanticAnalyzer.java 93b8183 
  ql/src/java/org/apache/hadoop/hive/ql/parse/ProcessAnalyzeTable.java c13a404 
  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 0872e53 
  ql/src/test/queries/clientpositive/column_table_stats.q PRE-CREATION 
  ql/src/test/queries/clientpositive/exec_parallel_column_stats.q ceacc24 
  ql/src/test/results/clientpositive/alter_table_update_status.q.out a3c4f1a 
  ql/src/test/results/clientpositive/analyze_tbl_date.q.out a0cdbca 
  ql/src/test/results/clientpositive/analyze_tbl_part.q.out ed90b6f 
  ql/src/test/results/clientpositive/annotate_stats_deep_filters.q.out 32644dc 
  ql/src/test/results/clientpositive/annotate_stats_filter.q.out e22c3ef 
  ql/src/test/results/clientpositive/annotate_stats_groupby.q.out a8e4854 
  ql/src/test/results/clientpositive/annotate_stats_groupby2.q.out 31c4ed1 
  ql/src/test/results/clientpositive/annotate_stats_join.q.out 5d4fe6c 
  ql/src/test/results/clientpositive/annotate_stats_join_pkfk.q.out b4d46d2 
  ql/src/test/results/clientpositive/annotate_stats_limit.q.out ea181cb 
  ql/src/test/results/clientpositive/annotate_stats_select.q.out 873f1ab 
  ql/src/test/results/clientpositive/annotate_stats_table.q.out efc3c1f 
  ql/src/test/results/clientpositive/annotate_stats_union.q.out 059f261 
  ql/src/test/results/clientpositive/autoColumnStats_3.q.out dca158b 
  ql/src/test/results/clientpositive/avro_decimal.q.out 64e65ca 
  ql/src/test/results/clientpositive/avro_decimal_native.q.out cebc342 
  ql/src/test/results/clientpositive/cbo_rp_annotate_stats_groupby.q.out f260f03 
  ql/src/test/results/clientpositive/cbo_rp_auto_join1.q.out fe4bc4f 
  ql/src/test/results/clientpositive/colstats_all_nulls.q.out f67f81b 
  ql/src/test/results/clientpositive/columnStatsUpdateForStatsOptimizer_2.q.out af21343 
  ql/src/test/results/clientpositive/columnstats_partlvl.q.out 5c9f901 
  ql/src/test/results/clientpositive/columnstats_partlvl_dp.q.out 08fb42e 
  ql/src/test/results/clientpositive/columnstats_quoting.q.out 52e3538 
  ql/src/test/results/clientpositive/columnstats_tbllvl.q.out 60652e0 
  ql/src/test/results/clientpositive/compustat_avro.q.out 50c03bd 
  ql/src/test/results/clientpositive/compute_stats_date.q.out 73f08ad 
  ql/src/test/results/clientpositive/constGby.q.out fd8ecc2 
  ql/src/test/results/clientpositive/constant_prop_3.q.out ecf6e57 
  ql/src/test/results/clientpositive/decimal_stats.q.out cb02f76 
  ql/src/test/results/clientpositive/deleteAnalyze.q.out 4382522 
  ql/src/test/results/clientpositive/display_colstats_tbllvl.q.out e10edb4 
  ql/src/test/results/clientpositive/distinct_stats.q.out 73b4add 
  ql/src/test/results/clientpositive/drop_table_with_stats.q.out 52aa10a 
  ql/src/test/results/clientpositive/exec_parallel_column_stats.q.out f256ec1 
  ql/src/test/results/clientpositive/extrapolate_part_stats_date.q.out b12d3a1 
  ql/src/test/results/clientpositive/llap/alter_table_invalidate_column_stats.q.out 85d7dc4 
  ql/src/test/results/clientpositive/llap/columnStatsUpdateForStatsOptimizer_1.q.out 80ccddd 
  ql/src/test/results/clientpositive/llap/column_table_stats.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/llap/columnstats_part_coltype.q.out 3e28e58 
  ql/src/test/results/clientpositive/llap/deleteAnalyze.q.out ba14835 
  ql/src/test/results/clientpositive/llap/drop_partition_with_stats.q.out c6ab40d 
  ql/src/test/results/clientpositive/llap/explainuser_2.q.out e898111 
  ql/src/test/results/clientpositive/llap/llap_stats.q.out f6921f1 
  ql/src/test/results/clientpositive/llap/llapdecider.q.out d514f42 
  ql/src/test/results/clientpositive/llap/metadata_only_queries.q.out c8190bd 
  ql/src/test/results/clientpositive/llap/schema_evol_stats.q.out be8ca4a 
  ql/src/test/results/clientpositive/llap/special_character_in_tabnames_1.q.out d01b373 
  ql/src/test/results/clientpositive/llap/stats_only_null.q.out c905ceb 
  ql/src/test/results/clientpositive/llap/union_remove_26.q.out 18b9aa5 
  ql/src/test/results/clientpositive/llap/vector_outer_join1.q.out 072399e 
  ql/src/test/results/clientpositive/llap/vector_outer_join2.q.out d79c71b 
  ql/src/test/results/clientpositive/llap/vector_outer_join3.q.out dbbfd34 
  ql/src/test/results/clientpositive/llap/vector_outer_join4.q.out ffce9e6 
  ql/src/test/results/clientpositive/llap/vector_outer_join5.q.out 4f25253 
  ql/src/test/results/clientpositive/llap/vectorized_dynamic_semijoin_reduction.q.out eb0f405 
  ql/src/test/results/clientpositive/llap/vectorized_dynamic_semijoin_reduction2.q.out b369e7c 
  ql/src/test/results/clientpositive/metadata_only_queries.q.out 57b59dd 
  ql/src/test/results/clientpositive/partial_column_stats.q.out 59b52b0 
  ql/src/test/results/clientpositive/pcs.q.out c422a3d 
  ql/src/test/results/clientpositive/remove_exprs_stats.q.out 567e6b2 
  ql/src/test/results/clientpositive/rename_table_update_column_stats.q.out c025cfa 
  ql/src/test/results/clientpositive/spark/annotate_stats_join.q.out 31ccc5c 
  ql/src/test/results/clientpositive/spark/avro_decimal_native.q.out cebc342 
  ql/src/test/results/clientpositive/spark/limit_pushdown.q.out c81240d 
  ql/src/test/results/clientpositive/spark/metadata_only_queries.q.out 543d0ef 
  ql/src/test/results/clientpositive/spark/stats_only_null.q.out 359eea3 
  ql/src/test/results/clientpositive/spark/vector_elt.q.out b49462a 
  ql/src/test/results/clientpositive/spark/vector_left_outer_join.q.out 91af229 
  ql/src/test/results/clientpositive/spark/vector_outer_join1.q.out 169b0f8 
  ql/src/test/results/clientpositive/spark/vector_outer_join2.q.out d56c4ab 
  ql/src/test/results/clientpositive/spark/vector_outer_join3.q.out dbbfd34 
  ql/src/test/results/clientpositive/spark/vector_outer_join4.q.out ffce9e6 
  ql/src/test/results/clientpositive/spark/vector_outer_join5.q.out 4f25253 
  ql/src/test/results/clientpositive/spark/vectorization_0.q.out 714c21f 
  ql/src/test/results/clientpositive/spark/vectorization_13.q.out a6ef031 
  ql/src/test/results/clientpositive/spark/vectorization_14.q.out 1541908 
  ql/src/test/results/clientpositive/spark/vectorization_15.q.out 1d925c5 
  ql/src/test/results/clientpositive/spark/vectorization_16.q.out e731c2d 
  ql/src/test/results/clientpositive/spark/vectorization_17.q.out a8f401b 
  ql/src/test/results/clientpositive/spark/vectorization_9.q.out e731c2d 
  ql/src/test/results/clientpositive/spark/vectorization_div0.q.out 923ff5e 
  ql/src/test/results/clientpositive/spark/vectorization_pushdown.q.out 1f1bb30 
  ql/src/test/results/clientpositive/spark/vectorization_short_regress.q.out 98c0505 
  ql/src/test/results/clientpositive/spark/vectorized_case.q.out 67ed3dd 
  ql/src/test/results/clientpositive/spark/vectorized_mapjoin.q.out 030a71b 
  ql/src/test/results/clientpositive/spark/vectorized_math_funcs.q.out 90ef576 
  ql/src/test/results/clientpositive/spark/vectorized_nested_mapjoin.q.out 996021f 
  ql/src/test/results/clientpositive/spark/vectorized_shufflejoin.q.out 3b8b636 
  ql/src/test/results/clientpositive/spark/vectorized_string_funcs.q.out 26aab1c 
  ql/src/test/results/clientpositive/special_character_in_tabnames_2.q.out 8cb04c7 
  ql/src/test/results/clientpositive/stats_invalidation.q.out a0e7663 
  ql/src/test/results/clientpositive/stats_missing_warning.q.out 0ed70a0 
  ql/src/test/results/clientpositive/stats_only_null.q.out 88c2114 
  ql/src/test/results/clientpositive/stats_partial_size.q.out c779741 
  ql/src/test/results/clientpositive/stats_ppr_all.q.out d4060c6 
  ql/src/test/results/clientpositive/temp_table_display_colstats_tbllvl.q.out c7ee93d 
  ql/src/test/results/clientpositive/tez/explainanalyze_3.q.out 20c330a 
  ql/src/test/results/clientpositive/tez/explainanalyze_5.q.out ee9affb 
  ql/src/test/results/clientpositive/tez/explainuser_3.q.out 74e4693 
  ql/src/test/results/clientpositive/vector_outer_join1.q.out 565ddac 
  ql/src/test/results/clientpositive/vector_outer_join2.q.out 4f63113 
  ql/src/test/results/clientpositive/vector_outer_join3.q.out 53377db 
  ql/src/test/results/clientpositive/vector_outer_join4.q.out 324b67e 


Diff: https://reviews.apache.org/r/56810/diff/4/

Changes: https://reviews.apache.org/r/56810/diff/3-4/


Testing
-------


Thanks,

pengcheng xiong


Re: Review Request 56810: Compute table stats when user computes column stats

Posted by pengcheng xiong <px...@hortonworks.com>.

> On March 3, 2017, 11:54 p.m., Ashutosh Chauhan wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/parse/ProcessAnalyzeTable.java
> > Lines 170 (patched)
> > <https://reviews.apache.org/r/56810/diff/5/?file=1655198#file1655198line173>
> >
> >     tezWork.getAllWork().get(0).setGatheringStats(true);

This will throw NPE. Note that ProcessAnalyzeTable will be fired when it matches TS while GenTezUtils will be fined when it matches RS. ProcessAnalyzeTable will be fired before any map work is generated. Thus, it will not have any work at this place.


- pengcheng


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56810/#review167896
-----------------------------------------------------------


On March 2, 2017, 10:37 p.m., pengcheng xiong wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56810/
> -----------------------------------------------------------
> 
> (Updated March 2, 2017, 10:37 p.m.)
> 
> 
> Review request for hive and Ashutosh Chauhan.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> HIVE-15903
> 
> 
> Diffs
> -----
> 
>   itests/src/test/resources/testconfiguration.properties b01ebd8 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java 3e749eb 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/GenTezUtils.java 7f5fdff 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/ProcessAnalyzeTable.java c13a404 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 0872e53 
>   ql/src/test/queries/clientpositive/column_table_stats.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/column_table_stats_orc.q PRE-CREATION 
>   ql/src/test/results/clientpositive/llap/column_table_stats.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/llap/column_table_stats_orc.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/perf/query14.q.out 9821180 
>   ql/src/test/results/clientpositive/tez/explainanalyze_3.q.out 20c330a 
>   ql/src/test/results/clientpositive/tez/explainanalyze_5.q.out ee9affb 
>   ql/src/test/results/clientpositive/tez/explainuser_3.q.out 74e4693 
> 
> 
> Diff: https://reviews.apache.org/r/56810/diff/5/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> pengcheng xiong
> 
>


Re: Review Request 56810: Compute table stats when user computes column stats

Posted by Ashutosh Chauhan <ha...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56810/#review167896
-----------------------------------------------------------



Can you also add golden file updates in RB, wanna go through those changes as well.


ql/src/java/org/apache/hadoop/hive/ql/parse/GenTezUtils.java
Lines 202-205 (patched)
<https://reviews.apache.org/r/56810/#comment239870>

    This should be done in ProcessAnalyzeTable.



ql/src/java/org/apache/hadoop/hive/ql/parse/ProcessAnalyzeTable.java
Lines 170 (patched)
<https://reviews.apache.org/r/56810/#comment239871>

    tezWork.getAllWork().get(0).setGatheringStats(true);



ql/src/java/org/apache/hadoop/hive/ql/parse/ProcessAnalyzeTable.java
Lines 189 (patched)
<https://reviews.apache.org/r/56810/#comment239873>

    this is not needed.. since at this point partitions has already been read.



ql/src/java/org/apache/hadoop/hive/ql/parse/ProcessAnalyzeTable.java
Lines 190 (patched)
<https://reviews.apache.org/r/56810/#comment239872>

    LOG.debug()



ql/src/java/org/apache/hadoop/hive/ql/parse/ProcessAnalyzeTable.java
Lines 198 (patched)
<https://reviews.apache.org/r/56810/#comment239874>

    Better comment: For ORC, there is no Tez Job.



ql/src/java/org/apache/hadoop/hive/ql/parse/ProcessAnalyzeTable.java
Lines 212 (patched)
<https://reviews.apache.org/r/56810/#comment239875>

    Remove this. Both incorrect as well as misplaced.


- Ashutosh Chauhan


On March 2, 2017, 10:37 p.m., pengcheng xiong wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56810/
> -----------------------------------------------------------
> 
> (Updated March 2, 2017, 10:37 p.m.)
> 
> 
> Review request for hive and Ashutosh Chauhan.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> HIVE-15903
> 
> 
> Diffs
> -----
> 
>   itests/src/test/resources/testconfiguration.properties b01ebd8 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java 3e749eb 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/GenTezUtils.java 7f5fdff 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/ProcessAnalyzeTable.java c13a404 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 0872e53 
>   ql/src/test/queries/clientpositive/column_table_stats.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/column_table_stats_orc.q PRE-CREATION 
>   ql/src/test/results/clientpositive/llap/column_table_stats.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/llap/column_table_stats_orc.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/perf/query14.q.out 9821180 
>   ql/src/test/results/clientpositive/tez/explainanalyze_3.q.out 20c330a 
>   ql/src/test/results/clientpositive/tez/explainanalyze_5.q.out ee9affb 
>   ql/src/test/results/clientpositive/tez/explainuser_3.q.out 74e4693 
> 
> 
> Diff: https://reviews.apache.org/r/56810/diff/5/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> pengcheng xiong
> 
>


Re: Review Request 56810: Compute table stats when user computes column stats

Posted by pengcheng xiong <px...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56810/
-----------------------------------------------------------

(Updated March 8, 2017, 5:52 a.m.)


Review request for hive and Ashutosh Chauhan.


Repository: hive-git


Description
-------

HIVE-15903


Diffs (updated)
-----

  itests/src/test/resources/testconfiguration.properties 9babc77 
  ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java 3e749eb 
  ql/src/java/org/apache/hadoop/hive/ql/parse/GenTezUtils.java 7f5fdff 
  ql/src/java/org/apache/hadoop/hive/ql/parse/ProcessAnalyzeTable.java c13a404 
  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java ee9101b 
  ql/src/test/queries/clientpositive/column_table_stats.q PRE-CREATION 
  ql/src/test/queries/clientpositive/column_table_stats_orc.q PRE-CREATION 
  ql/src/test/results/clientpositive/llap/alter_table_invalidate_column_stats.q.out c1c5f62 
  ql/src/test/results/clientpositive/llap/columnStatsUpdateForStatsOptimizer_1.q.out 80ccddd 
  ql/src/test/results/clientpositive/llap/column_table_stats.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/llap/column_table_stats_orc.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/llap/columnstats_part_coltype.q.out 3e28e58 
  ql/src/test/results/clientpositive/llap/deleteAnalyze.q.out ba14835 
  ql/src/test/results/clientpositive/llap/drop_partition_with_stats.q.out c6ab40d 
  ql/src/test/results/clientpositive/llap/explainuser_2.q.out e898111 
  ql/src/test/results/clientpositive/llap/extrapolate_part_stats_partial_ndv.q.out c9b8cfd 
  ql/src/test/results/clientpositive/llap/llap_stats.q.out f6921f1 
  ql/src/test/results/clientpositive/llap/llapdecider.q.out d514f42 
  ql/src/test/results/clientpositive/llap/metadata_only_queries.q.out c8190bd 
  ql/src/test/results/clientpositive/llap/metadata_only_queries_with_filters.q.out 6dea3e0 
  ql/src/test/results/clientpositive/llap/schema_evol_stats.q.out 906e5e8 
  ql/src/test/results/clientpositive/llap/schema_evol_text_vec_table.q.out 5bfe159 
  ql/src/test/results/clientpositive/llap/special_character_in_tabnames_1.q.out d01b373 
  ql/src/test/results/clientpositive/llap/stats_only_null.q.out c905ceb 
  ql/src/test/results/clientpositive/llap/union_remove_26.q.out 18b9aa5 
  ql/src/test/results/clientpositive/llap/vector_outer_join1.q.out 072399e 
  ql/src/test/results/clientpositive/llap/vector_outer_join2.q.out d79c71b 
  ql/src/test/results/clientpositive/llap/vector_outer_join3.q.out dbbfd34 
  ql/src/test/results/clientpositive/llap/vector_outer_join4.q.out ffce9e6 
  ql/src/test/results/clientpositive/llap/vector_outer_join5.q.out 4f25253 
  ql/src/test/results/clientpositive/llap/vectorized_dynamic_semijoin_reduction.q.out eb0f405 
  ql/src/test/results/clientpositive/llap/vectorized_dynamic_semijoin_reduction2.q.out b369e7c 
  ql/src/test/results/clientpositive/perf/query14.q.out 9821180 
  ql/src/test/results/clientpositive/tez/explainanalyze_3.q.out 20c330a 
  ql/src/test/results/clientpositive/tez/explainanalyze_5.q.out ee9affb 
  ql/src/test/results/clientpositive/tez/explainuser_3.q.out 74e4693 


Diff: https://reviews.apache.org/r/56810/diff/8/

Changes: https://reviews.apache.org/r/56810/diff/7-8/


Testing
-------


Thanks,

pengcheng xiong


Re: Review Request 56810: Compute table stats when user computes column stats

Posted by pengcheng xiong <px...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56810/
-----------------------------------------------------------

(Updated March 8, 2017, 5:51 a.m.)


Review request for hive and Ashutosh Chauhan.


Changes
-------

with golden file updates


Repository: hive-git


Description
-------

HIVE-15903


Diffs (updated)
-----

  itests/src/test/resources/testconfiguration.properties 9babc77 
  ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java 3e749eb 
  ql/src/java/org/apache/hadoop/hive/ql/parse/GenTezUtils.java 7f5fdff 
  ql/src/java/org/apache/hadoop/hive/ql/parse/ProcessAnalyzeTable.java c13a404 
  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java ee9101b 
  ql/src/test/queries/clientpositive/column_table_stats.q PRE-CREATION 
  ql/src/test/queries/clientpositive/column_table_stats_orc.q PRE-CREATION 
  ql/src/test/results/clientpositive/llap/alter_table_invalidate_column_stats.q.out c1c5f62 
  ql/src/test/results/clientpositive/llap/columnStatsUpdateForStatsOptimizer_1.q.out 80ccddd 
  ql/src/test/results/clientpositive/llap/column_table_stats.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/llap/column_table_stats_orc.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/llap/columnstats_part_coltype.q.out 3e28e58 
  ql/src/test/results/clientpositive/llap/deleteAnalyze.q.out ba14835 
  ql/src/test/results/clientpositive/llap/drop_partition_with_stats.q.out c6ab40d 
  ql/src/test/results/clientpositive/llap/explainuser_2.q.out e898111 
  ql/src/test/results/clientpositive/llap/extrapolate_part_stats_partial_ndv.q.out c9b8cfd 
  ql/src/test/results/clientpositive/llap/llap_stats.q.out f6921f1 
  ql/src/test/results/clientpositive/llap/llapdecider.q.out d514f42 
  ql/src/test/results/clientpositive/llap/metadata_only_queries.q.out c8190bd 
  ql/src/test/results/clientpositive/llap/metadata_only_queries_with_filters.q.out 6dea3e0 
  ql/src/test/results/clientpositive/llap/schema_evol_stats.q.out 906e5e8 
  ql/src/test/results/clientpositive/llap/schema_evol_text_vec_table.q.out 5bfe159 
  ql/src/test/results/clientpositive/llap/special_character_in_tabnames_1.q.out d01b373 
  ql/src/test/results/clientpositive/llap/stats_only_null.q.out c905ceb 
  ql/src/test/results/clientpositive/llap/union_remove_26.q.out 18b9aa5 
  ql/src/test/results/clientpositive/llap/vector_outer_join1.q.out 072399e 
  ql/src/test/results/clientpositive/llap/vector_outer_join2.q.out d79c71b 
  ql/src/test/results/clientpositive/llap/vector_outer_join3.q.out dbbfd34 
  ql/src/test/results/clientpositive/llap/vector_outer_join4.q.out ffce9e6 
  ql/src/test/results/clientpositive/llap/vector_outer_join5.q.out 4f25253 
  ql/src/test/results/clientpositive/llap/vectorized_dynamic_semijoin_reduction.q.out eb0f405 
  ql/src/test/results/clientpositive/llap/vectorized_dynamic_semijoin_reduction2.q.out b369e7c 
  ql/src/test/results/clientpositive/perf/query14.q.out 9821180 
  ql/src/test/results/clientpositive/tez/explainanalyze_3.q.out 20c330a 
  ql/src/test/results/clientpositive/tez/explainanalyze_5.q.out ee9affb 
  ql/src/test/results/clientpositive/tez/explainuser_3.q.out 74e4693 


Diff: https://reviews.apache.org/r/56810/diff/7/

Changes: https://reviews.apache.org/r/56810/diff/6-7/


Testing
-------


Thanks,

pengcheng xiong


Re: Review Request 56810: Compute table stats when user computes column stats

Posted by pengcheng xiong <px...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56810/
-----------------------------------------------------------

(Updated March 4, 2017, 7:41 p.m.)


Review request for hive and Ashutosh Chauhan.


Changes
-------

address ashutosh's comments.


Repository: hive-git


Description
-------

HIVE-15903


Diffs (updated)
-----

  itests/src/test/resources/testconfiguration.properties b01ebd8 
  ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java 3e749eb 
  ql/src/java/org/apache/hadoop/hive/ql/parse/GenTezUtils.java 7f5fdff 
  ql/src/java/org/apache/hadoop/hive/ql/parse/ProcessAnalyzeTable.java c13a404 
  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 0872e53 
  ql/src/test/queries/clientpositive/column_table_stats.q PRE-CREATION 
  ql/src/test/queries/clientpositive/column_table_stats_orc.q PRE-CREATION 
  ql/src/test/results/clientpositive/llap/column_table_stats.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/llap/column_table_stats_orc.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/perf/query14.q.out 9821180 
  ql/src/test/results/clientpositive/tez/explainanalyze_3.q.out 20c330a 
  ql/src/test/results/clientpositive/tez/explainanalyze_5.q.out ee9affb 
  ql/src/test/results/clientpositive/tez/explainuser_3.q.out 74e4693 


Diff: https://reviews.apache.org/r/56810/diff/6/

Changes: https://reviews.apache.org/r/56810/diff/5-6/


Testing
-------


Thanks,

pengcheng xiong


Re: Review Request 56810: Compute table stats when user computes column stats

Posted by pengcheng xiong <px...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56810/
-----------------------------------------------------------

(Updated March 2, 2017, 10:37 p.m.)


Review request for hive and Ashutosh Chauhan.


Repository: hive-git


Description
-------

HIVE-15903


Diffs (updated)
-----

  itests/src/test/resources/testconfiguration.properties b01ebd8 
  ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java 3e749eb 
  ql/src/java/org/apache/hadoop/hive/ql/parse/GenTezUtils.java 7f5fdff 
  ql/src/java/org/apache/hadoop/hive/ql/parse/ProcessAnalyzeTable.java c13a404 
  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 0872e53 
  ql/src/test/queries/clientpositive/column_table_stats.q PRE-CREATION 
  ql/src/test/queries/clientpositive/column_table_stats_orc.q PRE-CREATION 
  ql/src/test/results/clientpositive/llap/column_table_stats.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/llap/column_table_stats_orc.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/perf/query14.q.out 9821180 
  ql/src/test/results/clientpositive/tez/explainanalyze_3.q.out 20c330a 
  ql/src/test/results/clientpositive/tez/explainanalyze_5.q.out ee9affb 
  ql/src/test/results/clientpositive/tez/explainuser_3.q.out 74e4693 


Diff: https://reviews.apache.org/r/56810/diff/5/

Changes: https://reviews.apache.org/r/56810/diff/4-5/


Testing
-------


Thanks,

pengcheng xiong