You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/09/09 23:45:47 UTC

[GitHub] [incubator-superset] john-bodley opened a new pull request #10823: fix: Making the database read-only

john-bodley opened a new pull request #10823:
URL: https://github.com/apache/incubator-superset/pull/10823


   ### SUMMARY
   
   This PR makes a few related consistency updates to ensure that the database/cluster et al. is read-only either in the FAB CRUD or React data editor. Note one could reason that you could potential make the schema, table, etc. read-only, though my sense is that is that could be somewhat controversial. 
   
   Specially this PR: 
   
   1. For the React data editor makes the database read-only which is consistent with the FAB CRUD views.
   2. Moves the React data editor warning above the tabs, i.e., users should be aware that changing any fields (metrics, columns, etc.) will impact all charts using said datasource.
   3. For the Druid datasource CRUD view makes the cluster and datasource name read only. The cluster is akin to the database and thus this ensures consistency. Additionally the Druid datasource name is fixed hence this was also defined as read-only.  
   
   @dpgaspar I noticed that there seems to have been a regression in FAB and the read-only selector logic which we are using (per the [documentation](https://flask-appbuilder.readthedocs.io/en/latest/advanced.html#forms-readonly-fields)) no longer works. I've also verified this using the FAB examples and was wondering whether you could look into it?
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   #### BEFORE
   
   <img width="805" alt="Screen Shot 2020-09-09 at 4 43 44 PM" src="https://user-images.githubusercontent.com/4567245/92665525-ab010b80-f2bb-11ea-8a76-7c234f041cc4.png">
   
   #### AFTER
   
   <img width="803" alt="Screen Shot 2020-09-09 at 4 28 33 PM" src="https://user-images.githubusercontent.com/4567245/92665391-4b0a6500-f2bb-11ea-991f-2726b3f04417.png">
   
   ### TEST PLAN
   
   Tested locally. 
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] mistercrunch commented on pull request #10823: fix: Making the database/cluster read-only

Posted by GitBox <gi...@apache.org>.
mistercrunch commented on pull request #10823:
URL: https://github.com/apache/incubator-superset/pull/10823#issuecomment-689981955


   related: https://github.com/apache/incubator-superset/pull/10731, I could add this logic into my PR
   
   We're looking to deprecate the CRUD for tables soon-ish.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10823: fix: Making the database/cluster read-only

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10823:
URL: https://github.com/apache/incubator-superset/pull/10823#issuecomment-689884277






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10823: fix: Making the database/cluster read-only

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10823:
URL: https://github.com/apache/incubator-superset/pull/10823#issuecomment-689884277


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10823?src=pr&el=h1) Report
   > Merging [#10823](https://codecov.io/gh/apache/incubator-superset/pull/10823?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/c2216e029d09938cf1ecef82e1cf7e435908dbe3?el=desc) will **decrease** coverage by `4.21%`.
   > The diff coverage is `77.77%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10823/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10823?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10823      +/-   ##
   ==========================================
   - Coverage   65.43%   61.21%   -4.22%     
   ==========================================
     Files         803      803              
     Lines       37930    37935       +5     
     Branches     3561     3561              
   ==========================================
   - Hits        24818    23223    -1595     
   - Misses      13008    14526    +1518     
   - Partials      104      186      +82     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `61.59% <ø> (+<0.01%)` | :arrow_up: |
   | #python | `60.99% <77.77%> (+<0.01%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10823?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/components/TableSelector.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10823/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVTZWxlY3Rvci5qc3g=) | `79.08% <ø> (-5.89%)` | :arrow_down: |
   | [...erset-frontend/src/datasource/DatasourceEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10823/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvRGF0YXNvdXJjZUVkaXRvci5qc3g=) | `69.94% <ø> (-2.74%)` | :arrow_down: |
   | [superset/connectors/sqla/views.py](https://codecov.io/gh/apache/incubator-superset/pull/10823/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL3ZpZXdzLnB5) | `67.28% <ø> (ø)` | |
   | [superset/connectors/base/views.py](https://codecov.io/gh/apache/incubator-superset/pull/10823/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL3ZpZXdzLnB5) | `71.42% <66.66%> (-3.58%)` | :arrow_down: |
   | [superset/connectors/druid/views.py](https://codecov.io/gh/apache/incubator-superset/pull/10823/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC92aWV3cy5weQ==) | `69.79% <100.00%> (+0.41%)` | :arrow_up: |
   | [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10823/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10823/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10823/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10823/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10823/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [161 more](https://codecov.io/gh/apache/incubator-superset/pull/10823/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10823?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10823?src=pr&el=footer). Last update [c2216e0...368babf](https://codecov.io/gh/apache/incubator-superset/pull/10823?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10823: fix: Making the database/cluster read-only

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10823:
URL: https://github.com/apache/incubator-superset/pull/10823#issuecomment-689884277


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10823?src=pr&el=h1) Report
   > Merging [#10823](https://codecov.io/gh/apache/incubator-superset/pull/10823?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/c2216e029d09938cf1ecef82e1cf7e435908dbe3?el=desc) will **decrease** coverage by `4.51%`.
   > The diff coverage is `77.77%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10823/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10823?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10823      +/-   ##
   ==========================================
   - Coverage   65.43%   60.91%   -4.52%     
   ==========================================
     Files         803      803              
     Lines       37930    37935       +5     
     Branches     3561     3561              
   ==========================================
   - Hits        24818    23107    -1711     
   - Misses      13008    14642    +1634     
   - Partials      104      186      +82     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `61.59% <ø> (+<0.01%)` | :arrow_up: |
   | #python | `60.51% <77.77%> (-0.48%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10823?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/components/TableSelector.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10823/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVTZWxlY3Rvci5qc3g=) | `79.08% <ø> (-5.89%)` | :arrow_down: |
   | [...erset-frontend/src/datasource/DatasourceEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10823/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvRGF0YXNvdXJjZUVkaXRvci5qc3g=) | `69.94% <ø> (-2.74%)` | :arrow_down: |
   | [superset/connectors/sqla/views.py](https://codecov.io/gh/apache/incubator-superset/pull/10823/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL3ZpZXdzLnB5) | `67.28% <ø> (ø)` | |
   | [superset/connectors/base/views.py](https://codecov.io/gh/apache/incubator-superset/pull/10823/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL3ZpZXdzLnB5) | `71.42% <66.66%> (-3.58%)` | :arrow_down: |
   | [superset/connectors/druid/views.py](https://codecov.io/gh/apache/incubator-superset/pull/10823/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC92aWV3cy5weQ==) | `69.79% <100.00%> (+0.41%)` | :arrow_up: |
   | [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10823/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10823/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10823/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10823/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10823/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [166 more](https://codecov.io/gh/apache/incubator-superset/pull/10823/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10823?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10823?src=pr&el=footer). Last update [c2216e0...368babf](https://codecov.io/gh/apache/incubator-superset/pull/10823?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter commented on pull request #10823: fix: Making the database/cluster read-only

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #10823:
URL: https://github.com/apache/incubator-superset/pull/10823#issuecomment-689884277


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10823?src=pr&el=h1) Report
   > Merging [#10823](https://codecov.io/gh/apache/incubator-superset/pull/10823?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/c2216e029d09938cf1ecef82e1cf7e435908dbe3?el=desc) will **decrease** coverage by `4.97%`.
   > The diff coverage is `77.77%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10823/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10823?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10823      +/-   ##
   ==========================================
   - Coverage   65.43%   60.46%   -4.98%     
   ==========================================
     Files         803      374     -429     
     Lines       37930    23966   -13964     
     Branches     3561        0    -3561     
   ==========================================
   - Hits        24818    14490   -10328     
   + Misses      13008     9476    -3532     
   + Partials      104        0     -104     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `60.46% <77.77%> (-0.54%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10823?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/connectors/sqla/views.py](https://codecov.io/gh/apache/incubator-superset/pull/10823/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL3ZpZXdzLnB5) | `67.28% <ø> (ø)` | |
   | [superset/connectors/base/views.py](https://codecov.io/gh/apache/incubator-superset/pull/10823/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL3ZpZXdzLnB5) | `71.42% <66.66%> (-3.58%)` | :arrow_down: |
   | [superset/connectors/druid/views.py](https://codecov.io/gh/apache/incubator-superset/pull/10823/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC92aWV3cy5weQ==) | `69.79% <100.00%> (+0.41%)` | :arrow_up: |
   | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/10823/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
   | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/10823/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
   | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/10823/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.16% <0.00%> (-12.50%)` | :arrow_down: |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/10823/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.85% <0.00%> (-2.70%)` | :arrow_down: |
   | [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/10823/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
   | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10823/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `86.66% <0.00%> (-1.39%)` | :arrow_down: |
   | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10823/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.22% <0.00%> (-0.25%)` | :arrow_down: |
   | ... and [428 more](https://codecov.io/gh/apache/incubator-superset/pull/10823/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10823?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10823?src=pr&el=footer). Last update [c2216e0...368babf](https://codecov.io/gh/apache/incubator-superset/pull/10823?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] dpgaspar commented on a change in pull request #10823: fix: Making the database/cluster read-only

Posted by GitBox <gi...@apache.org>.
dpgaspar commented on a change in pull request #10823:
URL: https://github.com/apache/incubator-superset/pull/10823#discussion_r486276012



##########
File path: superset/connectors/sqla/views.py
##########
@@ -160,7 +160,7 @@ class TableColumnInlineView(  # pylint: disable=too-many-ancestors
     add_form_extra_fields = {
         "table": QuerySelectField(
             "Table",
-            query_factory=lambda: db.session().query(models.SqlaTable),
+            query_factory=lambda: db.session.query(models.SqlaTable),

Review comment:
       nice catch!

##########
File path: superset/connectors/druid/views.py
##########
@@ -333,6 +334,16 @@ class DruidDatasourceModelView(DatasourceModelView, DeleteMixin, YamlExportMixin
         "changed_by_": _("Changed By"),
         "modified": _("Modified"),
     }
+    edit_form_extra_fields = {
+        "cluster": QuerySelectField(
+            "Cluster",
+            query_factory=lambda: db.session.query(models.DruidCluster),
+            widget=Select2Widget(extra_classes="readonly"),

Review comment:
       I'll make a patch release for FAB to make the `readonly` work again
   https://github.com/dpgaspar/Flask-AppBuilder/pull/1467
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] john-bodley merged pull request #10823: fix: Making the database/cluster read-only

Posted by GitBox <gi...@apache.org>.
john-bodley merged pull request #10823:
URL: https://github.com/apache/incubator-superset/pull/10823


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org