[GitHub] [iceberg] rdblue commented on a change in pull request #3049: API: add snapshot encryption key metadata

[GitBox <gi...@apache.org>]

rdblue commented on a change in pull request #3049:
URL: https://github.com/apache/iceberg/pull/3049#discussion_r712288973



##########
File path: api/src/main/java/org/apache/iceberg/Snapshot.java
##########
@@ -135,4 +136,20 @@
   default Integer schemaId() {
     return null;
   }
+
+  /**
+   * Returns the location of the manifest list's encryption key metadata file location,
+   * or null if there is no key metadata.
+   */
+  default String keyMetadataLocation() {
+    return null;
+  }
+
+  /**
+   * Returns metadata about how the manifest list in the snapshot is encrypted,
+   * or null if the file is stored in plain text.
+   */
+  default ByteBuffer keyMetadata() {

Review comment:
       What is the relationship between `keyMetadataLocation` and `keyMetadata`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org