[incubator-druid] branch master updated: Fix LookupSerdeModule double-binding in Coordinator-as-Overlord mode. (#7765)

[gi...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

gian pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-druid.git


The following commit(s) were added to refs/heads/master by this push:
     new cf09fbf  Fix LookupSerdeModule double-binding in Coordinator-as-Overlord mode. (#7765)
cf09fbf is described below

commit cf09fbf4ce54443c78a40f529b124423ed1c5443
Author: Gian Merlino <gi...@imply.io>
AuthorDate: Sun May 26 15:14:50 2019 -0700

    Fix LookupSerdeModule double-binding in Coordinator-as-Overlord mode. (#7765)
    
    Fixes #7762.
---
 services/src/main/java/org/apache/druid/cli/CliCoordinator.java | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/services/src/main/java/org/apache/druid/cli/CliCoordinator.java b/services/src/main/java/org/apache/druid/cli/CliCoordinator.java
index c1ab5b9..98bb958 100644
--- a/services/src/main/java/org/apache/druid/cli/CliCoordinator.java
+++ b/services/src/main/java/org/apache/druid/cli/CliCoordinator.java
@@ -272,10 +272,12 @@ public class CliCoordinator extends ServerRunnable
         }
     );
 
-    modules.add(new LookupSerdeModule());
-
     if (beOverlord) {
       modules.addAll(new CliOverlord().getModules(false));
+    } else {
+      // Only add LookupSerdeModule if !beOverlord, since CliOverlord includes it, and having two copies causes
+      // the injector to get confused due to having multiple bindings for the same classes.
+      modules.add(new LookupSerdeModule());
     }
 
     return modules;


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org