You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kyuubi.apache.org by GitBox <gi...@apache.org> on 2021/10/08 10:28:19 UTC
[GitHub] [incubator-kyuubi] ulysses-you opened a new pull request #1195: [KYUUBI #937] Add push docker image workflow
ulysses-you opened a new pull request #1195:
URL: https://github.com/apache/incubator-kyuubi/pull/1195
<!--
Thanks for sending a pull request!
Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/contributions.html
2. If the PR is related to an issue in https://github.com/apache/incubator-kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
-->
### _Why are the changes needed?_
<!--
Please clarify why the changes are needed. For instance,
1. If you add a feature, you can talk about the use case of it.
2. If you fix a bug, you can clarify why it is a bug.
-->
Every commit for master branch, we can build and push docker image automatically to docker hub.
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [ ] [Run test](https://kyuubi.readthedocs.io/en/latest/develop_tools/testing.html#running-tests) locally before make a pull request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] ulysses-you commented on pull request #1195: [KYUUBI #937] Add push docker image workflow
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on pull request #1195:
URL: https://github.com/apache/incubator-kyuubi/pull/1195#issuecomment-938553927
cc @yaooqinn @pan3793 @cfmcgrady
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] cfmcgrady commented on a change in pull request #1195: [KYUUBI #937] Add push docker image workflow
Posted by GitBox <gi...@apache.org>.
cfmcgrady commented on a change in pull request #1195:
URL: https://github.com/apache/incubator-kyuubi/pull/1195#discussion_r724948718
##########
File path: .github/workflows/docker-image.yml
##########
@@ -0,0 +1,29 @@
+name: Publish Docker image
+
+on:
+ push:
+ branches:
+ - master
+
+jobs:
+ push_to_registry:
+ name: Push Docker image to Docker Hub
+ runs-on: ubuntu-latest
+ concurrency:
+ # this group should be global unique
+ group: push-docker-image
+ cancel-in-progress: true
+ steps:
+ - name: Checkout
+ uses: actions/checkout@v2
+ - name: Login to Docker Hub
+ uses: docker/login-action@v1
+ with:
+ username: ${{ secrets.DOCKERHUB_USER }}
+ password: ${{ secrets.DOCKERHUB_TOKEN }}
+ - name: Build Kyuubi Docker Image
+ run: docker build --tag apache/kyuubi:master-snapshot --file docker/Dockerfile .
Review comment:
Where can we find the git commit id for this build? Shall we set the git commit id as an environment variable directly? I think it's useful for debugging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] ulysses-you commented on a change in pull request #1195: [KYUUBI #937] Add push docker image workflow
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on a change in pull request #1195:
URL: https://github.com/apache/incubator-kyuubi/pull/1195#discussion_r725409781
##########
File path: .github/workflows/docker-image.yml
##########
@@ -0,0 +1,29 @@
+name: Publish Docker image
+
+on:
+ push:
+ branches:
+ - master
+
+jobs:
+ push_to_registry:
+ name: Push Docker image to Docker Hub
+ runs-on: ubuntu-latest
+ concurrency:
+ # this group should be global unique
+ group: push-docker-image
+ cancel-in-progress: true
+ steps:
+ - name: Checkout
+ uses: actions/checkout@v2
+ - name: Login to Docker Hub
+ uses: docker/login-action@v1
+ with:
+ username: ${{ secrets.DOCKERHUB_USER }}
+ password: ${{ secrets.DOCKERHUB_TOKEN }}
+ - name: Build Kyuubi Docker Image
+ run: docker build --tag apache/kyuubi:master-snapshot --file docker/Dockerfile .
Review comment:
yeah, it's what this PR wants to do
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] ulysses-you commented on pull request #1195: [KYUUBI #937] Add push docker image workflow
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on pull request #1195:
URL: https://github.com/apache/incubator-kyuubi/pull/1195#issuecomment-939204854
thanks for review, merging to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on a change in pull request #1195: [KYUUBI #937] Add push docker image workflow
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #1195:
URL: https://github.com/apache/incubator-kyuubi/pull/1195#discussion_r725415228
##########
File path: .github/workflows/docker-image.yml
##########
@@ -0,0 +1,29 @@
+name: Publish Docker image
+
+on:
+ push:
+ branches:
+ - master
+
+jobs:
+ push_to_registry:
+ name: Push Docker image to Docker Hub
+ runs-on: ubuntu-latest
Review comment:
runs-on: ubuntu-20.04
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] cfmcgrady commented on a change in pull request #1195: [KYUUBI #937] Add push docker image workflow
Posted by GitBox <gi...@apache.org>.
cfmcgrady commented on a change in pull request #1195:
URL: https://github.com/apache/incubator-kyuubi/pull/1195#discussion_r725093054
##########
File path: .github/workflows/docker-image.yml
##########
@@ -0,0 +1,29 @@
+name: Publish Docker image
+
+on:
+ push:
+ branches:
+ - master
+
+jobs:
+ push_to_registry:
+ name: Push Docker image to Docker Hub
+ runs-on: ubuntu-latest
+ concurrency:
+ # this group should be global unique
+ group: push-docker-image
+ cancel-in-progress: true
+ steps:
+ - name: Checkout
+ uses: actions/checkout@v2
+ - name: Login to Docker Hub
+ uses: docker/login-action@v1
+ with:
+ username: ${{ secrets.DOCKERHUB_USER }}
+ password: ${{ secrets.DOCKERHUB_TOKEN }}
+ - name: Build Kyuubi Docker Image
+ run: docker build --tag apache/kyuubi:master-snapshot --file docker/Dockerfile .
Review comment:
> it's always latest.
SGTM. We can find the latest image in https://hub.docker.com/r/apache/kyuubi/tags.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter commented on pull request #1195: [KYUUBI #937] Add push docker image workflow
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1195:
URL: https://github.com/apache/incubator-kyuubi/pull/1195#issuecomment-938553564
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1195?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1195](https://codecov.io/gh/apache/incubator-kyuubi/pull/1195?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8f8deca) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/464fdf456bdcaa9fd65d6965926bf32809eecfad?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (464fdf4) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/1195?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1195 +/- ##
=========================================
Coverage 78.67% 78.67%
Complexity 93 93
=========================================
Files 182 182
Lines 6734 6734
Branches 797 797
=========================================
Hits 5298 5298
Misses 980 980
Partials 456 456
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1195?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1195?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [464fdf4...8f8deca](https://codecov.io/gh/apache/incubator-kyuubi/pull/1195?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] ulysses-you closed pull request #1195: [KYUUBI #937] Add push docker image workflow
Posted by GitBox <gi...@apache.org>.
ulysses-you closed pull request #1195:
URL: https://github.com/apache/incubator-kyuubi/pull/1195
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] ulysses-you commented on a change in pull request #1195: [KYUUBI #937] Add push docker image workflow
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on a change in pull request #1195:
URL: https://github.com/apache/incubator-kyuubi/pull/1195#discussion_r724970655
##########
File path: .github/workflows/docker-image.yml
##########
@@ -0,0 +1,29 @@
+name: Publish Docker image
+
+on:
+ push:
+ branches:
+ - master
+
+jobs:
+ push_to_registry:
+ name: Push Docker image to Docker Hub
+ runs-on: ubuntu-latest
+ concurrency:
+ # this group should be global unique
+ group: push-docker-image
+ cancel-in-progress: true
+ steps:
+ - name: Checkout
+ uses: actions/checkout@v2
+ - name: Login to Docker Hub
+ uses: docker/login-action@v1
+ with:
+ username: ${{ secrets.DOCKERHUB_USER }}
+ password: ${{ secrets.DOCKERHUB_TOKEN }}
+ - name: Build Kyuubi Docker Image
+ run: docker build --tag apache/kyuubi:master-snapshot --file docker/Dockerfile .
Review comment:
Every merged commit will build and push the image so it's always latest. If we want to find the git commit id of image, we can read the `RELEASE` file in `KYUUBI_HOME`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org