You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Eric Brown (JIRA)" <ji...@codehaus.org> on 2007/02/17 22:41:10 UTC

[jira] Updated: (MNG-1412) dependency sorting in classpath

     [ http://jira.codehaus.org/browse/MNG-1412?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eric Brown updated MNG-1412:
----------------------------

    Attachment: MNG-1412-maven-2.0.x-r507746.patch

Note that r430569 (committed into 2.0.5) does fix some of the related issues here.

In fact, I'm not even completely clear on all the changes proposed in Marten's patches other than that they can't break things (just using Linked versions of HashMap and HashSet) and common-sense dictates they make sense in several places. My strong vote would be to commit this patch as I don't see anyway it could break anything. Tests would be nice, but given the random nature of items returned from non-Linked HashSet and HashMap collections, it is hard to validate that the tests would fail without these changes. Tests would be nice in the future to ensure things don't break again.

This is an update of the patches Marten submitted against the maven-2.0.x post 2.0.5. I've removed a few changes where maps and sets were never converted collections or passed outside their local scope. Plus r430569 shrinks it a bit too. Hopefully that makes it smaller and easier to code review.

Thanks to Marten for the initial work on these patches.

> dependency sorting in classpath
> -------------------------------
>
>                 Key: MNG-1412
>                 URL: http://jira.codehaus.org/browse/MNG-1412
>             Project: Maven 2
>          Issue Type: Bug
>    Affects Versions: 2.0
>            Reporter: Mark Hobson
>         Assigned To: fabrizio giustina
>             Fix For: 2.1.x
>
>         Attachments: artifact-order_maven-artifact-manager.txt, artifact-order_maven-artifact.txt, artifact-order_maven-project.txt, MNG-1412-maven-2.0.x-r507746.patch
>
>
> The .classpath file entries should be ordered by nearest transitiveness (if that's a word).
> For example, I have project A that depends on B that depends on C.  The classpath for A is generated in the order C, B.  Ideally the classpath should be in order of how near they are to the project, i.e. B, C.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira