You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by "Santhosh Srinivasan (JIRA)" <ji...@apache.org> on 2009/02/19 20:50:01 UTC
[jira] Created: (PIG-684) outputSchema method in TOKENIZE is broken
outputSchema method in TOKENIZE is broken
-----------------------------------------
Key: PIG-684
URL: https://issues.apache.org/jira/browse/PIG-684
Project: Pig
Issue Type: Bug
Components: impl
Affects Versions: types_branch
Reporter: Santhosh Srinivasan
Assignee: Thejas M Nair
Fix For: types_branch
The outputSchema method in TOKENIZE is broken. It should return a bag with a tuple that contains a string and not just a string.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-684) outputSchema method in TOKENIZE is broken
Posted by "Santhosh Srinivasan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-684?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Santhosh Srinivasan updated PIG-684:
------------------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
Patch has been committed. Thanks for the fix Tejas.
> outputSchema method in TOKENIZE is broken
> -----------------------------------------
>
> Key: PIG-684
> URL: https://issues.apache.org/jira/browse/PIG-684
> Project: Pig
> Issue Type: Bug
> Components: impl
> Affects Versions: types_branch
> Reporter: Santhosh Srinivasan
> Assignee: Thejas M Nair
> Fix For: types_branch
>
> Attachments: PIG-684.txt
>
>
> The outputSchema method in TOKENIZE is broken. It should return a bag with a tuple that contains a string and not just a string.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-684) outputSchema method in TOKENIZE is broken
Posted by "Thejas M Nair (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-684?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Thejas M Nair updated PIG-684:
------------------------------
Attachment: PIG-684.txt
TOKENIZE creates correct schema. Added unit test case.
> outputSchema method in TOKENIZE is broken
> -----------------------------------------
>
> Key: PIG-684
> URL: https://issues.apache.org/jira/browse/PIG-684
> Project: Pig
> Issue Type: Bug
> Components: impl
> Affects Versions: types_branch
> Reporter: Santhosh Srinivasan
> Assignee: Thejas M Nair
> Fix For: types_branch
>
> Attachments: PIG-684.txt
>
>
> The outputSchema method in TOKENIZE is broken. It should return a bag with a tuple that contains a string and not just a string.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-684) outputSchema method in TOKENIZE is broken
Posted by "Thejas M Nair (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-684?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Thejas M Nair updated PIG-684:
------------------------------
Attachment: (was: PIG-684.txt)
> outputSchema method in TOKENIZE is broken
> -----------------------------------------
>
> Key: PIG-684
> URL: https://issues.apache.org/jira/browse/PIG-684
> Project: Pig
> Issue Type: Bug
> Components: impl
> Affects Versions: types_branch
> Reporter: Santhosh Srinivasan
> Assignee: Thejas M Nair
> Fix For: types_branch
>
>
> The outputSchema method in TOKENIZE is broken. It should return a bag with a tuple that contains a string and not just a string.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-684) outputSchema method in TOKENIZE is
broken
Posted by "Santhosh Srinivasan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12678148#action_12678148 ]
Santhosh Srinivasan commented on PIG-684:
-----------------------------------------
Review Comment:
Index: src/org/apache/pig/builtin/TOKENIZE.java
======================================
The RuntimeException should have a reasonable error message. Otherwise it make it hard for users and developers to make sense of the exception. There are two possible options:
1. Include an appropriate message (preferred)
OR
2. return a NULL schema.
{code}
+ // throwing RTE because
+ //above schema creation is not expected to throw an exception
+ // and also because superclass does not throw exception
+ throw new RuntimeException();
{code}
> outputSchema method in TOKENIZE is broken
> -----------------------------------------
>
> Key: PIG-684
> URL: https://issues.apache.org/jira/browse/PIG-684
> Project: Pig
> Issue Type: Bug
> Components: impl
> Affects Versions: types_branch
> Reporter: Santhosh Srinivasan
> Assignee: Thejas M Nair
> Fix For: types_branch
>
> Attachments: PIG-684.txt
>
>
> The outputSchema method in TOKENIZE is broken. It should return a bag with a tuple that contains a string and not just a string.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-684) outputSchema method in TOKENIZE is
broken
Posted by "Santhosh Srinivasan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12678145#action_12678145 ]
Santhosh Srinivasan commented on PIG-684:
-----------------------------------------
I am reviewing this patch
> outputSchema method in TOKENIZE is broken
> -----------------------------------------
>
> Key: PIG-684
> URL: https://issues.apache.org/jira/browse/PIG-684
> Project: Pig
> Issue Type: Bug
> Components: impl
> Affects Versions: types_branch
> Reporter: Santhosh Srinivasan
> Assignee: Thejas M Nair
> Fix For: types_branch
>
> Attachments: PIG-684.txt
>
>
> The outputSchema method in TOKENIZE is broken. It should return a bag with a tuple that contains a string and not just a string.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-684) outputSchema method in TOKENIZE is broken
Posted by "Thejas M Nair (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-684?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Thejas M Nair updated PIG-684:
------------------------------
Patch Info: [Patch Available]
> outputSchema method in TOKENIZE is broken
> -----------------------------------------
>
> Key: PIG-684
> URL: https://issues.apache.org/jira/browse/PIG-684
> Project: Pig
> Issue Type: Bug
> Components: impl
> Affects Versions: types_branch
> Reporter: Santhosh Srinivasan
> Assignee: Thejas M Nair
> Fix For: types_branch
>
> Attachments: PIG-684.txt
>
>
> The outputSchema method in TOKENIZE is broken. It should return a bag with a tuple that contains a string and not just a string.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-684) outputSchema method in TOKENIZE is broken
Posted by "Thejas M Nair (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-684?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Thejas M Nair updated PIG-684:
------------------------------
Attachment: PIG-684.txt
Updated patch.
(Patch updated to add bagSchema.setTwoLevelAccessRequired(true); in TOKENIZE.java to handle the use of flatten(TOKENIZE(..)) )
> outputSchema method in TOKENIZE is broken
> -----------------------------------------
>
> Key: PIG-684
> URL: https://issues.apache.org/jira/browse/PIG-684
> Project: Pig
> Issue Type: Bug
> Components: impl
> Affects Versions: types_branch
> Reporter: Santhosh Srinivasan
> Assignee: Thejas M Nair
> Fix For: types_branch
>
> Attachments: PIG-684.txt
>
>
> The outputSchema method in TOKENIZE is broken. It should return a bag with a tuple that contains a string and not just a string.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-684) outputSchema method in TOKENIZE is broken
Posted by "Olga Natkovich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-684?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Olga Natkovich updated PIG-684:
-------------------------------
Status: Patch Available (was: Open)
submitting on behalf ot Tejas
> outputSchema method in TOKENIZE is broken
> -----------------------------------------
>
> Key: PIG-684
> URL: https://issues.apache.org/jira/browse/PIG-684
> Project: Pig
> Issue Type: Bug
> Components: impl
> Affects Versions: types_branch
> Reporter: Santhosh Srinivasan
> Assignee: Thejas M Nair
> Fix For: types_branch
>
> Attachments: PIG-684.txt
>
>
> The outputSchema method in TOKENIZE is broken. It should return a bag with a tuple that contains a string and not just a string.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.