You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/04/24 17:26:58 UTC
[GitHub] [incubator-nuttx] v01d opened a new pull request #867: Fix use of undefined CONFIG_STM32L4_LPTIM1_CH1POL
v01d opened a new pull request #867:
URL: https://github.com/apache/incubator-nuttx/pull/867
For LPTIM setting polarity is not yet supported but for LPTIM1 this was not considered and an thus an undefined config option was used.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] v01d commented on pull request #867: Fix use of undefined CONFIG_STM32L4_LPTIM1_CH1POL
Posted by GitBox <gi...@apache.org>.
v01d commented on pull request #867:
URL: https://github.com/apache/incubator-nuttx/pull/867#issuecomment-619162171
Ok, did that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] v01d commented on pull request #867: Fix use of undefined CONFIG_STM32L4_LPTIM1_CH1POL
Posted by GitBox <gi...@apache.org>.
v01d commented on pull request #867:
URL: https://github.com/apache/incubator-nuttx/pull/867#issuecomment-619152598
Added some changes to fix styling problems (outside of the lines I changed). Fixed all but one since it is the prototype of the function with only one parameter which is exactly 78 chars long. What should I do to fix that?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] patacongo commented on pull request #867: Fix use of undefined CONFIG_STM32L4_LPTIM1_CH1POL
Posted by GitBox <gi...@apache.org>.
patacongo commented on pull request #867:
URL: https://github.com/apache/incubator-nuttx/pull/867#issuecomment-619155431
>
>
> Added some changes to fix styling problems (outside of the lines I changed). Fixed all but one since it is the prototype of the function with only one parameter which is exactly 78 chars long. What should I do to fix that?
I divide those this way. BEFORE:
static uint16_t pwm_outputs_from_channels(FAR struct stm32l4_pwmtimer_s *priv)
AFTER:
static uint16_t
pwm_outputs_from_channels(FAR struct stm32l4_pwmtimer_s *priv)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org