[GitHub] [iceberg] rdblue commented on a change in pull request #3400: Spark: Support dynamic partition filtering in 3.2

[GitBox <gi...@apache.org>]

rdblue commented on a change in pull request #3400:
URL: https://github.com/apache/iceberg/pull/3400#discussion_r739471348



##########
File path: spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/SparkConfParser.java
##########
@@ -34,7 +35,8 @@
   private final Map<String, String> options;
 
   SparkConfParser(SparkSession spark, Table table, Map<String, String> options) {
-    this.properties = table.properties();
+    // use table ops as metadata tables have empty properties
+    this.properties = ((HasTableOperations) table).operations().current().properties();

Review comment:
       I liked what was there before so it was the responsibility of metadata tables to report their properties. I don't like avoiding our own API.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org