You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ofbiz.apache.org by "Jacques Le Roux (JIRA)" <ji...@apache.org> on 2018/08/20 16:53:00 UTC
[jira] [Commented] (OFBIZ-9241) Removes ecommerce links from
applications
[ https://issues.apache.org/jira/browse/OFBIZ-9241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16586208#comment-16586208 ]
Jacques Le Roux commented on OFBIZ-9241:
----------------------------------------
To clarify, here is the complete list of ecommerce links in framework only code. To simplify I removed those which are commented out or not code (in README, etc.)
{noformat}
ofbiz-framework
applications
accounting
config
payment.properties (5 matches)
426: merchantReturnURL=https://localhost:8443/ecommerce/control/idealNotify
paymentTest.properties (2 matches)
82: merchantReturnURL=https://localhost:8443/ecommerce/control/idealNotify
commonext
minilang
setup
SetupEvents.xml
490: <set field="createPromotionCategoryCtx.detailScreen" value="component://ecommerce/widget/CatalogScreens.xml#categorydetailmatrix"/>
content
webapp
content
WEB-INF
controller.xml (5 matches)
1 973: <view-map name="RespondBlog" type="screen" page="component://ecommerce/widget/blog/BlogScreens.xml#AddBlogResponse"/>
1 974: <view-map name="EditBlogText" type="screen" page="component://ecommerce/widget/blog/BlogScreens.xml#EditBlogResponse"/>
1 975: <view-map name="EditBlogImage" type="screen" page="component://ecommerce/widget/blog/BlogScreens.xml#EditBlogResponse"/>
1 976: <view-map name="EditBlogResponse" type="screen" page="component://ecommerce/widget/blog/BlogScreens.xml#EditBlogResponse"/>
1 977: <view-map name="LatestResponses" type="screen" page="component://ecommerce/widget/blog/BlogScreens.xml#LatestResponses"/>
datamodel
data
demo
ContentDemoData.xml
222: ... o="plugins/ecommerce/data/cutekid.jpg" isPublic="Y" createdDate="2007-01-23 16:46:22.843" createdByUserLogin="bigal" lastModifiedDate="2007-01-23 1 ...
OrderDemoData.xml (22 matches)
240: ... omponent://ecommerce/widget/Ema ... omponent://ecommerce/widget/EmailOrderScreens.xml#OrderConfirmNoticePdf" subject="OFBiz Demo - Order Confirmati ...
241: ... omponent://ecommerce/widget/EmailOrderScreens.xml#OrderCompleteNotice" subject="OFBiz Demo - Your Order Is Complete #${orderId}" fromAddress="ofbiz ...
242: ... omponent://ecommerce/widget/EmailOrderScreens.xml#BackorderNotice" subject="OFBiz Demo - Backorder Notification #${orderId}" fromAddress="ofbiztest ...
243: ... omponent://ecommerce/widget/EmailOrderScreens.xml#OrderChangeNotice" subject="OFBiz Demo - Order Change Notification #${orderId}" fromAddress="ofbi ...
244: ... omponent://ecommerce/widget/EmailOrderScreens.xml#PaymentRetryNotice" subject="OFBiz Demo - Order Payment Notification #${orderId}" fromAddress="of ...
245: ... omponent://ecommerce/widget/EmailOrderScreens.xml#ShipmentCompleteNotice" subject="OFBiz Demo - Shipment Complete Notification #${orderId}" fromAdd ...
247: ... omponent://ecommerce/widget/EmailReturnScreens.xml#ReturnAccept" subject="OFBiz Demo - Return Accepted #${returnHeader.returnId}" xslfoAttachScreen ...
248: ... omponent://ecommerce/widget/EmailReturnScreens.xml#ReturnComplete" subject="OFBiz Demo - Return Completed #${returnHeader.returnId}" xslfoAttachScr ...
249: ... omponent://ecommerce/widget/EmailReturnScreens.xml#ReturnCancel" subject="OFBiz Demo - Return Cancelled #${returnHeader.returnId}" xslfoAttachScree ...
251: <ProductStoreEmailSetting productStoreId="9000" emailType="PRDS_GC_PURCHASE" bodyScreenLocation="component://ecommerce/widget/EmailGiftCardScreens.xml#GiftCardPurchase" fromAddress="ofbiztest@example.com" subject="A Gift From ${senderName}!"/>
252: <ProductStoreEmailSetting productStoreId="9000" emailType="PRDS_GC_RELOAD" bodyScreenLocation="component://ecommerce/widget/EmailGiftCardScreens.xml#GiftCardReload" fromAddress="ofbiztest@example.com" subject="Gift Card Reload Results"/>
254: <ProductStoreEmailSetting productStoreId="9000" emailType="PRDS_TELL_FRIEND" bodyScreenLocation="component://ecommerce/widget/EmailProductScreens.xml#TellFriend" subject="${sendFrom} has sent you a link!" fromAddress="ofbiztest@example.com"/>
266: ... omponent://ecommerce/widget/EmailContactListScreens.xml#ContactUsEmailNotification" subject="Contact-us Information Notification" fromAddress="ofbi ...
268: ... omponent://ecommerce/widget/EmailContactListScreens.xml#ContactListSubscribeEmail" subject="Subscribe Contact List" fromAddress="ofbiztest@example. ...
269: ... omponent://ecommerce/widget/EmailContactListScreens.xml#ContactListUnsubscribeVerifyEmail" subject="Verify Unsubscribe Contact List" fromAddress="o ...
270: ... omponent://ecommerce/widget/EmailContactListScreens.xml#ContactListUnsubscribeEmail" subject="Unsubscribe Contact List" fromAddress="ofbiztest@exam ...
271: <ProductStoreEmailSetting productStoreId="9000" emailType="CONT_EMAIL_TEMPLATE" bodyScreenLocation="component://ecommerce/widget/EmailContactListScreens.xml#ContactListEmailTemplate"/>
308: <ProductCategory productCategoryId="PROMOTIONS" productCategoryTypeId="CATALOG_CATEGORY" detailScreen="component://ecommerce/widget/CatalogScreens.xml#categorydetailmatrix"/>
1 307: <promoText><![CDATA[Spend more than $100 on your favorite widgets and gizmos and get a free <a href="/ecommerce/control/product?category_id=20111&product_id=WG-1111">Micro Chrome Widget</a>!]]></promoText>
1 317: <promoText><![CDATA[Buy $50 of your favorite gizmos (all products in Gizmo [100] or sub-category) get a free <a href="/ecommerce/control/product?category_id=20111&product_id=GZ-1006">Open Gizmo</a>! Limit 2 per order.]]></promoText>
1 320: <promoText><![CDATA[Spend more than $150 on your favorite gizmos (all products in Gizmo [100] or sub-category) and get a free <a href="/ecommerce/control/product?category_id=20111&product_id=GZ-1006">Open Gizmo</a>!]]></promoText>
seed
ContentSeedData.xml (6 matches)
1 663: ... Date="2004-01-16 01:24:06.522" lastModifiedDate="2004-01-16 19:20:58.891" objectInfo="component://ecommerce/widget/blog/BlogTemplates.xml#FloatLeft"/>
1 664: ... Date="2004-01-16 01:24:06.522" lastModifiedDate="2004-01-16 19:20:58.891" objectInfo="component://ecommerce/widget/blog/BlogTemplates.xml#TopCenter"/>
1 666: ... 2004-01-16 01:24:06.522" lastModifiedDate="2004-01-16 19:20:58.891" objectInfo="component://ecommerce/widget/CommonScreens.xml#CommonEmptyDecorator"/>
1 667: ... "2004-01-16 01:24:06.522" lastModifiedDate="2004-01-16 19:20:58.891" objectInfo="component://ecommerce/widget/CommonScreens.xml#CommonLeftDecorator"/>
1 668: ... 2004-01-16 01:24:06.522" lastModifiedDate="2004-01-16 19:20:58.891" objectInfo="component://ecommerce/widget/CommonScreens.xml#CommonRightDecorator"/>
1 669: ... -01-16 01:24:06.522" lastModifiedDate="2004-01-16 19:20:58.891" objectInfo="component://ecommerce/widget/CommonScreens.xml#CommonLeftRightDecorator"/>
order
template
order
EditOrderItems.ftl
108: <a href="/ecommerce/control/product?product_id=${productId}" class="buttontext" target="_blank">${uiLabelMap.OrderEcommerce}</a>
OrderItems.ftl
91: <a href="/ecommerce/control/product?product_id=${productId}" class="buttontext" target="_blank">${uiLabelMap.OrderEcommerce}</a>
testdef
data
OrderTestData.xml (2 matches)
30: ... omponent://ecommerce/widget/Ema ... omponent://ecommerce/widget/EmailOrderScreens.xml#OrderConfirmNoticePdf" subject="OFBiz Demo - Order Confirmati ...
product
config
ProductUiLabels.xml (7 matches)
16 529: <value xml:lang="de">Besipiel: component://ecommerce/widget/CatalogScreens.xml#categorydetail</value>
16 530: <value xml:lang="en">example: component://ecommerce/widget/CatalogScreens.xml#categorydetail</value>
16 531: <value xml:lang="it">esempio: component://ecommerce/widget/CatalogScreens.xml#categorydetail</value>
16 532: <value xml:lang="ja">?: component://ecommerce/widget/CatalogScreens.xml#categorydetail</value>
16 533: <value xml:lang="vi">ví d?: thành ph?n://ecommerce/widget/CatalogScreens.xml#categorydetail</value>
16 534: <value xml:lang="zh">??: component://ecommerce/widget/CatalogScreens.xml#categorydetail</value>
16 535: <value xml:lang="zh-TW">??: component://ecommerce/widget/CatalogScreens.xml#categorydetail</value>
src
main
java
org
apache
ofbiz
product
product
ProductEvents.java
978: String defaultScreenLocation = "component://ecommerce/widget/EmailProductScreens.xml#TellFriend";
store
ProductStoreWorker.java (11 matches)
61: defaultProductStoreEmailScreenLocation.put("PRDS_ODR_CONFIRM", "component://ecommerce/widget/EmailOrderScreens.xml#OrderConfirmNotice");
62: defaultProductStoreEmailScreenLocation.put("PRDS_ODR_COMPLETE", "component://ecommerce/widget/EmailOrderScreens.xml#OrderCompleteNotice");
63: defaultProductStoreEmailScreenLocation.put("PRDS_ODR_BACKORDER", "component://ecommerce/widget/EmailOrderScreens.xml#BackorderNotice");
64: defaultProductStoreEmailScreenLocation.put("PRDS_ODR_CHANGE", "component://ecommerce/widget/EmailOrderScreens.xml#OrderChangeNotice");
66: defaultProductStoreEmailScreenLocation.put("PRDS_ODR_PAYRETRY", "component://ecommerce/widget/EmailOrderScreens.xml#PaymentRetryNotice");
68: defaultProductStoreEmailScreenLocation.put("PRDS_RTN_ACCEPT", "component://ecommerce/widget/EmailReturnScreens.xml#ReturnAccept");
69: defaultProductStoreEmailScreenLocation.put("PRDS_RTN_COMPLETE", "component://ecommerce/widget/EmailReturnScreens.xml#ReturnComplete");
70: defaultProductStoreEmailScreenLocation.put("PRDS_RTN_CANCEL", "component://ecommerce/widget/EmailReturnScreens.xml#ReturnCancel");
72: defaultProductStoreEmailScreenLocation.put("PRDS_GC_PURCHASE", "component://ecommerce/widget/EmailGiftCardScreens.xml#GiftCardPurchase");
73: defaultProductStoreEmailScreenLocation.put("PRDS_GC_RELOAD", "component://ecommerce/widget/EmailGiftCardScreens.xml#GiftCardReload");
79: defaultProductStoreEmailScreenLocation.put("PRDS_TELL_FRIEND", "component://ecommerce/widget/EmailProductScreens.xml#TellFriend");
template
category
EditCategory.ftl
186: <br /><span class="tooltip">${uiLabelMap.ProductDefaultsTo} "categorydetail", ${uiLabelMap.ProductDetailScreenMessage}: "component://ecommerce/widget/CatalogScreens.xml#categorydetail"</span>
EditCategoryContent.ftl
63: <span class="tooltip">${uiLabelMap.ProductDefaultsTo} "categorydetail", ${uiLabelMap.ProductDetailScreenMessage}: "component://ecommerce/widget/CatalogScreens.xml#categorydetail"</span>
product
EditProductContent.ftl
70: ... tail", ${uiLabelMap.ProductDetailScreenMessage}: "component://ecommerce/widget/CatalogScreens.xml#productdetail"</span>
EditProductQuickAdmin.ftl
54: window.open('/ecommerce/control/product?product_id=${productId!}');
widget
catalog
CatalogMenus.xml (2 matches)
182: <link target="/ecommerce/control/category" url-mode="plain">
551: <link target="/ecommerce/control/product" url-mode="inter-app">
ProductScreens.xml
918: ... tityUtilProperties.getPropertyValue('ecommerce', 'janrain.enabled', 'absent', delegator)) '/ecommerce/images/productAdditionalView.js'}"/>
{noformat}
> Removes ecommerce links from applications
> -----------------------------------------
>
> Key: OFBIZ-9241
> URL: https://issues.apache.org/jira/browse/OFBIZ-9241
> Project: OFBiz
> Issue Type: Sub-task
> Components: ALL APPLICATIONS
> Affects Versions: Trunk
> Reporter: Jacques Le Roux
> Assignee: Jacques Le Roux
> Priority: Major
> Fix For: 17.12.01
>
>
> While working on OFBIZ-9206 I remembered how the ecommerce webapp is deeply entrenched in some applications components. This can at least be tested with product and catalog webapp.
> # Get to catalog/control/EditProduct?productId=GZ-1000
> # Click on the "Product Page" button => ecommerce
> There are much more cases (96 occurrences actually) but most of them are not hard dependencies.
> Since the ecommerce component is now a plugin, we need to remove all ecommerce links from applications, I even wonder if this issue is really an improvement or should not be now considered a bug...
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)