You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/09/14 13:04:05 UTC
[GitHub] [airflow] gmsantos opened a new pull request, #26393: Bump FAB to 4.1.4
gmsantos opened a new pull request, #26393:
URL: https://github.com/apache/airflow/pull/26393
No changes that should be replicated in `airflow/www/fab_security` was found.
See https://github.com/dpgaspar/Flask-AppBuilder/compare/v4.1.3...v4.1.4
I expect that the constraints dependencies got updated to:
flask-wtf==1.0.1
wtforms==3.0.1
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #26393: Bump FAB to 4.1.4
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #26393:
URL: https://github.com/apache/airflow/pull/26393#issuecomment-1249033546
All loks good @gmsantos - seems the last teething problems solved and we should be able to upgrade pinned dependencies without any problems in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #26393: Bump FAB to 4.1.4
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #26393:
URL: https://github.com/apache/airflow/pull/26393#issuecomment-1248088612
Testing it on my own PR that I just rebased: https://github.com/apache/airflow/pull/26341
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb merged pull request #26393: Bump FAB to 4.1.4
Posted by GitBox <gi...@apache.org>.
ashb merged PR #26393:
URL: https://github.com/apache/airflow/pull/26393
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #26393: Bump FAB to 4.1.4
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #26393:
URL: https://github.com/apache/airflow/pull/26393#issuecomment-1247096211
This is actually Cool. We will test if the fix with bumping "fixed" requirements that I implemented - works. Once we merge it, new PRs should take a bit longer to build image (but they should succeed) until constraints get refreshed. Then they should come back to the usual speed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #26393: Bump FAB to 4.1.4
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #26393:
URL: https://github.com/apache/airflow/pull/26393#issuecomment-1247329595
Fix in #26407
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] gmsantos commented on pull request #26393: Bump FAB to 4.1.4
Posted by GitBox <gi...@apache.org>.
gmsantos commented on PR #26393:
URL: https://github.com/apache/airflow/pull/26393#issuecomment-1248070283
@ashb just a reminder to add this PR to the 2.4.1 milestone and to not lose it in the changelogs :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #26393: Bump FAB to 4.1.4
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #26393:
URL: https://github.com/apache/airflow/pull/26393#issuecomment-1247094363
Rebased to account for git-rev main failure :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #26393: Bump FAB to 4.1.4
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #26393:
URL: https://github.com/apache/airflow/pull/26393#issuecomment-1247330258
(alledged fix that is - I tested it locally and it worked to create the k8s venv ;) - but you never know in CI).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #26393: Bump FAB to 4.1.4
Posted by GitBox <gi...@apache.org>.
ashb commented on PR #26393:
URL: https://github.com/apache/airflow/pull/26393#issuecomment-1247767059
Targeting 2.4.1 as 2.4.0 is in feature freeze and due out today (and I don't want to test against a moving target)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #26393: Bump FAB to 4.1.4
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #26393:
URL: https://github.com/apache/airflow/pull/26393#issuecomment-1248278949
Seems it works. So I'd cautiously say ... it works :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #26393: Bump FAB to 4.1.4
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #26393:
URL: https://github.com/apache/airflow/pull/26393#issuecomment-1248140519
Looks good - the first attempt to build images failed: https://github.com/apache/airflow/actions/runs/3060753610/jobs/4940164674#step:13:185
Now it attempts to fall-back to no-constraints mode.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #26393: Bump FAB to 4.1.4
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #26393:
URL: https://github.com/apache/airflow/pull/26393#issuecomment-1247635834
Rebased it after merging the fix. :crossed_fingers: @gmsantos
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on pull request #26393: Bump FAB to 4.1.4
Posted by GitBox <gi...@apache.org>.
jedcunningham commented on PR #26393:
URL: https://github.com/apache/airflow/pull/26393#issuecomment-1258694620
(Kicking this to 2.4.2 for now until I decide if we should range FAB in this situation or wait for 2.5.0)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #26393: Bump FAB to 4.1.4
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #26393:
URL: https://github.com/apache/airflow/pull/26393#issuecomment-1248076873
I want to see the system self-regulate itself :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #26393: Bump FAB to 4.1.4
Posted by GitBox <gi...@apache.org>.
ashb commented on PR #26393:
URL: https://github.com/apache/airflow/pull/26393#issuecomment-1248148328
@potiuk The providers steps of this PR failed with version issue https://github.com/apache/airflow/actions/runs/3060640382/jobs/4939684138
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #26393: Bump FAB to 4.1.4
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #26393:
URL: https://github.com/apache/airflow/pull/26393#issuecomment-1248217126
Fix here: https://github.com/apache/airflow/pull/26420
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #26393: Bump FAB to 4.1.4
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #26393:
URL: https://github.com/apache/airflow/pull/26393#issuecomment-1248279332
https://github.com/apache/airflow/pull/26341 running :crossed_fingers:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] gmsantos commented on pull request #26393: Bump FAB to 4.1.4
Posted by GitBox <gi...@apache.org>.
gmsantos commented on PR #26393:
URL: https://github.com/apache/airflow/pull/26393#issuecomment-1247109591
Nice workflow @potiuk ! 🤞
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #26393: Bump FAB to 4.1.4
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #26393:
URL: https://github.com/apache/airflow/pull/26393#issuecomment-1247315599
> Unfortunately, this PR didn't pass the [CI step check](https://github.com/apache/airflow/blob/main/.github/workflows/ci.yml#L1635) for a canary run:
Told ya :). We are both like surgeons operating an open-heart.
Fix is coming. I will make a PR that should handle it and I will ask you to rebase it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #26393: Bump FAB to 4.1.4
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #26393:
URL: https://github.com/apache/airflow/pull/26393#issuecomment-1248189203
Yep. There is one more case to handle then.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] gmsantos commented on pull request #26393: Bump FAB to 4.1.4
Posted by GitBox <gi...@apache.org>.
gmsantos commented on PR #26393:
URL: https://github.com/apache/airflow/pull/26393#issuecomment-1249037075
Awesome! Thank you for all the hard work @potiuk !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #26393: Bump FAB to 4.1.4
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #26393:
URL: https://github.com/apache/airflow/pull/26393#issuecomment-1248076207
> @ashb just a reminder to add this PR to the 2.4.1 milestone and to not lose it in the changelogs :)
Good point. Added it.
BTw. So far so good @gmsantos ... Looks like generaly the CI builds to push cache are failing in main when constraints are used - precisely because of the conflict between FAB 4.1.3 in constraints and 4.1.4 in setup.py (this is expected):
https://github.com/apache/airflow/actions/runs/3060594649/jobs/4939314136#step:8:564
```
#53 8.655 The conflict is caused by:
#53 8.655 apache-airflow[devel-ci] 2.4.0b1 depends on flask-appbuilder==4.1.4
#53 8.655 The user requested (constraint) flask-appbuilder==4.1.3
#53 8.655
#53 8.655 To fix this you could try to:
#53 8.655 1. loosen the range of package versions you've specified
#53 8.655 2. remove package versions to allow pip attempt to solve the dependency conflict
#53 8.655
```
The constraints are not yet updated (that needs a successful canarry build).
Now let's see if regular PRs will succeed regardless (they should :))
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #26393: Bump FAB to 4.1.4
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #26393:
URL: https://github.com/apache/airflow/pull/26393#issuecomment-1247132314
> Nice workflow @potiuk ! 🤞
When we see it works, yes. I am always sceptical about those kind of changes in CI, because the only way to test them is to try them live :). So I will say it's nice, when we get confirmation that it works :).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] gmsantos commented on pull request #26393: Bump FAB to 4.1.4
Posted by GitBox <gi...@apache.org>.
gmsantos commented on PR #26393:
URL: https://github.com/apache/airflow/pull/26393#issuecomment-1247288007
Unfortunately, this PR didn't pass the [CI step check](https://github.com/apache/airflow/blob/main/.github/workflows/ci.yml#L1635) for a canary run:
https://github.com/apache/airflow/actions/runs/3054848681/jobs/4927231877#step:8:616
```
pr-labels = []
target-repo = apache/airflow
head-repo = gmsantos/airflow
pr-number = 26393
event-name = pull_request
runs-on = ubuntu-20.04
in-workflow-build = false
build-job-description = Skip Build (look in pull_request_target)
canary-run = false
run-coverage = false
```
I think it's because I opened this [PR from my fork](https://github.com/apache/airflow/blob/main/dev/breeze/src/airflow_breeze/commands/ci_commands.py#L327), and it makes sense not to try to update the constraints from a PR outside the airflow main repo :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org