You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by StephanEwen <gi...@git.apache.org> on 2016/04/01 20:38:38 UTC

[GitHub] flink pull request: FLINK-3428: Adds a fixed time trailing waterma...

Github user StephanEwen commented on the pull request:

    https://github.com/apache/flink/pull/1764#issuecomment-204508742
  
    The code looks good now.
    
      - How about we move all the convenience timestamp extractors / watermark generators into a separate packe `.functions.timestamps`?
    
    **Docs**
    I am a bit unsure about the docs. They seem to get confusing now. What is a mechanism (periodic / punctuated), what is just a convenience implementation (Ascending, BoundedOutOfOrderness).
    
    How about leaving the docs page on watermark generation as it is and add another sub-page that lists pre-defined watermark generators. We would list all the future watermark generators there:
      - ascending timestamps
      - bounded out-of-orderness
      - historgam based


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---