You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "grzegorz8 (via GitHub)" <gi...@apache.org> on 2024/11/28 10:08:11 UTC

[PR] [FLINK-36816] Support source parallelism setting for JDBC connector [flink-connector-jdbc]

grzegorz8 opened a new pull request, #148:
URL: https://github.com/apache/flink-connector-jdbc/pull/148

   # Purpose of the change
   
   Add new option `scan.parallelism` support for JDBC connector.
   
   Part of [FLINK-33261](https://issues.apache.org/jira/browse/FLINK-33261) FLIP-367: Support Setting Parallelism for Table/SQL Sources
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-36816] Support source parallelism setting for JDBC connector [flink-connector-jdbc]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #148:
URL: https://github.com/apache/flink-connector-jdbc/pull/148#issuecomment-3591042096

   This PR is being marked as stale since it has not had any activity in the last 90 days. 
   If you would like to keep this PR alive, please leave a comment asking for a review. 
   If the PR has merge conflicts, update it with the latest from the base branch.
   
   If you are having difficulty finding a reviewer, please reach out to the 
   community, contact details can be found here: https://flink.apache.org/what-is-flink/community/
   
   If this PR is no longer valid or desired, please feel free to close it. 
   If no activity occurs in the next 30 days, it will be automatically closed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-36816] Support source parallelism setting for JDBC connector [flink-connector-jdbc]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #148:
URL: https://github.com/apache/flink-connector-jdbc/pull/148#issuecomment-4095956942

   This PR is being marked as stale since it has not had any activity in the last 90 days. 
   If you would like to keep this PR alive, please leave a comment asking for a review. 
   If the PR has merge conflicts, update it with the latest from the base branch.
   
   If you are having difficulty finding a reviewer, please reach out to the 
   community, contact details can be found here: https://flink.apache.org/what-is-flink/community/
   
   If this PR is no longer valid or desired, please feel free to close it. 
   If no activity occurs in the next 30 days, it will be automatically closed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-36816] Support source parallelism setting for JDBC connector [flink-connector-jdbc]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #148: [FLINK-36816] Support source parallelism setting for JDBC connector
URL: https://github.com/apache/flink-connector-jdbc/pull/148


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-36816] Support source parallelism setting for JDBC connector [flink-connector-jdbc]

Posted by "davidradl (via GitHub)" <gi...@apache.org>.
davidradl commented on code in PR #148:
URL: https://github.com/apache/flink-connector-jdbc/pull/148#discussion_r1867893032


##########
docs/content.zh/docs/connectors/table/jdbc.md:
##########
@@ -212,6 +212,14 @@ ON myTopic.key = MyUserTable.id;
       它决定了每个语句是否在事务中自动提交。有些 JDBC 驱动程序,特别是
       <a href="https://jdbc.postgresql.org/documentation/head/query.html#query-with-cursor">Postgres</a>,可能需要将此设置为 false 以便流化结果。</td>
     </tr>
+    <tr>
+      <td><h5>scan.parallelism</h5></td>

Review Comment:
   could you add a link to some documentation for this - as there is for autocommit please.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-36816] Support source parallelism setting for JDBC connector [flink-connector-jdbc]

Posted by "grzegorz8 (via GitHub)" <gi...@apache.org>.
grzegorz8 commented on PR #148:
URL: https://github.com/apache/flink-connector-jdbc/pull/148#issuecomment-3673982379

   > Thanks @grzegorz8 for the contribution . Could you still work for this patch ?
   > 
   > If there is no response for an extended period, we will try to find other developers to continue advancing this patch. BTW, your initial contribution will be retained as a co-author in the commit message.
   > 
   > Looking forward to your back or reply!
   
   H! I'll try to rebase my PR with main soon.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-36816] Support source parallelism setting for JDBC connector [flink-connector-jdbc]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #148:
URL: https://github.com/apache/flink-connector-jdbc/pull/148#issuecomment-4275374068

   This PR has been closed since it has not had any activity in 120 days. 
   If you feel like this was a mistake, or you would like to continue working on it, 
   please feel free to re-open the PR and ask for a review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org