[GitHub] [jackrabbit-oak] stefan-egli commented on a diff in pull request #946: OAK-10250: Configurable suspend timeout

["stefan-egli (via GitHub)" <gi...@apache.org>]

stefan-egli commented on code in PR #946:
URL: https://github.com/apache/jackrabbit-oak/pull/946#discussion_r1200494995


##########
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/Configuration.java:
##########
@@ -281,4 +282,10 @@
             name = "Document Node Store Compression",
             description = "Select compressor type for collections. 'Snappy' is the default supported compression.")
     String collectionCompressionType() default "snappy";
+
+    @AttributeDefinition(
+            name = "Suspend timeout",
+            description = "Timeout for a suspended commit after it conflicted with" +
+                    "a change that is not yet visible. Default: 60000 (milliseconds).")

Review Comment:
   this hardcodes the default to 60000 in osgi metadata - could maybe also refer to DEFAULT_SUSPEND_TIMEOUT?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org