[GitHub] [spark] cloud-fan commented on a change in pull request #29567: [SPARK-32721][SQL] Simplify if clauses with null and boolean

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #29567:
URL: https://github.com/apache/spark/pull/29567#discussion_r480653280



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
##########
@@ -463,6 +463,8 @@ object SimplifyConditionals extends Rule[LogicalPlan] with PredicateHelper {
       case If(Literal(null, _), _, falseValue) => falseValue
       case If(cond, trueValue, falseValue)
         if cond.deterministic && trueValue.semanticEquals(falseValue) => trueValue
+      case If(cond, l @ Literal(null, _), FalseLiteral) if !cond.nullable => And(cond, l)

Review comment:
       what about the other way around? e.g. `case If(cond, FalseLiteral, l @ Literal(null, _))`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org