You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/11/13 09:19:28 UTC

[GitHub] [apisix] spacewander commented on a change in pull request #2676: fix: make set_more_retries() work when upstream_type is chash

spacewander commented on a change in pull request #2676:
URL: https://github.com/apache/apisix/pull/2676#discussion_r522823505



##########
File path: apisix/balancer/chash.lua
##########
@@ -55,6 +55,7 @@ end
 
 function _M.new(up_nodes, upstream)
     local str_null = str_char(0)
+    local last_server_index

Review comment:
       The `last_server_index` should be in ctx scope, not the upstream one. We should not share the same index across different requests to an upstream.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org