You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2015/09/15 20:33:55 UTC

Review Request 38408: Renamed provisioners::path to provisioner::path.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38408/
-----------------------------------------------------------

Review request for mesos, Timothy Chen and Jiang Yan Xu.


Bugs: MESOS-3432
    https://issues.apache.org/jira/browse/MESOS-3432


Repository: mesos


Description
-------

Renamed provisioners::path to provisioner::path.


Diffs
-----

  src/slave/containerizer/provisioner/appc/provisioner.cpp 77f9cbe778785bd93c30eba5dfd7a470d9258661 
  src/slave/containerizer/provisioner/paths.hpp 5b82591fbe0d1ea48e4b09727424d0547f21adc2 
  src/slave/containerizer/provisioner/paths.cpp 4293dd2fe62bd6aee9243717916c86ff9e39d9ce 
  src/slave/paths.hpp 43c65af03a6af8d3d2d50f7c8366d7fbd26cb990 
  src/slave/paths.cpp f104ecdbbb78093ccb968c0a01ea0924bfa391c5 
  src/tests/paths_tests.cpp 1ccc5c70b06f44f54d843d6ed92e9105eda40a7b 

Diff: https://reviews.apache.org/r/38408/diff/


Testing
-------

sudo make check


Thanks,

Jie Yu

Re: Review Request 38408: Renamed provisioners::path to provisioner::path.

Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38408/#review99087
-----------------------------------------------------------



src/tests/paths_tests.cpp (line 224)
<https://reviews.apache.org/r/38408/#comment155920>

    This should still be provisioners right?


- Timothy Chen


On Sept. 15, 2015, 6:51 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38408/
> -----------------------------------------------------------
> 
> (Updated Sept. 15, 2015, 6:51 p.m.)
> 
> 
> Review request for mesos, Timothy Chen and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-3432
>     https://issues.apache.org/jira/browse/MESOS-3432
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Renamed provisioners::path to provisioner::path.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/provisioner/appc/provisioner.cpp 77f9cbe778785bd93c30eba5dfd7a470d9258661 
>   src/slave/containerizer/provisioner/paths.hpp 5b82591fbe0d1ea48e4b09727424d0547f21adc2 
>   src/slave/containerizer/provisioner/paths.cpp 4293dd2fe62bd6aee9243717916c86ff9e39d9ce 
>   src/slave/paths.hpp 43c65af03a6af8d3d2d50f7c8366d7fbd26cb990 
>   src/slave/paths.cpp f104ecdbbb78093ccb968c0a01ea0924bfa391c5 
>   src/tests/paths_tests.cpp 1ccc5c70b06f44f54d843d6ed92e9105eda40a7b 
> 
> Diff: https://reviews.apache.org/r/38408/diff/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 38408: Renamed provisioners::path to provisioner::path.

Posted by Timothy Chen <tn...@apache.org>.

> On Sept. 15, 2015, 8:51 p.m., Timothy Chen wrote:
> > Ship It!

Wierd, anyway fix it and ship it :)


- Timothy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38408/#review99088
-----------------------------------------------------------


On Sept. 15, 2015, 6:51 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38408/
> -----------------------------------------------------------
> 
> (Updated Sept. 15, 2015, 6:51 p.m.)
> 
> 
> Review request for mesos, Timothy Chen and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-3432
>     https://issues.apache.org/jira/browse/MESOS-3432
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Renamed provisioners::path to provisioner::path.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/provisioner/appc/provisioner.cpp 77f9cbe778785bd93c30eba5dfd7a470d9258661 
>   src/slave/containerizer/provisioner/paths.hpp 5b82591fbe0d1ea48e4b09727424d0547f21adc2 
>   src/slave/containerizer/provisioner/paths.cpp 4293dd2fe62bd6aee9243717916c86ff9e39d9ce 
>   src/slave/paths.hpp 43c65af03a6af8d3d2d50f7c8366d7fbd26cb990 
>   src/slave/paths.cpp f104ecdbbb78093ccb968c0a01ea0924bfa391c5 
>   src/tests/paths_tests.cpp 1ccc5c70b06f44f54d843d6ed92e9105eda40a7b 
> 
> Diff: https://reviews.apache.org/r/38408/diff/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 38408: Renamed provisioners::path to provisioner::path.

Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38408/#review99088
-----------------------------------------------------------

Ship it!


Ship It!

- Timothy Chen


On Sept. 15, 2015, 6:51 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38408/
> -----------------------------------------------------------
> 
> (Updated Sept. 15, 2015, 6:51 p.m.)
> 
> 
> Review request for mesos, Timothy Chen and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-3432
>     https://issues.apache.org/jira/browse/MESOS-3432
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Renamed provisioners::path to provisioner::path.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/provisioner/appc/provisioner.cpp 77f9cbe778785bd93c30eba5dfd7a470d9258661 
>   src/slave/containerizer/provisioner/paths.hpp 5b82591fbe0d1ea48e4b09727424d0547f21adc2 
>   src/slave/containerizer/provisioner/paths.cpp 4293dd2fe62bd6aee9243717916c86ff9e39d9ce 
>   src/slave/paths.hpp 43c65af03a6af8d3d2d50f7c8366d7fbd26cb990 
>   src/slave/paths.cpp f104ecdbbb78093ccb968c0a01ea0924bfa391c5 
>   src/tests/paths_tests.cpp 1ccc5c70b06f44f54d843d6ed92e9105eda40a7b 
> 
> Diff: https://reviews.apache.org/r/38408/diff/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 38408: Renamed provisioners::path to provisioner::path.

Posted by Jie Yu <yu...@gmail.com>.

> On Sept. 15, 2015, 7:01 p.m., Jiang Yan Xu wrote:
> > src/slave/paths.cpp, line 378
> > <https://reviews.apache.org/r/38408/diff/2/?file=1074376#file1074376line378>
> >
> >     I don't think this needs to be changed to singular and the convention is that the plural form ("slaves", "frameworks", "executors", "provisioners", "volumes", etc.) is used for folders that serve as "container folders".
> 
> Jie Yu wrote:
>     We use 'slaves' 'executors' ... because there could be multiple slaves, executors.
>     
>     But, there's only one provisioner.

OK, Chatted with YanX. The image_type part will be removed in the subsequent patch. I'll just keep it as it is for this patch.


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38408/#review99065
-----------------------------------------------------------


On Sept. 15, 2015, 6:51 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38408/
> -----------------------------------------------------------
> 
> (Updated Sept. 15, 2015, 6:51 p.m.)
> 
> 
> Review request for mesos, Timothy Chen and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-3432
>     https://issues.apache.org/jira/browse/MESOS-3432
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Renamed provisioners::path to provisioner::path.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/provisioner/appc/provisioner.cpp 77f9cbe778785bd93c30eba5dfd7a470d9258661 
>   src/slave/containerizer/provisioner/paths.hpp 5b82591fbe0d1ea48e4b09727424d0547f21adc2 
>   src/slave/containerizer/provisioner/paths.cpp 4293dd2fe62bd6aee9243717916c86ff9e39d9ce 
>   src/slave/paths.hpp 43c65af03a6af8d3d2d50f7c8366d7fbd26cb990 
>   src/slave/paths.cpp f104ecdbbb78093ccb968c0a01ea0924bfa391c5 
>   src/tests/paths_tests.cpp 1ccc5c70b06f44f54d843d6ed92e9105eda40a7b 
> 
> Diff: https://reviews.apache.org/r/38408/diff/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 38408: Renamed provisioners::path to provisioner::path.

Posted by Jie Yu <yu...@gmail.com>.

> On Sept. 15, 2015, 7:01 p.m., Jiang Yan Xu wrote:
> > src/slave/paths.cpp, line 378
> > <https://reviews.apache.org/r/38408/diff/2/?file=1074376#file1074376line378>
> >
> >     I don't think this needs to be changed to singular and the convention is that the plural form ("slaves", "frameworks", "executors", "provisioners", "volumes", etc.) is used for folders that serve as "container folders".

We use 'slaves' 'executors' ... because there could be multiple slaves, executors.

But, there's only one provisioner.


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38408/#review99065
-----------------------------------------------------------


On Sept. 15, 2015, 6:51 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38408/
> -----------------------------------------------------------
> 
> (Updated Sept. 15, 2015, 6:51 p.m.)
> 
> 
> Review request for mesos, Timothy Chen and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-3432
>     https://issues.apache.org/jira/browse/MESOS-3432
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Renamed provisioners::path to provisioner::path.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/provisioner/appc/provisioner.cpp 77f9cbe778785bd93c30eba5dfd7a470d9258661 
>   src/slave/containerizer/provisioner/paths.hpp 5b82591fbe0d1ea48e4b09727424d0547f21adc2 
>   src/slave/containerizer/provisioner/paths.cpp 4293dd2fe62bd6aee9243717916c86ff9e39d9ce 
>   src/slave/paths.hpp 43c65af03a6af8d3d2d50f7c8366d7fbd26cb990 
>   src/slave/paths.cpp f104ecdbbb78093ccb968c0a01ea0924bfa391c5 
>   src/tests/paths_tests.cpp 1ccc5c70b06f44f54d843d6ed92e9105eda40a7b 
> 
> Diff: https://reviews.apache.org/r/38408/diff/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 38408: Renamed provisioners::path to provisioner::path.

Posted by Jiang Yan Xu <ya...@jxu.me>.

> On Sept. 15, 2015, 12:01 p.m., Jiang Yan Xu wrote:
> > src/slave/paths.cpp, line 378
> > <https://reviews.apache.org/r/38408/diff/2/?file=1074376#file1074376line378>
> >
> >     I don't think this needs to be changed to singular and the convention is that the plural form ("slaves", "frameworks", "executors", "provisioners", "volumes", etc.) is used for folders that serve as "container folders".
> 
> Jie Yu wrote:
>     We use 'slaves' 'executors' ... because there could be multiple slaves, executors.
>     
>     But, there's only one provisioner.
> 
> Jie Yu wrote:
>     OK, Chatted with YanX. The image_type part will be removed in the subsequent patch. I'll just keep it as it is for this patch.

Fine then. Chatted offline about removing the per-image-type dirs as well.


- Jiang Yan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38408/#review99065
-----------------------------------------------------------


On Sept. 15, 2015, 11:51 a.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38408/
> -----------------------------------------------------------
> 
> (Updated Sept. 15, 2015, 11:51 a.m.)
> 
> 
> Review request for mesos, Timothy Chen and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-3432
>     https://issues.apache.org/jira/browse/MESOS-3432
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Renamed provisioners::path to provisioner::path.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/provisioner/appc/provisioner.cpp 77f9cbe778785bd93c30eba5dfd7a470d9258661 
>   src/slave/containerizer/provisioner/paths.hpp 5b82591fbe0d1ea48e4b09727424d0547f21adc2 
>   src/slave/containerizer/provisioner/paths.cpp 4293dd2fe62bd6aee9243717916c86ff9e39d9ce 
>   src/slave/paths.hpp 43c65af03a6af8d3d2d50f7c8366d7fbd26cb990 
>   src/slave/paths.cpp f104ecdbbb78093ccb968c0a01ea0924bfa391c5 
>   src/tests/paths_tests.cpp 1ccc5c70b06f44f54d843d6ed92e9105eda40a7b 
> 
> Diff: https://reviews.apache.org/r/38408/diff/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 38408: Renamed provisioners::path to provisioner::path.

Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38408/#review99065
-----------------------------------------------------------



src/slave/containerizer/provisioner/paths.hpp (line 32)
<https://reviews.apache.org/r/38408/#comment155897>

    `provisoiners -> provisioner`: This is fine with me.



src/slave/paths.cpp (line 378)
<https://reviews.apache.org/r/38408/#comment155896>

    I don't think this needs to be changed to singular and the convention is that the plural form ("slaves", "frameworks", "executors", "provisioners", "volumes", etc.) is used for folders that serve as "container folders".


- Jiang Yan Xu


On Sept. 15, 2015, 11:51 a.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38408/
> -----------------------------------------------------------
> 
> (Updated Sept. 15, 2015, 11:51 a.m.)
> 
> 
> Review request for mesos, Timothy Chen and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-3432
>     https://issues.apache.org/jira/browse/MESOS-3432
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Renamed provisioners::path to provisioner::path.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/provisioner/appc/provisioner.cpp 77f9cbe778785bd93c30eba5dfd7a470d9258661 
>   src/slave/containerizer/provisioner/paths.hpp 5b82591fbe0d1ea48e4b09727424d0547f21adc2 
>   src/slave/containerizer/provisioner/paths.cpp 4293dd2fe62bd6aee9243717916c86ff9e39d9ce 
>   src/slave/paths.hpp 43c65af03a6af8d3d2d50f7c8366d7fbd26cb990 
>   src/slave/paths.cpp f104ecdbbb78093ccb968c0a01ea0924bfa391c5 
>   src/tests/paths_tests.cpp 1ccc5c70b06f44f54d843d6ed92e9105eda40a7b 
> 
> Diff: https://reviews.apache.org/r/38408/diff/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 38408: Renamed provisioners::path to provisioner::path.

Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38408/
-----------------------------------------------------------

(Updated Sept. 15, 2015, 6:51 p.m.)


Review request for mesos, Timothy Chen and Jiang Yan Xu.


Changes
-------

Upload the latest version.


Bugs: MESOS-3432
    https://issues.apache.org/jira/browse/MESOS-3432


Repository: mesos


Description
-------

Renamed provisioners::path to provisioner::path.


Diffs (updated)
-----

  src/slave/containerizer/provisioner/appc/provisioner.cpp 77f9cbe778785bd93c30eba5dfd7a470d9258661 
  src/slave/containerizer/provisioner/paths.hpp 5b82591fbe0d1ea48e4b09727424d0547f21adc2 
  src/slave/containerizer/provisioner/paths.cpp 4293dd2fe62bd6aee9243717916c86ff9e39d9ce 
  src/slave/paths.hpp 43c65af03a6af8d3d2d50f7c8366d7fbd26cb990 
  src/slave/paths.cpp f104ecdbbb78093ccb968c0a01ea0924bfa391c5 
  src/tests/paths_tests.cpp 1ccc5c70b06f44f54d843d6ed92e9105eda40a7b 

Diff: https://reviews.apache.org/r/38408/diff/


Testing
-------

sudo make check


Thanks,

Jie Yu