You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2023/10/07 00:26:24 UTC

[kudu-CR] [thirdparty] build gperftools with libunwind support

Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20544


Change subject: [thirdparty] build gperftools with libunwind support
......................................................................

[thirdparty] build gperftools with libunwind support

This patch enables libunwind support when building gperftools.
That's to add stracktrace collection option based on libunwind: it seems
that might be useful with current version of gperftools library (2.8.1)
where frame-pointer-based option isn't available for aarch64, so the
only collection method is libgcc-based.

Change-Id: I59b307e3ee3ff9464934ef60ca439dcfcd496a2c
---
M CMakeLists.txt
M thirdparty/build-definitions.sh
2 files changed, 19 insertions(+), 5 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/44/20544/1
-- 
To view, visit http://gerrit.cloudera.org:8080/20544
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I59b307e3ee3ff9464934ef60ca439dcfcd496a2c
Gerrit-Change-Number: 20544
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>

[kudu-CR] [thirdparty] build gperftools with libunwind support

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Marton Greber, Zoltan Martonka, Kudu Jenkins, Abhishek Chennaka, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/20544

to look at the new patch set (#4).

Change subject: [thirdparty] build gperftools with libunwind support
......................................................................

[thirdparty] build gperftools with libunwind support

This patch enables libunwind support when building gperftools.
That's to add stracktrace collection option based on libunwind: it seems
that might be useful with current version of gperftools library (2.8.1)
where frame-pointer-based option isn't available for aarch64, so the
only collection method is libgcc-based.

Change-Id: I59b307e3ee3ff9464934ef60ca439dcfcd496a2c
---
M CMakeLists.txt
M thirdparty/build-definitions.sh
2 files changed, 38 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/44/20544/4
-- 
To view, visit http://gerrit.cloudera.org:8080/20544
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I59b307e3ee3ff9464934ef60ca439dcfcd496a2c
Gerrit-Change-Number: 20544
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>

[kudu-CR] [thirdparty] build gperftools with libunwind support

Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/20544 )

Change subject: [thirdparty] build gperftools with libunwind support
......................................................................


Patch Set 4: Code-Review+1

LGTM, thanks for taking care of this!


-- 
To view, visit http://gerrit.cloudera.org:8080/20544
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I59b307e3ee3ff9464934ef60ca439dcfcd496a2c
Gerrit-Change-Number: 20544
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Comment-Date: Sat, 07 Oct 2023 09:43:04 +0000
Gerrit-HasComments: No

[kudu-CR] [thirdparty] build gperftools with libunwind support

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20544 )

Change subject: [thirdparty] build gperftools with libunwind support
......................................................................

[thirdparty] build gperftools with libunwind support

This patch enables libunwind support when building gperftools.
That's to add stracktrace collection option based on libunwind: it seems
that might be useful with current version of gperftools library (2.8.1)
where frame-pointer-based option isn't available for aarch64, so the
only collection method is libgcc-based.

Change-Id: I59b307e3ee3ff9464934ef60ca439dcfcd496a2c
Reviewed-on: http://gerrit.cloudera.org:8080/20544
Tested-by: Kudu Jenkins
Reviewed-by: Marton Greber <gr...@gmail.com>
Reviewed-by: Alexey Serbin <al...@apache.org>
---
M CMakeLists.txt
M thirdparty/build-definitions.sh
2 files changed, 38 insertions(+), 10 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Marton Greber: Looks good to me, but someone else must approve
  Alexey Serbin: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/20544
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I59b307e3ee3ff9464934ef60ca439dcfcd496a2c
Gerrit-Change-Number: 20544
Gerrit-PatchSet: 5
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>

[kudu-CR] [thirdparty] build gperftools with libunwind support

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Marton Greber, Zoltan Martonka, Kudu Jenkins, Abhishek Chennaka, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/20544

to look at the new patch set (#2).

Change subject: [thirdparty] build gperftools with libunwind support
......................................................................

[thirdparty] build gperftools with libunwind support

This patch enables libunwind support when building gperftools.
That's to add stracktrace collection option based on libunwind: it seems
that might be useful with current version of gperftools library (2.8.1)
where frame-pointer-based option isn't available for aarch64, so the
only collection method is libgcc-based.

Change-Id: I59b307e3ee3ff9464934ef60ca439dcfcd496a2c
---
M CMakeLists.txt
M thirdparty/build-definitions.sh
2 files changed, 40 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/44/20544/2
-- 
To view, visit http://gerrit.cloudera.org:8080/20544
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I59b307e3ee3ff9464934ef60ca439dcfcd496a2c
Gerrit-Change-Number: 20544
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>

[kudu-CR] [thirdparty] build gperftools with libunwind support

Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/20544 )

Change subject: [thirdparty] build gperftools with libunwind support
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/20544
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I59b307e3ee3ff9464934ef60ca439dcfcd496a2c
Gerrit-Change-Number: 20544
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Comment-Date: Sat, 07 Oct 2023 06:06:25 +0000
Gerrit-HasComments: No

[kudu-CR] [thirdparty] build gperftools with libunwind support

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20544 )

Change subject: [thirdparty] build gperftools with libunwind support
......................................................................


Patch Set 4: Code-Review+2

carrying over Abhishek's +2 from PS3.


-- 
To view, visit http://gerrit.cloudera.org:8080/20544
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I59b307e3ee3ff9464934ef60ca439dcfcd496a2c
Gerrit-Change-Number: 20544
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Comment-Date: Sat, 07 Oct 2023 14:16:01 +0000
Gerrit-HasComments: No

[kudu-CR] [thirdparty] build gperftools with libunwind support

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Marton Greber, Zoltan Martonka, Kudu Jenkins, Abhishek Chennaka, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/20544

to look at the new patch set (#3).

Change subject: [thirdparty] build gperftools with libunwind support
......................................................................

[thirdparty] build gperftools with libunwind support

This patch enables libunwind support when building gperftools.
That's to add stracktrace collection option based on libunwind: it seems
that might be useful with current version of gperftools library (2.8.1)
where frame-pointer-based option isn't available for aarch64, so the
only collection method is libgcc-based.

Change-Id: I59b307e3ee3ff9464934ef60ca439dcfcd496a2c
---
M CMakeLists.txt
M thirdparty/build-definitions.sh
2 files changed, 39 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/44/20544/3
-- 
To view, visit http://gerrit.cloudera.org:8080/20544
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I59b307e3ee3ff9464934ef60ca439dcfcd496a2c
Gerrit-Change-Number: 20544
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>