You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by Chug Rolke <cr...@redhat.com> on 2012/10/16 20:58:22 UTC

Review Request: Rename ACL CLI switches to avoid conflicting values; restore Broker maxConns management property

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7618/
-----------------------------------------------------------

Review request for qpid.


Description
-------

Acl CLI switches cause a conflict with older versions of boost program_options. Rename them.
Broker maxConns management property was deleted. Restore it.


This addresses bug QPID-4373.
    https://issues.apache.org/jira/browse/QPID-4373


Diffs
-----

  trunk/qpid/cpp/src/qpid/acl/Acl.h 1398425 
  trunk/qpid/cpp/src/qpid/acl/AclPlugin.cpp 1398425 
  trunk/qpid/cpp/src/qpid/broker/AclModule.h 1398425 
  trunk/qpid/cpp/src/qpid/broker/Broker.cpp 1398425 
  trunk/qpid/cpp/src/tests/run_acl_tests 1398425 
  trunk/qpid/specs/management-schema.xml 1398425 

Diff: https://reviews.apache.org/r/7618/diff/


Testing
-------

New switch names used in acl self tests.


Thanks,

Chug Rolke


Re: Review Request: Rename ACL CLI switches to avoid conflicting values; restore Broker maxConns management property

Posted by Andrew Stitcher <as...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7618/#review12511
-----------------------------------------------------------

Ship it!


Ship It!

- Andrew Stitcher


On Oct. 16, 2012, 6:58 p.m., Chug Rolke wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7618/
> -----------------------------------------------------------
> 
> (Updated Oct. 16, 2012, 6:58 p.m.)
> 
> 
> Review request for qpid.
> 
> 
> Description
> -------
> 
> Acl CLI switches cause a conflict with older versions of boost program_options. Rename them.
> Broker maxConns management property was deleted. Restore it.
> 
> 
> This addresses bug QPID-4373.
>     https://issues.apache.org/jira/browse/QPID-4373
> 
> 
> Diffs
> -----
> 
>   trunk/qpid/cpp/src/qpid/acl/Acl.h 1398425 
>   trunk/qpid/cpp/src/qpid/acl/AclPlugin.cpp 1398425 
>   trunk/qpid/cpp/src/qpid/broker/AclModule.h 1398425 
>   trunk/qpid/cpp/src/qpid/broker/Broker.cpp 1398425 
>   trunk/qpid/cpp/src/tests/run_acl_tests 1398425 
>   trunk/qpid/specs/management-schema.xml 1398425 
> 
> Diff: https://reviews.apache.org/r/7618/diff/
> 
> 
> Testing
> -------
> 
> New switch names used in acl self tests.
> 
> 
> Thanks,
> 
> Chug Rolke
> 
>