[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #3405: [Profile] Make running profile clearer and more intuitive to improve usability

[GitBox <gi...@apache.org>]

kangkaisen commented on a change in pull request #3405:
URL: https://github.com/apache/incubator-doris/pull/3405#discussion_r417382629



##########
File path: be/src/exec/exec_node.cpp
##########
@@ -172,15 +172,13 @@ Status ExecNode::prepare(RuntimeState* state) {
     DCHECK(_runtime_profile.get() != NULL);
     _rows_returned_counter =
         ADD_COUNTER(_runtime_profile, "RowsReturned", TUnit::UNIT);
-    _memory_used_counter =
-        ADD_COUNTER(_runtime_profile, "MemoryUsed", TUnit::BYTES);

Review comment:
       >Delete all code use _memory_used_counter in the future, all mem used is tracked by MemTracker, we show peakmemusage it by the counter in MemTracker.
   
   I prefer this.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org