You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/10/17 02:21:47 UTC

[GitHub] [iotdb] stormbroken opened a new pull request #4171: [IOTDB-1846]Fix the error when count the total number of devices in cluster mode

stormbroken opened a new pull request #4171:
URL: https://github.com/apache/iotdb/pull/4171


   The details of this problem: https://issues.apache.org/jira/projects/IOTDB/issues/IOTDB-1846?filter=allissues
   
   In the previous implementation, counting the total number of devices is only counting the local devices. So I fix this in ClusterPlanExector.class to count all devices in all cluster.
   
   The result(Test)
   I use iotdb-benchmark to write data(DEVICE_NUMBER=20) into cluster, and then query each node to see the results.
   Some details pictures are as follows:
   
   1. The details of devices:
   
   ![2CC7A0FE-F8D7-4E34-AD15-6A477C9C0F9C](https://user-images.githubusercontent.com/46039728/137607973-b9e7db04-0521-40f4-9c5d-1ba5e1dbfa8e.png)
   
   2. The total number of devices(same in three nodes)
   
   ![image](https://user-images.githubusercontent.com/46039728/137607983-227996f7-e2cc-4b40-93f0-2b4db2b59fdc.png)
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] LebronAl commented on pull request #4171: [IOTDB-1846]Fix the error when count the total number of devices in cluster mode

Posted by GitBox <gi...@apache.org>.
LebronAl commented on pull request #4171:
URL: https://github.com/apache/iotdb/pull/4171#issuecomment-946481671


   Sorry, I did not observe when reviewing  PR that this implementation does not push down count operator, which could lead to performance bottlenecks in mass device scenarios. I have contacted @stormbroken  to optimize the push-down count operator.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] coveralls edited a comment on pull request #4171: [IOTDB-1846]Fix the error when count the total number of devices in cluster mode

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4171:
URL: https://github.com/apache/iotdb/pull/4171#issuecomment-945040777


   
   [![Coverage Status](https://coveralls.io/builds/43555141/badge)](https://coveralls.io/builds/43555141)
   
   Coverage increased (+0.01%) to 67.805% when pulling **86ff3d08c5103c8d7c3ef56d12c9d9af2e07c353 on stormbroken:fix/countDevice** into **0c39ef6b250c53210577ff001ab4fefd1d93954f on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] LebronAl merged pull request #4171: [IOTDB-1846]Fix the error when count the total number of devices in cluster mode

Posted by GitBox <gi...@apache.org>.
LebronAl merged pull request #4171:
URL: https://github.com/apache/iotdb/pull/4171


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] coveralls commented on pull request #4171: [IOTDB-1846]Fix the error when count the total number of devices in cluster mode

Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #4171:
URL: https://github.com/apache/iotdb/pull/4171#issuecomment-945040777


   
   [![Coverage Status](https://coveralls.io/builds/43554763/badge)](https://coveralls.io/builds/43554763)
   
   Coverage decreased (-0.002%) to 67.788% when pulling **9c664b737f22bb5253f1a0a0803da49ca41e81c8 on stormbroken:fix/countDevice** into **0c39ef6b250c53210577ff001ab4fefd1d93954f on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] coveralls edited a comment on pull request #4171: [IOTDB-1846]Fix the error when count the total number of devices in cluster mode

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4171:
URL: https://github.com/apache/iotdb/pull/4171#issuecomment-945040777


   
   [![Coverage Status](https://coveralls.io/builds/43555146/badge)](https://coveralls.io/builds/43555146)
   
   Coverage increased (+0.001%) to 67.792% when pulling **86ff3d08c5103c8d7c3ef56d12c9d9af2e07c353 on stormbroken:fix/countDevice** into **0c39ef6b250c53210577ff001ab4fefd1d93954f on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org