You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "michael-s-molina (via GitHub)" <gi...@apache.org> on 2024/05/07 13:38:19 UTC
[PR] fix: Contribution percentages for ECharts plugins [superset]
michael-s-molina opened a new pull request, #28368:
URL: https://github.com/apache/superset/pull/28368
### SUMMARY
Fix percentages shown in tooltips of ECharts plugins that contain time offsets and contribution mode enabled. The ECharts version does not distinguish series and time shifts when calculating the contribution percentages as the legacy version does. Instead of showing something like series A 50%, series B 50%, series A (a year ago) 50%, series B (a year ago) 50%, it shows all series with 25%. With this fix, the contribution of time shifts are calculated independently.
This is another pre-requisite to unblock timeseries chart migrations.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<img width="1030" alt="Screenshot 2024-05-03 at 10 05 57" src="https://github.com/apache/superset/assets/70410625/6b58d9e5-b2c2-4125-846d-964ecc19a85f">
<img width="1044" alt="Screenshot 2024-05-07 at 10 25 03" src="https://github.com/apache/superset/assets/70410625/fbd5d5de-91c7-42f3-96d8-e166b34cda84">
### TESTING INSTRUCTIONS
Check that time shift contributions are calculated independently.
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: Contribution percentages for ECharts plugins [superset]
Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina commented on PR #28368:
URL: https://github.com/apache/superset/pull/28368#issuecomment-2100372807
> @[dosubot](https://github.com/apps/dosubot) dosubot bot added the [lgtm](https://github.com/apache/superset/labels/lgtm) label [18 hours ago](https://github.com/apache/superset/pull/28368#event-12733068366)
@rusackas Does the bot add this label because someone approved the PR or because it reviewed the changes and considered them mergeable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: Contribution percentages for ECharts plugins [superset]
Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina merged PR #28368:
URL: https://github.com/apache/superset/pull/28368
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: Contribution percentages for ECharts plugins [superset]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #28368:
URL: https://github.com/apache/superset/pull/28368#issuecomment-2098462688
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/28368?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: Patch coverage is `11.42857%` with `31 lines` in your changes are missing coverage. Please review.
> Project coverage is 67.27%. Comparing base [(`2e5f3ed`)](https://app.codecov.io/gh/apache/superset/commit/2e5f3ed85149951200645e00e79a543de9bec02f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`e37fcf7`)](https://app.codecov.io/gh/apache/superset/pull/28368?dropdown=coverage&src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 43 commits behind head on master.
| [Files](https://app.codecov.io/gh/apache/superset/pull/28368?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...perset/utils/pandas\_postprocessing/contribution.py](https://app.codecov.io/gh/apache/superset/pull/28368?src=pr&el=tree&filepath=superset%2Futils%2Fpandas_postprocessing%2Fcontribution.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvdXRpbHMvcGFuZGFzX3Bvc3Rwcm9jZXNzaW5nL2NvbnRyaWJ1dGlvbi5weQ==) | 11.42% | [31 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/28368?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #28368 +/- ##
==========================================
+ Coverage 60.49% 67.27% +6.78%
==========================================
Files 1931 1934 +3
Lines 76241 76804 +563
Branches 8566 8565 -1
==========================================
+ Hits 46122 51671 +5549
+ Misses 28015 23030 -4985
+ Partials 2104 2103 -1
```
| [Flag](https://app.codecov.io/gh/apache/superset/pull/28368/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hive](https://app.codecov.io/gh/apache/superset/pull/28368/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [postgres](https://app.codecov.io/gh/apache/superset/pull/28368/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `77.31% <11.42%> (?)` | |
| [presto](https://app.codecov.io/gh/apache/superset/pull/28368/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [python](https://app.codecov.io/gh/apache/superset/pull/28368/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `77.44% <11.42%> (+13.95%)` | :arrow_up: |
| [sqlite](https://app.codecov.io/gh/apache/superset/pull/28368/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `76.76% <11.42%> (?)` | |
| [unit](https://app.codecov.io/gh/apache/superset/pull/28368/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/superset/pull/28368?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: Contribution percentages for ECharts plugins [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #28368:
URL: https://github.com/apache/superset/pull/28368#issuecomment-2101883559
> > @[dosubot](https://github.com/apps/dosubot) dosubot bot added the [lgtm](https://github.com/apache/superset/labels/lgtm) label [18 hours ago](https://github.com/apache/superset/pull/28368#event-12733068366)
>
> @rusackas Does the bot add this label because someone approved the PR or because it reviewed the changes and considered them good enough to merge?
Because it was reviewed by a committer and is basically mergeable... we can turn it off if we'd like, I'm not sure it's helping much.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: Contribution percentages for ECharts plugins [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #28368:
URL: https://github.com/apache/superset/pull/28368#issuecomment-2102885704
Ok, it's off now :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: Contribution percentages for ECharts plugins [superset]
Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina commented on PR #28368:
URL: https://github.com/apache/superset/pull/28368#issuecomment-2102468435
> Because it was reviewed by a committer and is basically mergeable... we can turn it off if we'd like, I'm not sure it's helping much.
Got it. I believe we can turn it off as it's not providing additional value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org