You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/03/17 04:53:48 UTC

[GitHub] [incubator-nuttx] no1wudi opened a new pull request #5766: arch/risc-v: Rework riscv_get_newintctx

no1wudi opened a new pull request #5766:
URL: https://github.com/apache/incubator-nuttx/pull/5766


   ## Summary
   Some fields of mstatus were marked as Reserved Writes Preserve Values, Reads Ignore Values (WPRI),
   so we must keep its origin value with addition flags.
   ## Impact
   N/A
   ## Testing
   CI and rv-virt/maix-bit
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #5766: arch/risc-v: Rework riscv_get_newintctx

Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on pull request #5766:
URL: https://github.com/apache/incubator-nuttx/pull/5766#issuecomment-1071904434


   @no1wudi 
   
   Hmm, my automatic test failed with maix-bit:smp (QEMU-5.2)
   
   ```
   NuttShell (NSH) NuttX-10.2.0
   nsh>  
   nsh> uname -a
   NuttX 10.2.0 807304f283 Mar 18 2022 09:34:18 risc-v maix-bit
   nsh> mount
     /proc type procfs
   nsh> ps
     PID GROUP CPU PRI POLICY   TYPE    NPX STATE    EVENT     SIGMASK   STACK   USED  FILLED COMMAND
       0     0   0   0 FIFO     Kthread N-- Assigned           00000000 002000 000792  39.6%  CPU0 IDLE
       1     1   1   0 FIFO     Kthread N-- Running            00000000 002000 000032   1.6%  CPU1 IDLE
       2     2   0 100 RR       Task    --- Running            00000000 003040 002072  68.1%  nsh_main
   nsh> free
   ...
   ```
   End of test memory usage:
   VARIABLE  BEFORE   AFTER
   ======== ======== ========
   arena      1fc560   1fc560
   ordblks         6        6
   mxordblk   1f1670   1f1670
   uordblks     7f50     7f50
   fordblks   1f4610   1f4610
   
   user_main: condition variable test
   cond_test: Initializing mutex
   cond_test: Initializing cond
   cond_test: Starting waiter
   cond_test: Set thread 1 priority to 128
   waiter_thread: Started
   cond_test: Starting signaler
   cond_test: Set thread 2 priority to 64
   [CPU0] riscv_fault: EPC: 00000000800001bc
   [CPU0] riscv_fault: Fault IRQ=2
   [CPU0] riscv_fault: A0: 000000008040c9bc A1: 000000008040c9c1 A2: 000000008040c9c6 A3: 0000000000000000
   [CPU0] riscv_fault: A4: 410074736574736f A5: 3267724100316772 A6: 7241003367724100 A7: 0000000000003467
   [CPU0] riscv_fault: T0: 0000000000000000 T1: 0000000000000000 T2: 0000000000000074 T3: deadbeefdeadbeef
   [CPU0] riscv_fault: T4: deadbeefdeadbeef T5: deadbeefdeadbeef T6: deadbeefdeadbeef
   [CPU0] riscv_fault: S0: 000000008040c9b0 S1: 000000008040c9b7 S2: deadbeefdeadbeef S3: deadbeefdeadbeef
   [CPU0] riscv_fault: S4: deadbeefdeadbeef S5: deadbeefdeadbeef S6: deadbeefdeadbeef S7: deadbeefdeadbeef
   [CPU0] riscv_fault: S8: deadbeefdeadbeef S9: deadbeefdeadbeef S10: deadbeefdeadbeef S11: deadbeefdeadbeef
   [CPU0] riscv_fault: SP: 000000008040a310 FP: 000000008040c9b0 TP: 0000000000000000 RA: 8000084000002040
   [CPU0] up_assert: Assertion failed CPU0 at file:chip/k210_irq_dispatch.c line: 89 task: pt-0x800148ec
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #5766: arch/risc-v: Rework riscv_get_newintctx

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #5766:
URL: https://github.com/apache/incubator-nuttx/pull/5766


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #5766: arch/risc-v: Rework riscv_get_newintctx

Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on pull request #5766:
URL: https://github.com/apache/incubator-nuttx/pull/5766#issuecomment-1071904434


   @no1wudi 
   
   Hmm, my automatic test failed with maix-bit:smp (QEMU-5.2)
   
   ```
   NuttShell (NSH) NuttX-10.2.0
   nsh>  
   nsh> uname -a
   NuttX 10.2.0 807304f283 Mar 18 2022 09:34:18 risc-v maix-bit
   nsh> mount
     /proc type procfs
   nsh> ps
     PID GROUP CPU PRI POLICY   TYPE    NPX STATE    EVENT     SIGMASK   STACK   USED  FILLED COMMAND
       0     0   0   0 FIFO     Kthread N-- Assigned           00000000 002000 000792  39.6%  CPU0 IDLE
       1     1   1   0 FIFO     Kthread N-- Running            00000000 002000 000032   1.6%  CPU1 IDLE
       2     2   0 100 RR       Task    --- Running            00000000 003040 002072  68.1%  nsh_main
   nsh> free
   ...
   ```
   End of test memory usage:
   VARIABLE  BEFORE   AFTER
   ======== ======== ========
   arena      1fc560   1fc560
   ordblks         6        6
   mxordblk   1f1670   1f1670
   uordblks     7f50     7f50
   fordblks   1f4610   1f4610
   
   user_main: condition variable test
   cond_test: Initializing mutex
   cond_test: Initializing cond
   cond_test: Starting waiter
   cond_test: Set thread 1 priority to 128
   waiter_thread: Started
   cond_test: Starting signaler
   cond_test: Set thread 2 priority to 64
   [CPU0] riscv_fault: EPC: 00000000800001bc
   [CPU0] riscv_fault: Fault IRQ=2
   [CPU0] riscv_fault: A0: 000000008040c9bc A1: 000000008040c9c1 A2: 000000008040c9c6 A3: 0000000000000000
   [CPU0] riscv_fault: A4: 410074736574736f A5: 3267724100316772 A6: 7241003367724100 A7: 0000000000003467
   [CPU0] riscv_fault: T0: 0000000000000000 T1: 0000000000000000 T2: 0000000000000074 T3: deadbeefdeadbeef
   [CPU0] riscv_fault: T4: deadbeefdeadbeef T5: deadbeefdeadbeef T6: deadbeefdeadbeef
   [CPU0] riscv_fault: S0: 000000008040c9b0 S1: 000000008040c9b7 S2: deadbeefdeadbeef S3: deadbeefdeadbeef
   [CPU0] riscv_fault: S4: deadbeefdeadbeef S5: deadbeefdeadbeef S6: deadbeefdeadbeef S7: deadbeefdeadbeef
   [CPU0] riscv_fault: S8: deadbeefdeadbeef S9: deadbeefdeadbeef S10: deadbeefdeadbeef S11: deadbeefdeadbeef
   [CPU0] riscv_fault: SP: 000000008040a310 FP: 000000008040c9b0 TP: 0000000000000000 RA: 8000084000002040
   [CPU0] up_assert: Assertion failed CPU0 at file:chip/k210_irq_dispatch.c line: 89 task: pt-0x800148ec
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] no1wudi commented on pull request #5766: arch/risc-v: Rework riscv_get_newintctx

Posted by GitBox <gi...@apache.org>.
no1wudi commented on pull request #5766:
URL: https://github.com/apache/incubator-nuttx/pull/5766#issuecomment-1071983422


   @masayuki2009 It seems due to mix usage of crsw and csrrc (write and bit set/bit clear) changed the MIE bit in mstatus , I'll submit PR to fix it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] no1wudi commented on pull request #5766: arch/risc-v: Rework riscv_get_newintctx

Posted by GitBox <gi...@apache.org>.
no1wudi commented on pull request #5766:
URL: https://github.com/apache/incubator-nuttx/pull/5766#issuecomment-1071983422


   @masayuki2009 It seems due to mix usage of crsw and csrrc (write and bit set/bit clear) changed the MIE bit in mstatus , I'll submit PR to fix it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org