You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2020/02/28 06:48:28 UTC

[GitHub] [rocketmq] RongtongJin commented on issue #1780: question about ReferenceResource#hold

RongtongJin commented on issue #1780: question about ReferenceResource#hold
URL: https://github.com/apache/rocketmq/issues/1780#issuecomment-592351970
 
 
   IMO, it is neccessary to add `synchronized`, hold method must be mutually exclusive with the synchronized block below. Otherwise, it is possible that hold returns true and cleanup success.
   https://github.com/apache/rocketmq/blob/73bb4b402a5da02faf9feded8f4d79dd1ba88348/store/src/main/java/org/apache/rocketmq/store/ReferenceResource.java#L56-L65
   In addition, issue is for bug report and feature request, so welcome to ask question on [mail list](http://rocketmq.apache.org/about/contact/).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services