[jira] [Commented] (IGNITE-4264) Offheap cache entries statistics is broken in master

["Andrey Gura (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/IGNITE-4264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15729414#comment-15729414 ] 

Andrey Gura commented on IGNITE-4264:
-------------------------------------

Hi, [~wmz7year]. I've looked at your PR and I think that this fix isn't correct. Your cache can be created on some client or server node but this node can be filtered out and doesn't own any data. In order to get all nodes that really have cache data you should get affinity nodes using {{ClusterGroup.forDataNodes(String cacheName)}} method.

Also I'm not sure that filtering out clients is good idea ({{forServers() call}}) because client node can have local cache and own metrics.

Could you please take in account this comments and provide new fix?

Thanks.

> Offheap cache entries statistics is broken in master
> ----------------------------------------------------
>
>                 Key: IGNITE-4264
>                 URL: https://issues.apache.org/jira/browse/IGNITE-4264
>             Project: Ignite
>          Issue Type: Bug
>          Components: cache
>            Reporter: Andrew Mashenkov
>            Assignee: wmz7year
>             Fix For: 2.0
>
>         Attachments: Test.java
>
>
> Reproducer is attached. Test is fine on 1.7 release branch, but fails in master
> cache.metrics().getOffHeapPrimaryEntriesCount() returns wrong number. Also it seems the number grows with increasing number of clients.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)