You are viewing a plain text version of this content. The canonical link for it is here.
Posted to devnull@infra.apache.org by "xiaoyimei (GitHub)" <gi...@apache.org> on 2018/08/22 05:34:09 UTC
[GitHub] [incubator-servicecomb-service-center] xiaoyimei opened pull
request #428: [SCB-807]Limit the topology view to only 100 microservices.
Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `go build` `go test` `go fmt` `go vet` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
---
[ Full content available at: https://github.com/apache/incubator-servicecomb-service-center/pull/428 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [incubator-servicecomb-service-center] asifdxtreme closed
pull request #428: [SCB-807]Limit the topology view to only 100
microservices.
Posted by "asifdxtreme (GitHub)" <gi...@apache.org>.
[ pull request closed by asifdxtreme ]
[ Full content available at: https://github.com/apache/incubator-servicecomb-service-center/pull/428 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [incubator-servicecomb-service-center] codecov-io commented
on issue #428: [SCB-807]Limit the topology view to only 100 microservices.
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/428?src=pr&el=h1) Report
> Merging [#428](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/428?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/9f55487b6ed2a256a5d66fe028c4e986961921e9?src=pr&el=desc) will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/428?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #428 +/- ##
==========================================
- Coverage 72.97% 72.96% -0.02%
==========================================
Files 128 128
Lines 9978 9978
==========================================
- Hits 7281 7280 -1
Misses 2221 2221
- Partials 476 477 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/428?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [server/plugin/infra/registry/etcd/tracing.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/428/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9pbmZyYS9yZWdpc3RyeS9ldGNkL3RyYWNpbmcuZ28=) | `72.72% <0%> (-9.1%)` | :arrow_down: |
| [server/broker/util.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/428/diff?src=pr&el=tree#diff-c2VydmVyL2Jyb2tlci91dGlsLmdv) | `53.2% <0%> (-0.27%)` | :arrow_down: |
| [server/plugin/infra/registry/etcd/etcd.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/428/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9pbmZyYS9yZWdpc3RyeS9ldGNkL2V0Y2QuZ28=) | `86.23% <0%> (+0.19%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/428?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/428?src=pr&el=footer). Last update [9f55487...dcfbaac](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/428?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/incubator-servicecomb-service-center/pull/428 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [incubator-servicecomb-service-center] coveralls commented
on issue #428: [SCB-807]Limit the topology view to only 100 microservices.
Posted by "coveralls (GitHub)" <gi...@apache.org>.
[](https://coveralls.io/builds/18603996)
Coverage decreased (-0.1%) to 76.09% when pulling **dcfbaacb965824121aa4b807aa8340fb179802ec on xiaoyimei:develop** into **9f55487b6ed2a256a5d66fe028c4e986961921e9 on apache:master**.
[ Full content available at: https://github.com/apache/incubator-servicecomb-service-center/pull/428 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org