You are viewing a plain text version of this content. The canonical link for it is here.
Posted to proton@qpid.apache.org by astitcher <gi...@git.apache.org> on 2015/07/18 00:19:02 UTC
[GitHub] qpid-proton pull request: NO-JIRA: Change travis configuration to ...
GitHub user astitcher opened a pull request:
https://github.com/apache/qpid-proton/pull/47
NO-JIRA: Change travis configuration to use container based builds
This is specifically for comment from @dnwe - I'm proposing to change the travis build config to use containers, but I've stopped using the existng jenkins build script.
This does make the travis CI builds start almost immediately for me, so is a big win in my experience.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/astitcher/qpid-proton travis-container
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/qpid-proton/pull/47.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #47
----
commit 4476e97527f4a3b6ae8e85f0bd82cb660270eb16
Author: Andrew Stitcher <as...@apache.org>
Date: 2015-07-09T20:43:20Z
NO-JIRA: Change travis configuration to use container based builds
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] qpid-proton pull request: NO-JIRA: Change travis configuration to ...
Posted by astitcher <gi...@git.apache.org>.
Github user astitcher commented on the pull request:
https://github.com/apache/qpid-proton/pull/47#issuecomment-122436754
The tox thing is the bit I'm shakiest about - it seems to find 3 out of
the 4 pythons (not 2.6 I think) for some reason. I experimented with a
matrix test which also builds under python 3.4 and think that would be a
better way to cover multiple pythons using travis. However proton didn't
build with python 3.4 like that!
On Fri, Jul 17, 2015, at 06:29 PM, Dominic Evans wrote:
> Changes look reasonable to me. Faster sudoless docker builds would
> be cool.
> You dropped the PYTHON_DIRS bit which was for tox to locate the
> various Python interps. With the new format do we still get coverage
> on all the pythons?
> — Reply to this email directly or view it on GitHub[1].
>
Andrew
Links:
1. https://github.com/apache/qpid-proton/pull/47#issuecomment-122435936
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] qpid-proton pull request: NO-JIRA: Change travis configuration to ...
Posted by astitcher <gi...@git.apache.org>.
Github user astitcher commented on the pull request:
https://github.com/apache/qpid-proton/pull/47#issuecomment-122435378
It looks to me that the appveyor failure is due to some incidental issue with the service.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] qpid-proton pull request: NO-JIRA: Change travis configuration to ...
Posted by dnwe <gi...@git.apache.org>.
Github user dnwe commented on the pull request:
https://github.com/apache/qpid-proton/pull/47#issuecomment-122900045
@gemmellr the error message for py26 is quite odd. It seems like its failing on the new "compile proton from python if libqpid-proton isn't available to link against" that was added to the setup.py. I'm not sure why the libqpid-proton build via cmake isn't considered usable though.
Here's the output log
```
Processing ./.tox/dist/python-qpid-proton-0.10.0.zip
Building wheels for collected packages: python-qpid-proton
Running setup.py bdist_wheel for python-qpid-proton
Complete output from command /home/travis/build/apache/qpid-proton/proton-c/bindings/python/.tox/py26/bin/python2.6 -c "import setuptools;__file__='/tmp/pip-zTErui-build/setup.py';exec(compile(open(__file__).read().replace('\r\n', '\n'), __file__, 'exec'))" bdist_wheel -d /tmp/tmpTPU6sFpip-wheel-:
running bdist_wheel
running build
running build_ext
running configure
building '_cproton' extension
swigging cproton.i to cproton_wrap.c
swig -python -threads -o cproton_wrap.c cproton.i
cproton.i:394: Error: Unable to find 'proton/cproton.i'
error: command 'swig' failed with exit status 1
----------------------------------------
Failed building wheel for python-qpid-proton
Failed to build python-qpid-proton
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] qpid-proton pull request: NO-JIRA: Change travis configuration to ...
Posted by dnwe <gi...@git.apache.org>.
Github user dnwe commented on the pull request:
https://github.com/apache/qpid-proton/pull/47#issuecomment-122435936
Changes look reasonable to me. Faster sudoless docker builds would be cool.
You dropped the PYTHON_DIRS bit which was for tox to locate the various Python interps. With the new format do we still get coverage on all the pythons?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] qpid-proton pull request: NO-JIRA: Change travis configuration to ...
Posted by astitcher <gi...@git.apache.org>.
Github user astitcher commented on the pull request:
https://github.com/apache/qpid-proton/pull/47#issuecomment-123005675
I've raised [PROTON-951](https://issues.apache.org/jira/browse/PROTON-951) and [PROTON-952](https://issues.apache.org/jira/browse/PROTON-952) - which are related bugs to this discussion. [PROTON-952](https://issues.apache.org/jira/browse/PROTON-952) may be related to the python 2.6 tox issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] qpid-proton pull request: NO-JIRA: Change travis configuration to ...
Posted by gemmellr <gi...@git.apache.org>.
Github user gemmellr commented on the pull request:
https://github.com/apache/qpid-proton/pull/47#issuecomment-122924850
@astitcher ok great
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] qpid-proton pull request: NO-JIRA: Change travis configuration to ...
Posted by gemmellr <gi...@git.apache.org>.
Github user gemmellr commented on the pull request:
https://github.com/apache/qpid-proton/pull/47#issuecomment-122896223
Do the earlier comments mean that it no longer tests on 2.6 but did previously? Is that perhaps because the newer infrastructure doesn't include 2.6? or perhaps since the config is now specifying 2.7 explicitly? Possibly something worth mentioning more directly on the list.
Similarly, is Ken aware of the issue you saw with Python 3.4? Might also be worth pointing out.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] qpid-proton pull request: NO-JIRA: Change travis configuration to ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/qpid-proton/pull/47
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] qpid-proton pull request: NO-JIRA: Change travis configuration to ...
Posted by astitcher <gi...@git.apache.org>.
Github user astitcher commented on the pull request:
https://github.com/apache/qpid-proton/pull/47#issuecomment-122922144
@gemmellr I'm going to try to characterise the python 3 build issue a bit better then raise a JIRA.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] qpid-proton pull request: NO-JIRA: Change travis configuration to ...
Posted by dnwe <gi...@git.apache.org>.
Github user dnwe commented on the pull request:
https://github.com/apache/qpid-proton/pull/47#issuecomment-122437243
Ok. :+1. Ship it!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] qpid-proton pull request: NO-JIRA: Change travis configuration to ...
Posted by gemmellr <gi...@git.apache.org>.
Github user gemmellr commented on the pull request:
https://github.com/apache/qpid-proton/pull/47#issuecomment-122902052
@dnwe Yeah, I'm a bit lost with these bits I'm afraid hence the sugestion of mentioning any issues more directly on the list so those with a clue are aware something needs attention, as they likely won't have noticed these comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---